[lxc-devel] [PATCH 1/2] Add support for new target plamo to configure.ac

[TAMUKI Shoichi]

Hello,

From: Serge Hallyn <serge.hallyn at ubuntu.com>
Subject: Re: [lxc-devel] [PATCH 1/2] Add support for new target plamo to configure.ac
Date: Tue, 8 Dec 2015 15:56:53 +0000

> > Add support for new target plamo to specify the linux distribution.
> > Plamo Linux uses sysvinit.  Also, fold distro line at about 80 chars
> > because the line is too long.
> > 
> > Signed-off-by: KATOH Yasufumi <karma at jazz.email.ne.jp>
> > Signed-off-by: TAMUKI Shoichi <tamuki at linet.gr.jp>
> > ---
> >  configure.ac | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 8dae3ad..f46e3c8 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -34,7 +34,10 @@ AC_GNU_SOURCE
> >  # Detect the distribution. This is used for the default configuration and
> >  # for some distro-specific build options.
> >  AC_MSG_CHECKING([host distribution])
> > -AC_ARG_WITH(distro, AS_HELP_STRING([--with-distro=DISTRO], [Specify the Linux distribution to target: One of redhat, oracle, centos, fedora, suse, gentoo, debian, arch, slackware, paldo, openmandriva or pardus.]))
> > +AC_ARG_WITH(distro, AS_HELP_STRING([--with-distro=DISTRO], [Specify the Linux
> > +	distribution to target: One of redhat, oracle, centos, fedora, suse,
> > +	gentoo, debian, arch, slackware, plamo, paldo, openmandriva or
> > +	pardus.]))
> 
> No, please don't split this line.  It makes it harder to read in this case.
> 
> Even the kernel documentation style file clarifies that printed strings
> should not be split to fit into 80-cols :)
> 
> Probably just a split before the "[Specify" would help.

After patching configure.ac file as above, run autogen.sh with the
configure.ac, and then the created configure file contains as below:

[configure (part)]

Optional Packages:
  --with-PACKAGE[=ARG]    use PACKAGE [ARG=yes]
  --without-PACKAGE       do not use PACKAGE (same as --with-PACKAGE=no)
  --with-distro=DISTRO    Specify the Linux distribution to target: One of
                          redhat, oracle, centos, fedora, suse, gentoo,
                          debian, arch, slackware, plamo, paldo, openmandriva
                          or pardus.
  --with-init-script[=TYPE[,TYPE,...]]
                          Type(s) of init script to install: sysvinit,
                          systemd, upstart, distro [default=distro]

That means autoconf is able to format help strings including white-
spaces (spaces, tabs, and newlines) properly.  I do not think it makes
it harder to read in this case.

Regards,
TAMUKI Shoichi