[lxc-devel] [PATCH 1/2] Add support for new target plamo to configure.ac

[Serge Hallyn]

Quoting TAMUKI Shoichi (tamuki at linet.gr.jp):
> > > +++ b/configure.ac
> > > @@ -34,7 +34,10 @@ AC_GNU_SOURCE
> > >  # Detect the distribution. This is used for the default configuration and
> > >  # for some distro-specific build options.
> > >  AC_MSG_CHECKING([host distribution])
> > > -AC_ARG_WITH(distro, AS_HELP_STRING([--with-distro=DISTRO], [Specify the Linux distribution to target: One of redhat, oracle, centos, fedora, suse, gentoo, debian, arch, slackware, paldo, openmandriva or pardus.]))
> > > +AC_ARG_WITH(distro, AS_HELP_STRING([--with-distro=DISTRO], [Specify the Linux
> > > +	distribution to target: One of redhat, oracle, centos, fedora, suse,
> > > +	gentoo, debian, arch, slackware, plamo, paldo, openmandriva or
> > > +	pardus.]))
> > 
> > No, please don't split this line.  It makes it harder to read in this case.
> > 
> > Even the kernel documentation style file clarifies that printed strings
> > should not be split to fit into 80-cols :)
> > 
> > Probably just a split before the "[Specify" would help.
> 
> After patching configure.ac file as above, run autogen.sh with the
> configure.ac, and then the created configure file contains as below:
> 
> [configure (part)]
> 
> Optional Packages:
>   --with-PACKAGE[=ARG]    use PACKAGE [ARG=yes]
>   --without-PACKAGE       do not use PACKAGE (same as --with-PACKAGE=no)
>   --with-distro=DISTRO    Specify the Linux distribution to target: One of
>                           redhat, oracle, centos, fedora, suse, gentoo,
>                           debian, arch, slackware, plamo, paldo, openmandriva
>                           or pardus.
>   --with-init-script[=TYPE[,TYPE,...]]
>                           Type(s) of init script to install: sysvinit,
>                           systemd, upstart, distro [default=distro]
> 
> That means autoconf is able to format help strings including white-
> spaces (spaces, tabs, and newlines) properly.  I do not think it makes
> it harder to read in this case.

I was just thinking of when we're hacking on configure.ac itself.