[lxc-devel] [PATCH 1/2] Add support for new target plamo to configure.ac

[Serge Hallyn]

Quoting TAMUKI Shoichi (tamuki at linet.gr.jp):
> Add support for new target plamo to specify the linux distribution.
> Plamo Linux uses sysvinit.  Also, fold distro line at about 80 chars
> because the line is too long.
> 
> Signed-off-by: KATOH Yasufumi <karma at jazz.email.ne.jp>
> Signed-off-by: TAMUKI Shoichi <tamuki at linet.gr.jp>
> ---
>  configure.ac | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 8dae3ad..f46e3c8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -34,7 +34,10 @@ AC_GNU_SOURCE
>  # Detect the distribution. This is used for the default configuration and
>  # for some distro-specific build options.
>  AC_MSG_CHECKING([host distribution])
> -AC_ARG_WITH(distro, AS_HELP_STRING([--with-distro=DISTRO], [Specify the Linux distribution to target: One of redhat, oracle, centos, fedora, suse, gentoo, debian, arch, slackware, paldo, openmandriva or pardus.]))
> +AC_ARG_WITH(distro, AS_HELP_STRING([--with-distro=DISTRO], [Specify the Linux
> +	distribution to target: One of redhat, oracle, centos, fedora, suse,
> +	gentoo, debian, arch, slackware, plamo, paldo, openmandriva or
> +	pardus.]))

No, please don't split this line.  It makes it harder to read in this case.

Even the kernel documentation style file clarifies that printed strings
should not be split to fit into 80-cols :)

Probably just a split before the "[Specify" would help.

>  if type lsb_release >/dev/null 2>&1 && test "z$with_distro" = "z"; then
>  	with_distro=`lsb_release -is`
>  fi
> @@ -48,6 +51,7 @@ if test "z$with_distro" = "z"; then
>  	AC_CHECK_FILE(/etc/debian_version,with_distro="debian")
>  	AC_CHECK_FILE(/etc/arch-release,with_distro="arch")
>  	AC_CHECK_FILE(/etc/slackware-version,with_distro="slackware")
> +	AC_CHECK_FILE(/etc/plamo-version,with_distro="plamo")
>  	AC_CHECK_FILE(/etc/frugalware-release,with_distro="frugalware")
>  	AC_CHECK_FILE(/etc/mandrakelinux-release, with_distro="openmandriva")
>  	AC_CHECK_FILE(/etc/mandriva-release,with_distro="openmandriva")
> @@ -63,7 +67,7 @@ case $with_distro in
>  		distroconf=default.conf.lxcbr
>  		distrosysconf="$sysconfdir/default"
>  		;;
> -	redhat|centos|fedora|oracle|oracleserver|suse|opensuse*)
> +	redhat|centos|fedora|oracle|oracleserver|suse|opensuse*|plamo)
>  		distroconf=default.conf.lxcbr
>  		distrosysconf="$sysconfdir/sysconfig"
>  		;;
> @@ -90,7 +94,7 @@ case "$with_init_script" in
>  			fedora|opensuse*)
>  				init_script=systemd
>  				;;
> -			redhat|centos|oracle|oracleserver)
> +			redhat|centos|oracle|oracleserver|plamo)
>  				init_script=sysvinit
>  				;;
>  			debian|raspbian)
> -- 
> 2.2.1
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel