[lxc-users] policy for contributing patches?

[Stéphane Graber]

On Thu, Mar 16, 2017 at 01:50:24AM +0200, Simos Xenitellis wrote:
> On Tue, Mar 14, 2017 at 1:11 PM, Harald Dunkel <harald.dunkel at aixigo.de> wrote:
> > Hi folks,
> >
> > about 4 weeks ago I had sent a (simple) patch to a bug in
> > config/init/common/lxc-containers.in to the lxc-devel
> > mailing list. Problem: There was no response at all :-(.
> > Pretty disappointing. This was not my first patch. In the
> > past I found both lists lxc-users and lxc-devel quite
> > responsive.
> >
> > Did I miss to follow some policy here? Do I have to use
> > github to post patches?
> >
> >
> > Every helpful comment is highly appreciated
> 
> Hi!
> 
> I think you would need to make a "pull request" for your fix,
> so that it will appear in the end at
> https://github.com/lxc/lxc/pulls

This change has since been merged.

> The process for these "pull requests" is described at
> https://help.github.com/articles/creating-a-pull-request/
> With a pull request, the maintainers can add your change with just a
> click (if all are fine with the change!).

That's the preferred way to contribute though for LXC, contribution
through the mailing-list is still possible. Albeit much slower and
requires much more work on our side.

The main issue with this patch submission was the format, it wasn't
clearely identified with the [PATCH] prefix nor formatted using
git-send-email so it wasn't quite as visible as it should have been, and
needed a bit of work to then be sent for review.

> You would also need to complete the Contributor Agreement, found at
> https://www.ubuntu.com/legal/contributors

That's not needed, none of the LXC projects require the Canonical CLA.

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-users/attachments/20170316/2cad8b09/attachment.sig>