[lxc-devel] [lxc/lxc] e18ab0: cmd: lxc-usernsexec reorder includes

Tue Aug 21 15:39:13 UTC 2018

  Branch: refs/heads/stable-3.0
  Home:   https://github.com/lxc/lxc
  Commit: e18ab019d188421a29d210911d943e69e205e6c5
      https://github.com/lxc/lxc/commit/e18ab019d188421a29d210911d943e69e205e6c5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  cmd: lxc-usernsexec reorder includes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a819b385e8b4ce190859637c7f5b756d93981e44
      https://github.com/lxc/lxc/commit/a819b385e8b4ce190859637c7f5b756d93981e44
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/cmd/lxc_usernsexec.c
    M src/lxc/macro.h

  Log Message:
  -----------
  cmd: move declarations to macro.h

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 73572438966ad00d060c48b58a0fbfdcd8020867
      https://github.com/lxc/lxc/commit/73572438966ad00d060c48b58a0fbfdcd8020867
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  cmd: use utils.{c,h} helpers in lxc-usernsexec

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c9b6284845b37772d51338392e1dc4572e7eb7ed
      https://github.com/lxc/lxc/commit/c9b6284845b37772d51338392e1dc4572e7eb7ed
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  cmd: simplify lxc-usernsexec

Calculate length only once.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 71219feaad63dd0d22f6e150a1e6e47e19f26112
      https://github.com/lxc/lxc/commit/71219feaad63dd0d22f6e150a1e6e47e19f26112
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  cmd: use safe number parsers in lxc-usernsexec

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3991c6f95fb15172df0080b9caa9bcdbecd3b605
      https://github.com/lxc/lxc/commit/3991c6f95fb15172df0080b9caa9bcdbecd3b605
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/macro.h

  Log Message:
  -----------
  macro: add missing headers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 48095dd48b9ca685c13568ba5e599c4e60ab47f8
      https://github.com/lxc/lxc/commit/48095dd48b9ca685c13568ba5e599c4e60ab47f8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h
    M src/lxc/macro.h

  Log Message:
  -----------
  macro: add macvlan properties

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: fbdcc1b4556cf112a5ada98f33873e2563b926fd
      https://github.com/lxc/lxc/commit/fbdcc1b4556cf112a5ada98f33873e2563b926fd
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/tools/lxc_autostart.c

  Log Message:
  -----------
  tools: Indicate container startup failure

When running lxc-autostart we do not currently indicate failure to start
containers, either partial failure i.e. some of the containers failed to
start or total failure i.e. all of the containers failed to start.

Indicate container startup failure.  For total failure exit(1), for
partial failure exit(2).

Signed-off-by: Tobin C. Harding <me at tobin.cc>

  Commit: bc2c01a13391019747d8d7e0fe827ea0646b92a2
      https://github.com/lxc/lxc/commit/bc2c01a13391019747d8d7e0fe827ea0646b92a2
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/storage/nbd.c

  Log Message:
  -----------
  storage: exit() => _exit(). when exec is failed, child process needs to use _exit()

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 152c0dc8ef754649c7c8b1040af2ad486673c267
      https://github.com/lxc/lxc/commit/152c0dc8ef754649c7c8b1040af2ad486673c267
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/tools/lxc_wait.c

  Log Message:
  -----------
  tools: lxc-wait: add default log priority & cleanups

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: 0cf1cbf2fa7cfb257e77a66cbc9427278166e2c8
      https://github.com/lxc/lxc/commit/0cf1cbf2fa7cfb257e77a66cbc9427278166e2c8
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: fix path/lxcpath mixups in tty setup

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
Fixes: 6947153da ("conf: use mknod() to create dummy mount target")

  Commit: 349df8e326fe0e706aca596196612dc15e2e2956
      https://github.com/lxc/lxc/commit/349df8e326fe0e706aca596196612dc15e2e2956
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_usernsexec.c

  Log Message:
  -----------
  cmd: use goto for cleanup in lxc-usernsexec

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: fddd112c4778f22e4377b19d252f43a3fb6810f8
      https://github.com/lxc/lxc/commit/fddd112c4778f22e4377b19d252f43a3fb6810f8
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  cmd: Do not reassign variable before it is used

cppcheck emits warning

  Variable 'ofd' is reassigned a value before the old one has been used.

We do not need to initialise a variable if it is assigned to on first use.

Signed-off-by: Tobin C. Harding <me at tobin.cc>

  Commit: 0be127e005ce0713457a59db22adbb22b21ba427
      https://github.com/lxc/lxc/commit/0be127e005ce0713457a59db22adbb22b21ba427
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  cmd: Reduce scope of 'count' variable

Variable is used in one plaice only within a nested statement block.
The code is cleaner if the variable is declared near where it is used.
Found using cppcheck.

Reduce the scope of 'count' variable.

Signed-off-by: Tobin C. Harding <me at tobin.cc>

  Commit: 8b0e52e7c9dc9e26165312426249c70987bf4b3c
      https://github.com/lxc/lxc/commit/8b0e52e7c9dc9e26165312426249c70987bf4b3c
  Author: Tobin C. Harding <me at tobin.cc>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/cmd/lxc_init.c
    M src/lxc/cmd/lxc_monitord.c
    M src/lxc/cmd/lxc_user_nic.c

  Log Message:
  -----------
  cmd: Fix format issues found by clang-format

clang-format finds a few format issues, lets fix these up.

Fix format issues found by clang-format.

Signed-off-by: Tobin C. Harding <me at tobin.cc>

  Commit: a03bd5d608039268fa6bb226705062512ad74400
      https://github.com/lxc/lxc/commit/a03bd5d608039268fa6bb226705062512ad74400
  Author: 2xsec <dh48.jeong at samsung.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/list.h

  Log Message:
  -----------
  list: fix indent

Signed-off-by: 2xsec <dh48.jeong at samsung.com>

  Commit: bcd0f26ce2b9b90cf7e52fae3294ca8000386332
      https://github.com/lxc/lxc/commit/bcd0f26ce2b9b90cf7e52fae3294ca8000386332
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/cmd/lxc_init.c
    A src/lxc/file_utils.c
    A src/lxc/file_utils.h
    M src/lxc/freezer.c
    M src/lxc/initutils.c
    M src/lxc/initutils.h
    M src/lxc/macro.h
    M src/lxc/parse.c
    M src/lxc/parse.h
    A src/lxc/string_utils.c
    A src/lxc/string_utils.h
    M src/lxc/utils.c
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: split into {file,string}_utils.{c,h}

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e9cab3e7810ae70e4f6202f4c332c261de0040b5
      https://github.com/lxc/lxc/commit/e9cab3e7810ae70e4f6202f4c332c261de0040b5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/Makefile.am
    M src/lxc/pam/pam_cgfs.c
    R src/lxc/pam/utils.c
    R src/lxc/pam/utils.h

  Log Message:
  -----------
  pam_cgfs: build from the same sources as liblxc

Closes #2556.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ca4eb982228a1ae5a061a6ea116649c685118a69
      https://github.com/lxc/lxc/commit/ca4eb982228a1ae5a061a6ea116649c685118a69
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2018-08-21 (Tue, 21 Aug 2018)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: fix devpts mounting when fully unprivileged

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/c46ce04b9f17...ca4eb982228a
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.