[lxc-devel] [lxc/master] Makefile: don't allow undefined symbols

[brauner on Github]

A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 364 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20180821/0c294fcb/attachment.bin>
-------------- next part --------------
From 7b0791f7a6d94e5de071f0562fe1eea619ab95d2 Mon Sep 17 00:00:00 2001
From: Christian Brauner <christian.brauner at ubuntu.com>
Date: Tue, 21 Aug 2018 17:13:39 +0200
Subject: [PATCH] Makefile: don't allow undefined symbols

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
---
 src/lxc/Makefile.am | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/lxc/Makefile.am b/src/lxc/Makefile.am
index 32bb8d5e0..3df290f3c 100644
--- a/src/lxc/Makefile.am
+++ b/src/lxc/Makefile.am
@@ -211,7 +211,8 @@ endif
 liblxc_la_CFLAGS = -fPIC \
 		   -DPIC \
 		   $(AM_CFLAGS) \
-		   -pthread
+		   -pthread \
+		   -Wl,-no-undefined
 
 liblxc_la_LDFLAGS = -pthread \
 		    -Wl,-soname,liblxc.so.$(firstword $(subst ., , at LXC_ABI@)) \
@@ -401,7 +402,8 @@ pam_cgfs_la_SOURCES += ../include/strlcpy.c ../include/strlcpy.h
 endif
 
 pam_cgfs_la_CFLAGS = $(AM_CFLAGS) \
-		     -DNO_LOG
+		     -DNO_LOG \
+		     -Wl,-no-undefined
 
 pam_cgfs_la_LIBADD = $(AM_LIBS) \
 		     $(PAM_LIBS) \