[lxc-devel] [lxc/lxc] d9d811: Fix a format string build failure on x32.

GitHub noreply at github.com
Thu Oct 19 01:22:27 UTC 2017


  Branch: refs/heads/stable-2.1
  Home:   https://github.com/lxc/lxc
  Commit: d9d811bf67fc236a9976586ee83a4d56acb0d914
      https://github.com/lxc/lxc/commit/d9d811bf67fc236a9976586ee83a4d56acb0d914
  Author: Adam Borowski <kilobyte at angband.pl>
  Date:   2017-10-18 (Wed, 18 Oct 2017)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  Fix a format string build failure on x32.

Both of struct timespec fields are 64-bit on any new architecture, even
32-bit ones.

Signed-off-by: Adam Borowski <kilobyte at angband.pl>


  Commit: d6223eead3bed6e337b24c48e0824738666ae4ba
      https://github.com/lxc/lxc/commit/d6223eead3bed6e337b24c48e0824738666ae4ba
  Author: Adam Borowski <kilobyte at angband.pl>
  Date:   2017-10-18 (Wed, 18 Oct 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_legacy.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  Use the proper type for rlim_t, fixing build failure on x32.

Assuming a particular width of a type (or equivalence with "long") doesn't
work everywhere.  On new architectures, LFS/etc is enabled by default,
making rlim_t same as rlim64_t even if long is only 32-bit.

Not sure how you handle too big values -- you may want to re-check the
strtoull part.

Signed-off-by: Adam Borowski <kilobyte at angband.pl>


Compare: https://github.com/lxc/lxc/compare/50d5fde16f83...d6223eead3be


More information about the lxc-devel mailing list