[lxc-devel] [lxc/lxc] 291f64: Fix a format string build failure on x32.

GitHub noreply at github.com
Wed Oct 18 22:25:17 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 291f64ac27813451f4045e512a8f2c3e425af254
      https://github.com/lxc/lxc/commit/291f64ac27813451f4045e512a8f2c3e425af254
  Author: Adam Borowski <kilobyte at angband.pl>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  Fix a format string build failure on x32.

Both of struct timespec fields are 64-bit on any new architecture, even
32-bit ones.

Signed-off-by: Adam Borowski <kilobyte at angband.pl>


  Commit: 714608316e4dd6216c68b663666e98962b6a8bae
      https://github.com/lxc/lxc/commit/714608316e4dd6216c68b663666e98962b6a8bae
  Author: Adam Borowski <kilobyte at angband.pl>
  Date:   2017-10-16 (Mon, 16 Oct 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_legacy.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h

  Log Message:
  -----------
  Use the proper type for rlim_t, fixing build failure on x32.

Assuming a particular width of a type (or equivalence with "long") doesn't
work everywhere.  On new architectures, LFS/etc is enabled by default,
making rlim_t same as rlim64_t even if long is only 32-bit.

Not sure how you handle too big values -- you may want to re-check the
strtoull part.

Signed-off-by: Adam Borowski <kilobyte at angband.pl>


  Commit: ecc94d764f44b979dcb2fb51f559c25e2e84cae1
      https://github.com/lxc/lxc/commit/ecc94d764f44b979dcb2fb51f559c25e2e84cae1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-10-19 (Thu, 19 Oct 2017)

  Changed paths:
    M src/lxc/confile.c
    M src/lxc/confile_legacy.c
    M src/lxc/confile_utils.c
    M src/lxc/confile_utils.h
    M src/lxc/log.c

  Log Message:
  -----------
  Merge pull request #1860 from kilobyte/master

fix build failures on x32


Compare: https://github.com/lxc/lxc/compare/8c104d583c2c...ecc94d764f44


More information about the lxc-devel mailing list