[lxc-devel] [lxc/lxc] b69dfc: coverity: #1425874 + cleanup

GitHub noreply at github.com
Wed Dec 13 18:22:32 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: b69dfc9fcb4d4350ae065c7c1ac9874f67ba983c
      https://github.com/lxc/lxc/commit/b69dfc9fcb4d4350ae065c7c1ac9874f67ba983c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  coverity: #1425874 + cleanup

- check for memory allocation failure
- free allocated memory
- cleanup function

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: acbfeda88b86990e2ded18ca4497637fb1b8738d
      https://github.com/lxc/lxc/commit/acbfeda88b86990e2ded18ca4497637fb1b8738d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: only attach netns on netdev detach

Detaching network namespaces as an unprivileged user is currently not possible
and attaching to the user namespace will mean we are not allowed to move the
network device into an ancestor network namespace.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c7d76c09476d004754045d72f1c4711538ba8cbd
      https://github.com/lxc/lxc/commit/c7d76c09476d004754045d72f1c4711538ba8cbd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: cleanup {attach,detach}_interface()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 352e79d458b6a9e72a8bfaa94a054fb250013b5f
      https://github.com/lxc/lxc/commit/352e79d458b6a9e72a8bfaa94a054fb250013b5f
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2017-12-13 (Wed, 13 Dec 2017)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  Merge pull request #2025 from brauner/2017-12-12/fix_network_attach_and_detach

lxccontainer: only attach netns on netdev detach


Compare: https://github.com/lxc/lxc/compare/13700360891e...352e79d458b6


More information about the lxc-devel mailing list