[lxc-devel] [lxc/lxc] 19bfbf: tools: block using lxc-execute without config file

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 19bfbf6e94158c99bb093248d782ae7814b16d16
      https://github.com/lxc/lxc/commit/19bfbf6e94158c99bb093248d782ae7814b16d16
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/tools/lxc_execute.c

  Log Message:
  -----------
  tools: block using lxc-execute without config file

Moving away from internal symbols we can't do hacks like we currently do in
lxc-start and call internal functions like lxc_conf_init(). This is unsafe
anyway. Instead, we should simply error out if the user didn't give us a
configuration file to use. lxc-start refuses to start in that case already.

Relates to discussion in https://github.com/lxc/go-lxc/pull/96#discussion_r155075560 .
Closes #2023.

Reported-by: Felix Abecassis <fabecassis at nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6c84b5994ab0d3bbd9d1a7210c97cdf7084bb3fa
      https://github.com/lxc/lxc/commit/6c84b5994ab0d3bbd9d1a7210c97cdf7084bb3fa
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2017-12-12 (Tue, 12 Dec 2017)

  Changed paths:
    M src/lxc/tools/lxc_execute.c

  Log Message:
  -----------
  tools: exit success when lxc-execute is daemonized

The error_num value doesn't tell us anything since the container hasn't exited.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 13700360891eae9413f3bfb597328febc760f312
      https://github.com/lxc/lxc/commit/13700360891eae9413f3bfb597328febc760f312
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2017-12-13 (Wed, 13 Dec 2017)

  Changed paths:
    M src/lxc/tools/lxc_execute.c

  Log Message:
  -----------
  Merge pull request #2024 from brauner/2017-11-12/fix_lxc_execute

tools: block using lxc-execute without config file


Compare: https://github.com/lxc/lxc/compare/d987c5da4d0b...13700360891e