[lxc-devel] [lxc/lxc] 155543: Include all lxcmntent.h function declarations on B...

GitHub noreply at github.com
Tue Jun 28 17:39:48 UTC 2016


  Branch: refs/heads/stable-2.0
  Home:   https://github.com/lxc/lxc
  Commit: 155543d95101b6176fbe2553b766faf55a499890
      https://github.com/lxc/lxc/commit/155543d95101b6176fbe2553b766faf55a499890
  Author: Preetam D'Souza <preetamjdsouza at gmail.com>
  Date:   2016-06-28 (Tue, 28 Jun 2016)

  Changed paths:
    M src/include/lxcmntent.h

  Log Message:
  -----------
  Include all lxcmntent.h function declarations on Bionic

Newer versions of Android (5.0+, aka API Level 21+) include mntent.h,
which declares setmntent and endmntent. This hits an edge
case with the preprocessor checks in lxcmntent.h because HAVE_SETMNTENT
and HAVE_ENDMNTENT are both defined (in Bionic's mntent.h), but conf.c
always includes lxcmntent.h on Bionic! As a result, we get compiler
warnings of implicit function declarations for setmntent endmntent.

This patch always includes setmntent/endmntent/hasmntopt function
declarations on Bionic, which gets rid of these warnings.

Signed-off-by: Preetam D'Souza <preetamjdsouza at gmail.com>




More information about the lxc-devel mailing list