[lxc-devel] [lxc/lxc] 702f5a: Include all lxcmntent.h function declarations on B...

GitHub noreply at github.com
Tue Jun 28 17:36:47 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 702f5a1c640244829f2f5f20f6ab821e86a8858c
      https://github.com/lxc/lxc/commit/702f5a1c640244829f2f5f20f6ab821e86a8858c
  Author: Preetam D'Souza <preetamjdsouza at gmail.com>
  Date:   2016-06-28 (Tue, 28 Jun 2016)

  Changed paths:
    M src/include/lxcmntent.h

  Log Message:
  -----------
  Include all lxcmntent.h function declarations on Bionic

Newer versions of Android (5.0+, aka API Level 21+) include mntent.h,
which declares setmntent and endmntent. This hits an edge
case with the preprocessor checks in lxcmntent.h because HAVE_SETMNTENT
and HAVE_ENDMNTENT are both defined (in Bionic's mntent.h), but conf.c
always includes lxcmntent.h on Bionic! As a result, we get compiler
warnings of implicit function declarations for setmntent endmntent.

This patch always includes setmntent/endmntent/hasmntopt function
declarations on Bionic, which gets rid of these warnings.

Signed-off-by: Preetam D'Souza <preetamjdsouza at gmail.com>


  Commit: d6c86f57faed53f859cac4207ecacb8b60ef1f9d
      https://github.com/lxc/lxc/commit/d6c86f57faed53f859cac4207ecacb8b60ef1f9d
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2016-06-28 (Tue, 28 Jun 2016)

  Changed paths:
    M src/include/lxcmntent.h

  Log Message:
  -----------
  Merge pull request #1063 from pdsouza/pdsouza/fix-bionic-lxcmntent

Include all lxcmntent.h function declarations on Bionic


Compare: https://github.com/lxc/lxc/compare/9aea6610d992...d6c86f57faed


More information about the lxc-devel mailing list