[lxc-devel] [lxd/master] Re-enable /dev/console

[stgraber on Github]

A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 626 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20160202/e5e1e603/attachment.bin>
-------------- next part --------------
From a100a5666b02416dce644ace51811deba656d32a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Graber?= <stgraber at ubuntu.com>
Date: Mon, 1 Feb 2016 09:07:31 +0100
Subject: [PATCH] Re-enable /dev/console
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This re-enables a pts device backing /dev/console and allows container
writes to it.

That change will break CRIU until it knows how to deal with
/dev/console, but lakc of /dev/console is breaking enough workloads that
it's the best option for now.

Closes #1463

Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>
---
 lxd/container_lxc.go | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/lxd/container_lxc.go b/lxd/container_lxc.go
index 4a9e462..fa0dd31 100644
--- a/lxd/container_lxc.go
+++ b/lxd/container_lxc.go
@@ -386,17 +386,6 @@ func (c *containerLXC) initLXC() error {
 		return err
 	}
 
-	// FIXME: Should go away once CRIU supports checkpoint/restore of /dev/console
-	err = lxcSetConfigItem(cc, "lxc.console", "none")
-	if err != nil {
-		return err
-	}
-
-	err = lxcSetConfigItem(cc, "lxc.cgroup.devices.deny", "c 5:1 rwm")
-	if err != nil {
-		return err
-	}
-
 	// Setup the hostname
 	err = lxcSetConfigItem(cc, "lxc.utsname", c.Name())
 	if err != nil {