[lxc-devel] [lxc/lxc] 1ec0e8: Fix NULL-ptr derefs for container without rootfs

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1ec0e8e3fd766ff77c6128f384772f407f9b75da
      https://github.com/lxc/lxc/commit/1ec0e8e3fd766ff77c6128f384772f407f9b75da
  Author: Christian Brauner <christian.brauner at mailbox.org>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M src/lxc/bdev/lxcoverlay.c
    M src/lxc/conf.c

  Log Message:
  -----------
  Fix NULL-ptr derefs for container without rootfs

Since we allow containers to be created without a rootfs most checks in conf.c
are not sane anymore. Instead of just checking if rootfs->path != NULL we need
to check whether rootfs != NULL.

Minor fixes:
- Have mount_autodev() always return -1 on failure: mount_autodev() returns 0
  on success and -1 on failure. But when the return value of safe_mount() was
  checked in mount_autodev() we returned false (instead of -1) which caused
  mount_autodev() to return 0 (success) instead of the correct -1 (failure).

Signed-off-by: Christian Brauner <christian.brauner at mailbox.org>


  Commit: 5e75dea27b483b82da615bd5d0bb5b802da95176
      https://github.com/lxc/lxc/commit/5e75dea27b483b82da615bd5d0bb5b802da95176
  Author: Stéphane Graber <stgraber at stgraber.org>
  Date:   2016-02-02 (Tue, 02 Feb 2016)

  Changed paths:
    M src/lxc/bdev/lxcoverlay.c
    M src/lxc/conf.c

  Log Message:
  -----------
  Merge pull request #796 from brauner/2016-02-02/fix_execute_null_ptr_deref

Fix NULL-ptr derefs for container without rootfs


Compare: https://github.com/lxc/lxc/compare/06b5b4d96a6d...5e75dea27b48