[lxc-devel] [PATCH] Fix wrong calculations in clone_update_unexp_hooks()

Christian Brauner christianvanbrauner at gmail.com
Tue Nov 3 13:41:39 UTC 2015


On Mon, Nov 02, 2015 at 02:36:13PM +0100, Christian Brauner wrote:
> (1) This commit fixes some long standing miscalculation when updating paths in
>     lxc.hooks.* entries. We now also update conf->unexpandend_alloced which
>     hasn't been done prior to this commit. According to my testing valgrind now
>     no longer reports "x bytes definitely lost" when using lxc-clone.
> 
> (2) Also we use the stricter check:
> 
>     	if (p >= lend)
>     		continue;
> 
>     This should deal better with invalid config files.
> 
> (3) Insert some spaces between operators to increase readability.

If the changes to clone_udpate_unexp_ovl_paths() are accepted. I think we should
update this patch accordingly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20151103/6970b8e0/attachment.sig>


More information about the lxc-devel mailing list