[lxc-devel] [RFC PATCH] lxc_cmd_stop_callback(): Fix return value handling of kill()

Thomas Jarosch thomas.jarosch at intra2net.com
Tue Dec 29 13:45:31 UTC 2015


On Monday, 21. December 2015 20:58:02 Serge Hallyn wrote:
> > > > I'm not sure how frozen processes react to signal delivery,
> > > > judging from the code below it's not possible and that's
> > > > the reason unfreeze() is called. Please double check.
> > > 
> > > (no signed-off-by)
> > > 
> > > nack - we in fact want to unfreeze, and return success, only if
> > > the kill succeeded.
> > 
> > thanks for checking!
> 
> np, thanks for looking.  A patch to add a clarifying comment would be
> welcome :)

I first need to figure out why I'm getting "failed to unfreeze()" messages
in the log for "init" processes (PID 1) that don't terminate themselves
on SIGTERM. That got me curious in the first place.

Cheers,
Thomas



More information about the lxc-devel mailing list