[lxc-devel] [RFC PATCH] lxc_cmd_stop_callback(): Fix return value handling of kill()
Serge Hallyn
serge.hallyn at ubuntu.com
Mon Dec 21 20:58:02 UTC 2015
Quoting Thomas Jarosch (thomas.jarosch at intra2net.com):
> On Monday, 21. December 2015 07:26:42 Serge Hallyn wrote:
> > Quoting Thomas Jarosch (thomas.jarosch at intra2net.com):
> > > kill() returns 0 on success or -1 on error.
> > >
> > > I'm not sure how frozen processes react to signal delivery,
> > > judging from the code below it's not possible and that's
> > > the reason unfreeze() is called. Please double check.
> >
> > (no signed-off-by)
> >
> > nack - we in fact want to unfreeze, and return success, only if
> > the kill succeeded.
>
> thanks for checking!
np, thanks for looking. A patch to add a clarifying comment would be
welcome :)
More information about the lxc-devel
mailing list