[lxc-devel] [PATCH 3/9] lxc_start: ERROR if container is already running.

[Serge Hallyn]

Quoting Tycho Andersen (tycho.andersen at canonical.com):
> On Fri, Oct 10, 2014 at 11:16:54AM +0800, Dongsheng Yang wrote:
> > We should exit with a error when starting a running container.
> 
> Is this intentional? I just noticed it when pulling from master that
> it breaks some of my scripts. Are we sure it doesn't break anything
> else?

Which scripts does it break?

> Tycho
> 
> > Signed-off-by: Dongsheng Yang <yangds.fnst at cn.fujitsu.com>
> > Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
> > ---
> >  src/lxc/lxc_start.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/src/lxc/lxc_start.c b/src/lxc/lxc_start.c
> > index e836325..9a05356 100644
> > --- a/src/lxc/lxc_start.c
> > +++ b/src/lxc/lxc_start.c
> > @@ -276,6 +276,10 @@ int main(int argc, char *argv[])
> >  		}
> >  	}
> >  
> > +	if (c->is_running(c)) {
> > +		ERROR("Container is already running.");
> > +		goto out;
> > +	}
> >  	/*
> >  	 * We should use set_config_item() over &defines, which would handle
> >  	 * unset c->lxc_conf for us and let us not use lxc_config_define_load()
> > -- 
> > 1.8.4.2
> > 
> > _______________________________________________
> > lxc-devel mailing list
> > lxc-devel at lists.linuxcontainers.org
> > http://lists.linuxcontainers.org/listinfo/lxc-devel