[lxc-devel] [lxc/lxc] 31efc3: archlinux template: added sigpwr handling to syste...

[Stéphane Graber]

On Wed, May 07, 2014 at 01:11:39PM -0500, Leonid Isaev wrote:
> Hi,
> 
> 	Unless I am missing something, I see multiple issues with this change:
> 
> 1. The template still includes lxc.stopsignal=SIGRTMIN+4 in config which is a
> proper shutdown signal for systemd (it triggeres poweroff.target). So at best,
> the patch is incomplete.
> 
> 2. The general logic should be that LXC guests receive minimal modifications
> relative to bare metal installs. All necessary tweaks should be done in the
> config file and via cmdline options to lxc-stop/start.
> 
> 3. Symlinking poweroff.target to sigpwr.target is an obscure and unnecessary
> hack. The author really should have read systemd documentation, specifically
> systemd.special(7).
> 
> Thanks,
> Leonid.

Ok, I believe we had other systemd distros use that trick (Oracle and
OpenSUSE), so it may be best to agree on one implementation of that with
systemd and go with it.

So what you're saying is that before this change, clean shutdown using
lxc-stop was already working for ArchLinux?

If so, I'll just revert the patch.

(CCed the author of that change)

> 
> On Wed, 07 May 2014 06:46:18 -0700
> GitHub <noreply at github.com> wrote:
> 
> >   Branch: refs/heads/master
> >   Home:   https://github.com/lxc/lxc
> >   Commit: 31efc34cff23365a213f03b4f804885adae3fba6
> >       https://github.com/lxc/lxc/commit/31efc34cff23365a213f03b4f804885adae3fba6
> >   Author: Edvinas Klovas <edvinas at pnd.io>
> >   Date:   2014-05-07 (Wed, 07 May 2014)
> > 
> >   Changed paths:
> >     M templates/lxc-archlinux.in
> > 
> >   Log Message:
> >   -----------
> >   archlinux template: added sigpwr handling to systemd (lxc-stop)
> > 
> > archlinux is using systemd and systemd's configuration does not have any
> > services setup to handle sigpwr hook which is sent by lxc-stop command. By
> > enabling sigpwr service we make sure that lxc-stop will work.
> > 
> > Signed-off-by: Edvinas Klovas <edvinas at pnd.io>
> > Acked-by: Stéphane Graber <stgraber at ubuntu.com>
> > 
> > 
> 
> 
> 
> -- 
> Leonid Isaev
> GPG fingerprints: DA92 034D B4A8 EC51 7EA6  20DF 9291 EE8A 043C B8C4
>                   C0DF 20D0 C075 C3F1 E1BE  775A A7AE F6CB 164B 5A6D



> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140507/f4cdf704/attachment.sig>