[lxc-devel] [lxc/lxc] 31efc3: archlinux template: added sigpwr handling to syste...

[Leonid Isaev]

Hi,

	Unless I am missing something, I see multiple issues with this change:

1. The template still includes lxc.stopsignal=SIGRTMIN+4 in config which is a
proper shutdown signal for systemd (it triggeres poweroff.target). So at best,
the patch is incomplete.

2. The general logic should be that LXC guests receive minimal modifications
relative to bare metal installs. All necessary tweaks should be done in the
config file and via cmdline options to lxc-stop/start.

3. Symlinking poweroff.target to sigpwr.target is an obscure and unnecessary
hack. The author really should have read systemd documentation, specifically
systemd.special(7).

Thanks,
Leonid.

On Wed, 07 May 2014 06:46:18 -0700
GitHub <noreply at github.com> wrote:

>   Branch: refs/heads/master
>   Home:   https://github.com/lxc/lxc
>   Commit: 31efc34cff23365a213f03b4f804885adae3fba6
>       https://github.com/lxc/lxc/commit/31efc34cff23365a213f03b4f804885adae3fba6
>   Author: Edvinas Klovas <edvinas at pnd.io>
>   Date:   2014-05-07 (Wed, 07 May 2014)
> 
>   Changed paths:
>     M templates/lxc-archlinux.in
> 
>   Log Message:
>   -----------
>   archlinux template: added sigpwr handling to systemd (lxc-stop)
> 
> archlinux is using systemd and systemd's configuration does not have any
> services setup to handle sigpwr hook which is sent by lxc-stop command. By
> enabling sigpwr service we make sure that lxc-stop will work.
> 
> Signed-off-by: Edvinas Klovas <edvinas at pnd.io>
> Acked-by: Stéphane Graber <stgraber at ubuntu.com>
> 
> 



-- 
Leonid Isaev
GPG fingerprints: DA92 034D B4A8 EC51 7EA6  20DF 9291 EE8A 043C B8C4
                  C0DF 20D0 C075 C3F1 E1BE  775A A7AE F6CB 164B 5A6D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20140507/afd52f66/attachment.sig>