[lxc-devel] [PATCH] use btrfs snapshot feature to restore snapshots (fixes #131)

S.Çağlar Onur caglar at 10ur.org
Fri Feb 28 18:13:24 UTC 2014


Hi,

On Fri, Feb 28, 2014 at 12:57 PM, John Peacock
<jpeacock at messagesystems.com> wrote:
> On Fri, 2014-02-28 at 11:52 -0600, Serge Hallyn wrote:
>> > +   if (bdevtype && strcmp(orig->type, "btrfs") == 0 && strcmp(new->type, "btrfs") == 0) {
>>
>> Is it possible to hit this case when a user does
>>
>> lxc-clone -p /opt/btr1 -P /opt/btr2 -B btrfs -o p1 -n p2 ?
>>
>> So they want to copy-clone a btrfs container to a new btrfs container
>> on a different btrfs filesystem ?
>
> Yes, that would be a problem.  In order to use the snapshot restore
> functionality, both orig and new would have to be on the same btrfs
> filesystem.  I don't know off the top of my head how to determine that,
> but it would be a necessary precondition for this code to work
> consistently.

Good point. I'll try to find a way to determine that and will
re-submit or will let you know that I failed :)

> John
>
> --
> JOHN PEACOCK
> senior software build and release engineer
> www.messagesystems.com
> twitter @MessageSystems
>
> tel 410-872-4910 x239
> email john.peacock at messagesystems.com
> _______________________________________________
> lxc-devel mailing list
> lxc-devel at lists.linuxcontainers.org
> http://lists.linuxcontainers.org/listinfo/lxc-devel



-- 
S.Çağlar Onur <caglar at 10ur.org>


More information about the lxc-devel mailing list