[lxc-devel] [PATCH] use btrfs snapshot feature to restore snapshots (fixes #131)

[John Peacock]

On Fri, 2014-02-28 at 11:52 -0600, Serge Hallyn wrote:
> > +	if (bdevtype && strcmp(orig->type, "btrfs") == 0 && strcmp(new->type, "btrfs") == 0) {
> 
> Is it possible to hit this case when a user does
> 
> lxc-clone -p /opt/btr1 -P /opt/btr2 -B btrfs -o p1 -n p2 ?
> 
> So they want to copy-clone a btrfs container to a new btrfs container
> on a different btrfs filesystem ?

Yes, that would be a problem.  In order to use the snapshot restore
functionality, both orig and new would have to be on the same btrfs
filesystem.  I don't know off the top of my head how to determine that,
but it would be a necessary precondition for this code to work
consistently.

John

-- 
JOHN PEACOCK
senior software build and release engineer
www.messagesystems.com
twitter @MessageSystems

tel 410-872-4910 x239
email john.peacock at messagesystems.com