[lxc-devel] [PATCH] umount $rootfs/lib on errors as well otherwise system ends up with stalled mounts

[S.Çağlar Onur]

Hi Serge,

Then there must be something else going on cause without this patch I find
myself in the situation that I described earlier in this email [1]

[1] http://sourceforge.net/mailarchive/message.php?msg_id=31539485


On Mon, Oct 21, 2013 at 8:11 PM, Serge Hallyn <serge.hallyn at ubuntu.com>wrote:

> Quoting S.Çağlar Onur (caglar at 10ur.org):
> > Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>
>
> Actually this isn't necessary, nor is the umount in the success
> path.  This code is executed in a fresh mount namespace.
>
> > ---
> >  templates/lxc-busybox.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/templates/lxc-busybox.in b/templates/lxc-busybox.in
> > index cbdaaf3..44f0a45 100644
> > --- a/templates/lxc-busybox.in
> > +++ b/templates/lxc-busybox.in
> > @@ -209,6 +209,7 @@ EOFF
> >
> >  if [ \$? -ne 0 ]; then
> >      echo "Failed to change root password"
> > +    umount $rootfs/lib
> >      exit 1
> >  fi
> >
> > --
> > 1.8.3.2
> >
> >
> >
> ------------------------------------------------------------------------------
> > October Webinars: Code for Performance
> > Free Intel webinars can help you accelerate application performance.
> > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most
> from
> > the latest Intel processors and coprocessors. See abstracts and register
> >
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
> > _______________________________________________
> > Lxc-devel mailing list
> > Lxc-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/lxc-devel
>



-- 
S.Çağlar Onur <caglar at 10ur.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20131021/79e09abc/attachment.html>