[lxc-devel] [PATCH] umount $rootfs/lib on errors as well otherwise system ends up with stalled mounts

[Serge Hallyn]

Quoting S.Çağlar Onur (caglar at 10ur.org):
> Signed-off-by: S.Çağlar Onur <caglar at 10ur.org>

Actually this isn't necessary, nor is the umount in the success
path.  This code is executed in a fresh mount namespace.

> ---
>  templates/lxc-busybox.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/templates/lxc-busybox.in b/templates/lxc-busybox.in
> index cbdaaf3..44f0a45 100644
> --- a/templates/lxc-busybox.in
> +++ b/templates/lxc-busybox.in
> @@ -209,6 +209,7 @@ EOFF
>  
>  if [ \$? -ne 0 ]; then
>      echo "Failed to change root password"
> +    umount $rootfs/lib
>      exit 1
>  fi
>  
> -- 
> 1.8.3.2
> 
> 
> ------------------------------------------------------------------------------
> October Webinars: Code for Performance
> Free Intel webinars can help you accelerate application performance.
> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
> the latest Intel processors and coprocessors. See abstracts and register >
> http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel