[lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

Christian Seiler christian at iwakd.de
Thu Mar 28 16:46:56 UTC 2013


Hi there,

> Can we easily move the clearenv() to an lxc-attach argument?
> If so, I'd prefer we make it an option rather than remove it 
> entirely.

Well, in my list that I posted earlier, I suggested adding an option to
clear the environment anyway, even if the (for post 0.9 more
complicated) defaults will say no.

So what we could do is:

  - don't clear env by default for now
    (in line with previous attach behaviour, so we don't change
    anything for now)
  - add '--clear-env' option that clears environment regardless
  - add '--keep-env' option that is a no-op in 0.9
  - post 0.9: make defaults more sane, according to my list with
    potential adjustments from discussions; the new options will then
    still work and thus be future-proof. But document in the manpage
    of 0.9 that default behaviour will likely change in 1.0. This
    allows for a sort of transition period where people can upgrade
    from previous versions (no change in defaults) but are able to
    explicitly choose what they want and write future-proof scripts.

This seems to be a reasonable compromise. If both Serge and you agree,
I'll write, test and send a patch before Sunday, so it can still go
into 0.9.

-- Christian





More information about the lxc-devel mailing list