[lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

Stéphane Graber stgraber at ubuntu.com
Thu Mar 28 16:25:05 UTC 2013


On 03/28/2013 11:52 AM, Serge Hallyn wrote:
> Quoting Christian Seiler (christian at iwakd.de):
>> Hi there,
>>
>>>> In light of the fact that 0.9 is going to be here soon, any
>>>> comments on
>>>> this?
>>>
>>> Sorry, I was waiting to see if anyone else would comment.  Note this
>>> kind of change is not going to be non-trivial, so it's definately
>>> (imo)
>>> 1.0 material
>>
>> My problem is that the current patch in staging that clears the
>> environment breaks a lot of things that I'm currently doing with lxc
>> and I'd really hate to need to manually patch 0.9, especially since we
>> now have situation where everything I want to do with LXC can be done
>> with vanilla kernel 3.8 and vanilla LXC 0.9~rc1.
>>
>> Since lxc-attach has been there since quite a while and people may have
>> been using it (especially since kernel 3.8), could we perhaps revert
>> the patch that clears the environment in attach for 0.9 and implement
>> it properly in 1.0? (And perhaps backport that part to 0.9.1) I know
>> that dragging in the complete environment has its own problems, but at
>> least for me it currently breaks more than it fixes.
>>
>> Thoughts?
> 
> It seems reasonable to me.  Stéphane, ok with you?

Can we easily move the clearenv() to an lxc-attach argument?
If so, I'd prefer we make it an option rather than remove it entirely.

>> The second part of the patch that sets container=lxc is of course not
>> controversial, that should definitely go into 0.9.
>>
>> -- Christian
>>
>> PS: I still have a small "fix" for lxc-shutdown in the pipeline that
>> I'll try to send before Sunday.
>>


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20130328/ec2743f1/attachment.pgp>


More information about the lxc-devel mailing list