[lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

[Serge Hallyn]

Quoting Christian Seiler (christian at iwakd.de):
> Hi there,
> 
> >>In light of the fact that 0.9 is going to be here soon, any
> >>comments on
> >>this?
> >
> >Sorry, I was waiting to see if anyone else would comment.  Note this
> >kind of change is not going to be non-trivial, so it's definately
> >(imo)
> >1.0 material
> 
> My problem is that the current patch in staging that clears the
> environment breaks a lot of things that I'm currently doing with lxc
> and I'd really hate to need to manually patch 0.9, especially since we
> now have situation where everything I want to do with LXC can be done
> with vanilla kernel 3.8 and vanilla LXC 0.9~rc1.
> 
> Since lxc-attach has been there since quite a while and people may have
> been using it (especially since kernel 3.8), could we perhaps revert
> the patch that clears the environment in attach for 0.9 and implement
> it properly in 1.0? (And perhaps backport that part to 0.9.1) I know
> that dragging in the complete environment has its own problems, but at
> least for me it currently breaks more than it fixes.
> 
> Thoughts?

It seems reasonable to me.  Stéphane, ok with you?

> The second part of the patch that sets container=lxc is of course not
> controversial, that should definitely go into 0.9.
> 
> -- Christian
> 
> PS: I still have a small "fix" for lxc-shutdown in the pipeline that
> I'll try to send before Sunday.
>