[lxc-devel] 0.9.x versions before 1.0

[Stéphane Graber]

On Wed, Jul 10, 2013 at 09:28:52PM -0500, Serge Hallyn wrote:
> Quoting Qiang Huang (h.huangqiang at huawei.com):
> > On 2013/7/10 22:30, Serge Hallyn wrote:
> > > Quoting Qiang Huang (h.huangqiang at huawei.com):
> > >> On 2013/7/10 6:05, Dwight Engen wrote:
> > >>> Hi guys,
> > >>>
> > >>> Just curious, has there been any thought about doing any more lxc versions
> > >>> 0.9.x before lxc 1.0? Seems like a few things have accumulated since 0.9.0.
> > >>> Just pulled this out of git for perspective:
> > >>>
> > >>> Name     Commits  Diffstat
> > >>> 0.7.0    140      84 files changed, 4952 insertions(+), 2957 deletions(-)
> > >>> 0.7.1    7        7 files changed, 62 insertions(+), 15 deletions(-)
> > >>> 0.7.2    29       23 files changed, 532 insertions(+), 90 deletions(-)
> > >>> 0.7.3    23       17 files changed, 493 insertions(+), 162 deletions(-)
> > >>> 0.7.4    46       32 files changed, 1800 insertions(+), 526 deletions(-)
> > >>> 0.7.5    55       47 files changed, 1764 insertions(+), 1436 deletions(-)
> > >>> 0.8.0    223      97 files changed, 5994 insertions(+), 1300 deletions(-)
> > >>> 0.9.0    366      200 files changed, 17683 insertions(+), 3726 deletions(-)
> > >>> HEAD     194      136 files changed, 10540 insertions(+), 3319 deletions(-)
> > >>>
> > >>
> > >> Hi,
> > >>
> > >> I found we tried to change some script to c file, such like lxc-create, but
> > >> it is not accomplished yet, we can't create a container without -t option,
> > > 
> > > You misunderstood.  We are not getting rid of the templates.  We
> > > replaced the lxc-create script with an lxc_create.c program using the
> > > lxccontainer.c API.
> > 
> > Yes, I understand this.
> > 
> > > 
> > > The lxc_create.c and the api do the actual basic container config
> > > creation and creation of the container rootfs.
> > 
> > So lxc_create.c is planing to replace lxc_create.in, we'll delete
> > lxc_create.in in the future, right?
> > 
> > > 
> > > The templates are simply scripts which fill in the rootfs.  Those
> > > *should* remain separate.  In fact we probably should be hosting a
> > > repository of customized templates.  (That gets a bit touchy - there
> > > are other projects doing the work of creating 'cloud images', and I
> > > don't care to duplicate their work.)
> > > 
> > >> are we going to finish it before lxc 1.0? Because it seems like a bug.
> > > 
> > > Why?
> > 
> > # lxc-create -n test -f config
> > Segmentation fault
> > 
> > This used to work.
> > I looked through the code, it didn't handle the situation without -t option.
> > Is this exactly what you want?
> 
> Oh - lol - yeah maybe we should fix that :)  Thanks for pointing that
> out.  There's another thing missing, now that you mention it - if
> the template is passed in as a path, we should allow that (without
> prepending "lxc-" to it).
> 
> -serge

To add to the "you broke my lxc-create" list, the new version also
dropped the fancy header I introduced a while back (showing the template
name, the arguments passed to it and the checksum of the template used
at the time.

An example was:
# Template used to create this container: ubuntu
# Parameters passed to the template: -a amd64 -r precise
# Template script checksum (SHA-1): b1f15036868c53cca0698f1efcadd88dfefaee9b

-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20130710/9ea8fd2c/attachment.pgp>