[lxc-devel] [PATCH] conf.c: Cast st_uid and st_gid to int

Serge Hallyn serge.hallyn at canonical.com
Tue Jan 15 17:56:00 UTC 2013


Quoting Stéphane Graber (stgraber at ubuntu.com):
> In eglibc st_uid and st_gid are defined as unsigned integers, in bionic those
> are defined as unsigned long (which is inconsistent with the kernel's
> defintion that's uint_32).
> 
> To workaround this problem, simply cast those two to int.
> 
> Signed-off-by: Stéphane Graber <stgraber at ubuntu.com>

Thanks.

Acked-by: Serge Hallyn <serge.hallyn at ubuntu.com>

> ---
>  src/lxc/conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lxc/conf.c b/src/lxc/conf.c
> index 4eb3eeb..65cc2dc 100644
> --- a/src/lxc/conf.c
> +++ b/src/lxc/conf.c
> @@ -2617,7 +2617,7 @@ static int uid_shift_file(char *path, struct lxc_conf *c)
>  	newuid = shiftid(c, statbuf.st_uid, ID_TYPE_UID);
>  	newgid = shiftid(c, statbuf.st_gid, ID_TYPE_GID);
>  	if (newuid != statbuf.st_uid || newgid != statbuf.st_gid) {
> -		DEBUG("chowning %s from %d:%d to %d:%d\n", path, statbuf.st_uid, statbuf.st_gid, newuid, newgid);
> +		DEBUG("chowning %s from %d:%d to %d:%d\n", path, (int)statbuf.st_uid, (int)statbuf.st_gid, newuid, newgid);
>  		if (chown(path, newuid, newgid)) {
>  			SYSERROR("chown(%s)", path);
>  			return -1;
> -- 
> 1.8.0
> 
> 
> ------------------------------------------------------------------------------
> Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS
> and more. Get SQL Server skills now (including 2012) with LearnDevNow -
> 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
> SALE $99.99 this month only - learn more at:
> http://p.sf.net/sfu/learnmore_122512
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel




More information about the lxc-devel mailing list