[lxc-devel] Alpha3 is getting close

Serge Hallyn serge.hallyn at canonical.com
Wed Feb 6 17:55:13 UTC 2013


Quoting Dwight Engen (dwight.engen at oracle.com):
> Hi Serge, thanks for doing this, it will be nice to have this run time
> configurable! A couple of comments:

Note there are some more fundamental problems I'm ironing out right
now, but I'll address these too, thanks much.

> - Is $datadir/lxc what you're looking for for lxc.functions? I think
>   thats how templates make it into /usr/share/lxc/templates

Sounds good, thanks.

> - It looks like the uses of snprintf(offset, len, abstractname(), name)
>   are leaky since abstractname() returns a malloc'ed pointer

Yeah - it'll only leak the one, but I'll change it over to not leak at
all.

> - Is there a reason why we don't make lxcapi_get_config_path() return
>   c->config_path but as const? lxcapi_state() returns a const char *,
>   but lxcapi_config_file_name() is strdup'ed non const. IMHO making
>   the api return const char * is cleaner.

Agreed.

> - In default_lxc_path() I don't think its safe to fclose(fin) when it
>   wasn't opened.

Good point :)

thanks,
-serge




More information about the lxc-devel mailing list