[lxc-devel] [PATCH] goto correct cleanup label to ensure fd is closed

[Serge Hallyn]

Quoting Dwight Engen (dwight.engen at oracle.com):
> Signed-off-by: Dwight Engen <dwight.engen at oracle.com>

Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

> ---
>  src/lxc/start.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lxc/start.c b/src/lxc/start.c
> index aefccd6..0a0cc40 100644
> --- a/src/lxc/start.c
> +++ b/src/lxc/start.c
> @@ -434,10 +434,10 @@ struct lxc_handler *lxc_init(const char *name, struct lxc_conf *conf, const char
>  		goto out_close_maincmd_fd;
>  	}
>  
> -	/* Begin the set the state to STARTING*/
> +	/* Begin by setting the state to STARTING */
>  	if (lxc_set_state(name, handler, STARTING)) {
>  		ERROR("failed to set state '%s'", lxc_state2str(STARTING));
> -		goto out_free_name;
> +		goto out_close_maincmd_fd;
>  	}
>  
>  	/* Start of environment variable setup for hooks */
> -- 
> 1.8.1.4
> 
> 
> ------------------------------------------------------------------------------
> Precog is a next-generation analytics platform capable of advanced
> analytics on semi-structured data. The platform includes APIs for building
> apps and a phenomenal toolset for data science. Developers can use
> our toolset for easy data analysis & visualization. Get a free account!
> http://www2.precog.com/precogplatform/slashdotnewsletter
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel