[lxc-devel] lxc-unshare default behavior

Stéphane Graber stgraber at ubuntu.com
Mon Jun 11 16:47:14 UTC 2012


On 06/11/2012 11:38 AM, Serge Hallyn wrote:
> Hi,
> 
> lxc-unshare currently is broken if you don't provide a command to run.  The
> fix is trivial, but which default behavior do we prefer:  always require
> a command, or do we pick something ("/bin/sh"?) to run if no command is
> provided?  I prefer to require a command, but history suggests that I can
> therefore assume most people will lean the other way :)
> 
> The usage message currently says:
> 
> if -s PID is specified, <command> is mandatory
> 
> I propose removing that, and printing an error if (argv[optind]==NULL)
> before
> 
>     args = &argv[optind];
> 
> Objections?
> 
> -serge

Sounds good to me. +1


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20120611/5ff90a34/attachment.pgp>


More information about the lxc-devel mailing list