[lxc-devel] lxc-unshare default behavior

Serge Hallyn serge.hallyn at canonical.com
Mon Jun 11 15:38:03 UTC 2012


Hi,

lxc-unshare currently is broken if you don't provide a command to run.  The
fix is trivial, but which default behavior do we prefer:  always require
a command, or do we pick something ("/bin/sh"?) to run if no command is
provided?  I prefer to require a command, but history suggests that I can
therefore assume most people will lean the other way :)

The usage message currently says:

if -s PID is specified, <command> is mandatory

I propose removing that, and printing an error if (argv[optind]==NULL)
before

    args = &argv[optind];

Objections?

-serge




More information about the lxc-devel mailing list