[lxc-devel] [PATCH] assume LXCPATH took on default localstatedir based value in configure

[Dwight Engen]

On Thu, 06 Dec 2012 13:10:09 -0500
"Michael H. Warfield" <mhw at WittsEnd.com> wrote:

> On Thu, 2012-12-06 at 12:46 -0500, Dwight Engen wrote:
> > On Thu, 06 Dec 2012 12:30:18 -0500
> > "Michael H. Warfield" <mhw at WittsEnd.com> wrote:
> 
> <Snip>
> 
> > Yeah, the duplicates are just warnings, but we probably should fix
> > it by listing the files individually instead of using the glob.
> > 
> > > > Also got a /usr/local/var/lib/lxc in there at line 100 that's
> > > > "@LXCPATH@".  That doesn't look right.  Shouldn't that have
> > > > ended up /var/lib/lxc without the "/usr/local" part?  Shouldn't
> > > > that be using the rpm macros there too?
> 
> > When you run ./configure, you have to pass the same options rpmbuild
> > will to make sure LXCPATH gets expanded right.
> 
> Yeah, problem is that it's blowing in the rpmbuild.  So something
> isn't getting passed right in the spec file.
> 
> Looks like that line in the spec file should have been this...
> 
> %{_localstatedir}/lib/lxc
> 
> Instead of this (like I set it)...
> 
> /var/lib/lxc
> 
> And certainly not this...
> 
> /usr/local/var/lib/lxc
> 
> Not sure where the breakage was but I'm guess the line in lxc.spec.in
> at line 65 is the culprit...

I think this is pretty much what you're suggesting (correct based
on current options passed by spec to configure):

--

Signed-off-by: Dwight Engen <dwight.engen at oracle.com>
---
 lxc.spec.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lxc.spec.in b/lxc.spec.in
index 51997b5..c7470b8 100644
--- a/lxc.spec.in
+++ b/lxc.spec.in
@@ -97,8 +97,7 @@ rm -rf %{buildroot}
 %defattr(-,root,root)
 %{_libdir}/*.so.*
 %{_libdir}/%{name}
- at LXCPATH@
-%{_localstatedir}/cache/lxc
+%{_localstatedir}/*
 %attr(4555,root,root) %{_libexecdir}/%{name}/lxc-init
 
 %files devel
-- 
1.7.11.7