[lxc-devel] lxc-simple: porcelain over lxc commands

[Daniel Lezcano]

On 04/07/2011 12:29 AM, Nigel McNie wrote:
> On 6 April 2011 23:01, Daniel Lezcano<daniel.lezcano at free.fr>  wrote:
>
>> On 04/03/2011 11:14 AM, Nigel McNie wrote:
>>
>>> Hi List,
>>>
>>> <snip>
>>
>> Nigel,
>>
>> Thanks a lot, that's a great work and it is exactly what I was hoping
>> someone will do.
>> I will be happy to take upstream these new commands.
>>
>> A mindless remark, I would prefer to rename the "lxc restart" to "lxc
>> reboot" to not collide with the checkpoint/restart when it will be
>> implemented.
>>
>> I suspect some modifications will be necessary to polish the code but it
>> does no matter as we can take it upstream and do the polishing work after
>> this merge.
>>
>> It will be necessary to check the dependencies with "configure" and be able
>> to disable the porcelain commands for the embedded systems, but it is not a
>> big deal at all.
>>
>> Thanks
>>   -- Daniel
>>
> Hi Daniel,
>
> Great!
>
> If we are to rename the command 'reboot', then it may confuse people who are
> expecting start/stop/restart from daemons etc - maybe we could rename
> start/stop to be boot/halt as well then?

For the low levels command, boot/halt/reboot do not make sense as we can 
launch an application but for a higher level component doing system 
containers (VPS), that would make sense.  As far as I understood, this 
is the case for the lxc porcelain commands, right ?

>   Or, although I don't know anything
> about the checkpointing stuff, maybe those commands could be
> checkpoint/restore?

Mmh, usually it is checkpoint/restart or dump/restore. The 
lxc-checkpoint and lxc-restart commands already exist. They are empty 
command but defined for the API so the kernel developer can hack and use 
these commands.

> I'm happy to keep contributing to the code and its maintenance once it's
> merged in, but you're probably the best person to do the merge. I know very
> little about how lxc works, having only worked with the debian&  ubuntu
> packaging. I haven't even checked out the git repo before now. Let me know
> if there's anything I can do to assist though.

Yes, please:

  * submit your porcelain command as a patch (cf CONTRIBUTING) on top of 
the lxc head git repo.
  * update the MAINTAINERS file adding a porcelain section where you add 
your name, so people will Cc you when contributing to your commands

Submitting as a patch will help us to review and comment. For me it will 
be easier to apply, test and play with it.
It is a big piece, so I assume some round trips will be needed before 
merging but I will be happy to merge it as soon it will be ready.

Thanks a lot for this contribution

  -- Daniel

ps : sorry for the delay, I was out for a week.