[lxc-devel] [GIT] lxc branch, master, updated. 25368b5249509aa21167b7ea4193e281f0091f55

Mon May 10 12:04:53 UTC 2010

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lxc".

The branch, master has been updated
       via  25368b5249509aa21167b7ea4193e281f0091f55 (commit)
       via  bf6cc73696e485c40494bf5269f374f5a56316e7 (commit)
       via  8208b295ab1589bdfec00193fb4e6534743edff5 (commit)
       via  10e657e5e802c260f97716171e39e0e014f59a65 (commit)
       via  2f462f4b9bc89958c53741239a6c6955f4f34120 (commit)
       via  0b7a8353353e284c474be04976e0a015cfd618d2 (commit)
       via  1b09f2c057205db6f31caa76c3605eb0dc7eec86 (commit)
       via  5c2940600e301a62dbf8fac3ed00f466003bdadb (commit)
      from  82d89dce377300f774afc9163778bfeb247bcc57 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 25368b5249509aa21167b7ea4193e281f0091f55
Author: Ferenc Wagner <wferi at niif.hu>
Date:   Mon May 10 11:50:10 2010 +0200

    no need to use a temporary directory for pivoting

    Ferenc Wagner <wferi at niif.hu> writes:

    > Daniel Lezcano <dlezcano at fr.ibm.com> writes:
    >
    >> Ferenc Wagner wrote:
    >>
    >>> Daniel Lezcano <daniel.lezcano at free.fr> writes:
    >>>
    >>>> Ferenc Wagner wrote:
    >>>>
    >>>>> While playing with lxc-start, I noticed that /tmp is infested by
    >>>>> empty lxc-r* directories: [...] Ok, this name comes from lxc-rootfs
    >>>>> in conf.c:setup_rootfs.  After setup_rootfs_pivot_root returns, the
    >>>>> original /tmp is not available anymore, so rmdir(tmpname) at the
    >>>>> bottom of setup_rootfs can't achieve much.  Why is this temporary
    >>>>> name needed anyway?  Is pivoting impossible without it?
    >>>>
    >>>> That was put in place with chroot, before pivot_root, so the distro's
    >>>> scripts can remount their '/' without failing.
    >>>>
    >>>> Now we have pivot_root, I suppose we can change that to something cleaner...
    >>>
    >>> Like simply nuking it?  Shall I send a patch?
    >>
    >> Sure, if we can kill it, I will be glad to take your patch :)
    >
    > I can't see any reason why lxc-start couldn't do without that temporary
    > recursive bind mount of the original root.  If neither do you, I'll
    > patch it out and see if it still flies.

    For my purposes the patch below works fine.  I only run applications,
    though, not full systems, so wider testing is definitely needed.

    Thanks,
    Feri.

    >From 98b24c13f809f18ab8969fb4d84defe6f812b25c Mon Sep 17 00:00:00 2001
    Date: Thu, 6 May 2010 14:47:39 +0200

    That was put in place before lxc-start started using pivot_root, so
    the distro scripts can remount / without problems.

    Signed-off-by: Ferenc Wagner <wferi at niif.hu>
    Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>

commit bf6cc73696e485c40494bf5269f374f5a56316e7
Author: Daniel Lezcano <daniel.lezcano at free.fr>
Date:   Mon May 10 11:50:10 2010 +0200

    Make dynamic busybox supported

    Bind mount host library path.
    Weird but some distro provide busybox as a dynamically linked binary.

    Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>

commit 8208b295ab1589bdfec00193fb4e6534743edff5
Author: Guillaume Zitta <lxc at zitta.fr>
Date:   Mon May 10 11:50:10 2010 +0200

    make lxc-checkconfig more explicit

    With a friend, we installed lxc on his server.
    We spend 1 hour on the kernel config because we didn't knew :
    - that lxc-checkconfig is a bash script and it can check a config before
    running it
    - which kernel config item whas not good
    - that CONFIG_SECURITY_FILE_CAPABILITIES is obsolete since 2.6.33

    So, here is a patch for lxc-checkconfig that could save time for lxc newbies

    Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>
    Modified-by: Daniel Lezcano <daniel.lezcano at free.fr>
    Signed-off-by: Guillaume Zitta <lxc at zitta.fr>

commit 10e657e5e802c260f97716171e39e0e014f59a65
Author: Daniel Lezcano <daniel.lezcano at free.fr>
Date:   Mon May 10 11:50:10 2010 +0200

    add missing /dev/pts directory

    Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>

commit 2f462f4b9bc89958c53741239a6c6955f4f34120
Author: Daniel Lezcano <daniel.lezcano at free.fr>
Date:   Mon May 10 11:50:09 2010 +0200

    update INSTALL file

    "lxc configure does not exist. You need to run ./autogen.sh to create it.
    I think it needs to either be documented in INSTALL or you provide ./configure"

    Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>
    Reported-by: Jamal Hadi Salim <hadi at cyberus.ca>

commit 0b7a8353353e284c474be04976e0a015cfd618d2
Author: Daniel LEzcano <daniel.lezcano at free.fr>
Date:   Mon May 10 11:50:09 2010 +0200

    factor out pivot_root code

    Clean up and factor a bit the pivot_root code.

    Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>

commit 1b09f2c057205db6f31caa76c3605eb0dc7eec86
Author: Daniel Lezcano <daniel.lezcano at free.fr>
Date:   Mon May 10 11:50:09 2010 +0200

    fix pivot_root temporary directory

    First of all, when trying to start a container in a read-only root
    lxc-start complains:
      lxc-start: Read-only file system - can't make temporary mountpoint

    This is in conf.c:setup_rootfs_pivot_root() function.  That function
    uses optional parameter "lxc.pivotdir", or creates (and later removes)
    a temporary directory for pivot_root.  Obviously there's no way to
    create a directory in a read-only filesystem.

    But lxc.pivotdir does not work either. In the function mentioned above
    it is used with leading dot (eg. if I specify "lxc.pivotdir=pivot" in
    the config file the pivot_root() syscall will be made to ".pivot" with
    leading dot, not to "pivot"), but later on it is used without that dot,
    and fails:

      lxc-start: No such file or directory - failed to open /pivot/proc/mounts
      lxc-start: No such file or directory - failed to read or parse mount list '/pivot/proc/mounts'
      lxc-start: failed to pivot_root to '/stage/t'

    (that's with "lxc.pivotdir = pivot" in the config file).  After symlinking
    pivot to .pivot it still fails:

      lxc-start: Device or resource busy - could not unmount old rootfs
      lxc-start: failed to pivot_root to '/stage/t'

    Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>
    Reported-by: Michael Tokarev <mjt at tls.msk.ru>

commit 5c2940600e301a62dbf8fac3ed00f466003bdadb
Author: Daniel Lezcano <daniel.lezcano at free.fr>
Date:   Mon May 10 11:50:09 2010 +0200

    Fix console infinite loop

    When the client console exits, the mainloop goes in an infinite loop
    as the handler is not removed and we are notified from the disconnection
    indefinitely.

    Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>

-----------------------------------------------------------------------

Summary of changes:
 INSTALL                    |    5 +++
 scripts/lxc-busybox.in     |   37 +++++++++++++-----------
 src/lxc/conf.c             |   66 +++++++++++++++----------------------------
 src/lxc/console.c          |    7 ++++
 src/lxc/lxc-checkconfig.in |   21 ++++++++++---
 src/lxc/utils.c            |   28 ++++++++++++++++++
 src/lxc/utils.h            |    1 +
 7 files changed, 100 insertions(+), 65 deletions(-)

hooks/post-receive
-- 
lxc