[lxc-devel] [patch 3/3][RFC] implement lxc-cmd and lxc-enter using lxc_cinit daemon
Dietmar Maurer
dietmar at proxmox.com
Mon Jan 25 09:12:57 UTC 2010
> I was wondering if we shouldn't separate the "init-logger" features.
>
> For logging the container output, we can create a tty in lxc-start.c,
> map the slave endpoint to /dev/console and proxy the master to the real
> tty.
> That allows to:
> * solve the problem of the init process which stole the terminal tty,
> letting us in a terminal without the controling tty
> * we can redirect the master to file, a socket, a fifo, etc ...
> * we reuse most of the lxc-console code
>
> In this case, the "init-logger" becomes a
> "<process-allowing-to-enter-the container>" and we keep separated the
> feature.
>
> What do you think ?
Well, I always want both features:
- to be able to see the output of init is a must
- executing command inside the container (halt) is very convenient,
and a must for system containers.
So I am not sure if you gain anything from this code split.
In short, I think it makes no sense if you also implement
the "<process-allowing-to-enter-the container> feature, because
you can share most code there.
- Dietmar
More information about the lxc-devel
mailing list