[cgmanager-devel] cgmanager fails if controller is not enabled

Serge Hallyn serge.hallyn at ubuntu.com
Mon Oct 13 07:43:33 UTC 2014


Quoting Marcin Szewczyk (cgmanager at wodny.org):
> On Sun, Oct 12, 2014 at 08:37:26PM +0000, Serge Hallyn wrote:
> > So now I wonder whether
> > "do_move_pid_main: don't break out of while loop on error; return error after"
> > should be reverted, or whether it still makes sense.
> 
> In Debian bug report 757348 it is described as an "additional fixup". I
> think it gives additional flexibility and implements "do as much as we
> can" way. As I see it, currently neither logind, nor cgmanager work in a
> transactional way where e.g. we would fail to login unless all
> Create/MovePid succeed. So I think both changes could be beneficial.

That patch did two things.  The switch to continuing through the rest
of the subsystems if we get an error other than EPERM probably should
be kept.  Where I'm not sure on best behavior is what to actually
return from the call - return the first error we ever get, return 0
so long as anything was actually created, something else.  The "best"
behavior could be to have a new dbus method that returns an array of
errnos, one per subsystem, but realistically I don't think callers would
want to deal with that anyway.

I guess we'll keep it as is for now.

thanks,
-serge


More information about the cgmanager-devel mailing list