[Lxc-users] htop patch for cgroup support

[Guillaume]

Le 27/10/2010 18:01, Daniel Lezcano a écrit :
>
> On 10/27/2010 05:49 PM, zitta.fr wrote:
>>
>> Le 27/10/2010 16:20, Daniel Lezcano a écrit :
>>   
>>> On 05/10/2010 05:05 PM, lxc at zitta.fr wrote:
>>>     
>>>> Hi,
>>>>
>>>> I've submitted a patch for htop that provide cgroup support.
>>>>
>>>> The patch :
>>>> http://sourceforge.net/tracker/?func=detail&aid=2999408&group_id=108839&atid=651635
>>>>
>>>>
>>>>
>>>> Please be advised that I'm a sysadmin not a C coder.
>>>> So, until htop's authors review my patch, it should be considered as
>>>> highly experimental.
>>>>
>>>> To gentoo's users :
>>>> I added a patched ebuild in lxc-provider's overlay :
>>>>
>>>> edit /etc/layman/layman.cfg
>>>> add http://lxc-provider.sourceforge.net/gentoo-overlay.xml to
>>>> overlays list
>>>> # layman -L
>>>> # layman -a lxc-provider
>>>> # USE="cgroup" emerge htop
>>>>
>>>> Note that this overlay also contains :
>>>> - an ebuild for the git version of lxc
>>>> - ebuilds for lxc-provider
>>>> (http://sourceforge.net/apps/trac/lxc-provider/)
>>>>
>>>>        
>>> Jumping a bit late in the thread :)
>>>
>>> Hi Guillaume,
>>>
>>> that's a very good idea and I think it is really worth to add this
>>> support.
>>>
>>> Did you had some feedbacks for your patch ? is it merged ?
>>>
>>> Thanks
>>>    -- Daniel
>>>      
>> No feedback from htop :-(
>>    
>
> Ok, thanks. It is time to shake the coconut palm :)
>
> I will switch to the htop mailing list and ask for inclusion of your
> patch.
>
>   -- Daniel

Like I said when I posted this patch : "I'm a C newbie: So, before
htop's author review, be careful."

You should review my code before...
I don't want you to take a coconut on your head :)

Guillaume