[Lxc-users] lxc-start leaves temporary pivot dir behind

[Ferenc Wagner]

Daniel Lezcano <dlezcano at fr.ibm.com> writes:

> Ferenc Wagner wrote:
>
>> Daniel Lezcano <daniel.lezcano at free.fr> writes:
>>
>>> Ferenc Wagner wrote:
>>>
>>>> While playing with lxc-start, I noticed that /tmp is infested by
>>>> empty lxc-r* directories: [...] Ok, this name comes from lxc-rootfs
>>>> in conf.c:setup_rootfs.  After setup_rootfs_pivot_root returns, the
>>>> original /tmp is not available anymore, so rmdir(tmpname) at the
>>>> bottom of setup_rootfs can't achieve much.  Why is this temporary
>>>> name needed anyway?  Is pivoting impossible without it?
>>>
>>> That was put in place with chroot, before pivot_root, so the distro's
>>> scripts can remount their '/' without failing.
>>>
>>> Now we have pivot_root, I suppose we can change that to something cleaner...
>>
>> Like simply nuking it?  Shall I send a patch?
>
> Sure, if we can kill it, I will be glad to take your patch :)

I can't see any reason why lxc-start couldn't do without that temporary
recursive bind mount of the original root.  If neither do you, I'll
patch it out and see if it still flies.
-- 
Thanks,
Feri.