[lxc-devel] [lxc/lxc] 1ed59e: conf: fix a memory leak

[Christian Brauner]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1ed59e6d8d27db32d9cb73f64e17a508fff6cba0
      https://github.com/lxc/lxc/commit/1ed59e6d8d27db32d9cb73f64e17a508fff6cba0
  Author: Evgeny Vereshchagin <evvers at ya.ru>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: fix a memory leak

It was triggered by passing "lxc.selinux.context.keyring=xroot" to the
fuzz target introduced in https://github.com/google/oss-fuzz/pull/5498
```
=================================================================
==22==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 6 byte(s) in 1 object(s) allocated from:
    #0 0x538ca4 in __strdup /src/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:468:3
    #1 0x5c40e8 in set_config_string_item /src/lxc/src/lxc/confile_utils.c:635:14
    #2 0x44394e in set_config_selinux_context_keyring /src/lxc/src/lxc/confile.c:1596:9
    #3 0x5af955 in parse_line /src/lxc/src/lxc/confile.c:2953:9
    #4 0x4475cd in lxc_file_for_each_line_mmap /src/lxc/src/lxc/parse.c:125:9
    #5 0x5af24f in lxc_config_read /src/lxc/src/lxc/confile.c:3024:9
    #6 0x580b04 in LLVMFuzzerTestOneInput /src/fuzz-lxc-config-read.c:36:2
    #7 0x483643 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:599:15
    #8 0x46d4a2 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:323:6
    #9 0x4732ea in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:856:9
    #10 0x49f022 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
    #11 0x7f16d09b883f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2083f)
```

This is a follow-up to https://github.com/lxc/lxc/commit/4fef78bc332a2d186dca6f

Signed-off-by: Evgeny Vereshchagin <evvers at ya.ru>


  Commit: 854e6c5c01308fddc8dbdb3b88e7af319d2cdc9a
      https://github.com/lxc/lxc/commit/854e6c5c01308fddc8dbdb3b88e7af319d2cdc9a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-03-25 (Thu, 25 Mar 2021)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  Merge pull request #3725 from evverx/se_keyring_context_memory_leak

conf: fix a memory leak


Compare: https://github.com/lxc/lxc/compare/3c9c460953e8...854e6c5c0130