[lxc-devel] [lxc/lxc] 5b514c: attach: coding style fixes

[Stéphane Graber]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 5b514ce32b9b577fab1c6e452f7faa116ec4f98f
      https://github.com/lxc/lxc/commit/5b514ce32b9b577fab1c6e452f7faa116ec4f98f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: coding style fixes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6f9fe5d02cc5e47f5ac272b1707f3382ffced0d2
      https://github.com/lxc/lxc/commit/6f9fe5d02cc5e47f5ac272b1707f3382ffced0d2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: order variables correctly

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0e304baae8ac30a19775bb6c6bcdfe624e4535a9
      https://github.com/lxc/lxc/commit/0e304baae8ac30a19775bb6c6bcdfe624e4535a9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/attach.h

  Log Message:
  -----------
  attach: move lxc_proc_context_info to file local scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ab919e5fb7307e225fe90a0d80bd2186b152779b
      https://github.com/lxc/lxc/commit/ab919e5fb7307e225fe90a0d80bd2186b152779b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: s/lxc_proc_context_info/attach_context/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: dd53c8af7ff087e86fb338542f7d580e29e22582
      https://github.com/lxc/lxc/commit/dd53c8af7ff087e86fb338542f7d580e29e22582
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: rename attach_context helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 89b7bfe3ff1d8fc084f9ebff0736b6ac4b691391
      https://github.com/lxc/lxc/commit/89b7bfe3ff1d8fc084f9ebff0736b6ac4b691391
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: s/calloc/zalloc/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9745eb8aeac7c8e399b2f02f935ce74c97f7d2b5
      https://github.com/lxc/lxc/commit/9745eb8aeac7c8e399b2f02f935ce74c97f7d2b5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: split attach_context into allocation and initialization

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 500ed8139539ae8880d4e6c77f8c6213239f206b
      https://github.com/lxc/lxc/commit/500ed8139539ae8880d4e6c77f8c6213239f206b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: move lxc_cmd_get_init_pid() int get_attach_context()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d92c8e40d1b5aab2d11dff9733af07970c6152a0
      https://github.com/lxc/lxc/commit/d92c8e40d1b5aab2d11dff9733af07970c6152a0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: move get_personality() into get_attach_context()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 1874ef74680260d369d59d8382ae719fe77743d8
      https://github.com/lxc/lxc/commit/1874ef74680260d369d59d8382ae719fe77743d8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: move config init into get_attach_context()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b7873c951e5c5d856311f933942f3245adb99a11
      https://github.com/lxc/lxc/commit/b7873c951e5c5d856311f933942f3245adb99a11
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: add get_attach_context_nsfds()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7e995801f825cae79c84f1b62ea59b23ed062ab7
      https://github.com/lxc/lxc/commit/7e995801f825cae79c84f1b62ea59b23ed062ab7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: s/lxc_proc_close_ns_fd/close_nsfds/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 677e1d27690bc76baba43c01e4878567c8762ad0
      https://github.com/lxc/lxc/commit/677e1d27690bc76baba43c01e4878567c8762ad0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: s/lxc_attach_drop_privs/drop_capabilities/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 4eb19ac075ff1fae75ce66bc440b19b0697740e5
      https://github.com/lxc/lxc/commit/4eb19ac075ff1fae75ce66bc440b19b0697740e5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/lsm/lsm.c
    M src/lxc/lsm/lsm.h
    M src/lxc/start.c
    M src/tests/attach.c

  Log Message:
  -----------
  lsm: s/lsm_init/lsm_init_static/g

Make it clear that there is nothing to free here.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ee142207d48bd1d71cd0fb5722b078206c53389e
      https://github.com/lxc/lxc/commit/ee142207d48bd1d71cd0fb5722b078206c53389e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/attach_options.h
    M src/lxc/confile.c
    M src/lxc/confile.h

  Log Message:
  -----------
  attach: fix personality handling

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 53bca1f3c06e00b5ca74334b6475f41888256741
      https://github.com/lxc/lxc/commit/53bca1f3c06e00b5ca74334b6475f41888256741
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: remove obsolete namespace check

We're not going to support kernel without namespaces anyway.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a588a482d903f3214ba5a7ad23757a20205b6b44
      https://github.com/lxc/lxc/commit/a588a482d903f3214ba5a7ad23757a20205b6b44
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: move getcwd() into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6d6bfd4f6ca7469f764a0568ad545c2515ef6124
      https://github.com/lxc/lxc/commit/6d6bfd4f6ca7469f764a0568ad545c2515ef6124
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M configure.ac

  Log Message:
  -----------
  configure: fix static builds with clang-12 and LTO

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: cb2420df26446caa4ad4755fb3fdf579004a3241
      https://github.com/lxc/lxc/commit/cb2420df26446caa4ad4755fb3fdf579004a3241
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: s/close/close_prot_errno_disarm/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a64902abe36e160f6889a14ce9c156ed491bc9c1
      https://github.com/lxc/lxc/commit/a64902abe36e160f6889a14ce9c156ed491bc9c1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: move attach_clone_payload into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 338b230f4e59855b249e54663d6317005423a8f9
      https://github.com/lxc/lxc/commit/338b230f4e59855b249e54663d6317005423a8f9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: rename attach_clone_payload to attach_payload

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 74ce42b5b5f9a0b914bec1543b77ce10ebef44fa
      https://github.com/lxc/lxc/commit/74ce42b5b5f9a0b914bec1543b77ce10ebef44fa
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: coding style fixes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2689133604b9918e8a5e0e64edbb4034c288fc98
      https://github.com/lxc/lxc/commit/2689133604b9918e8a5e0e64edbb4034c288fc98
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/sync.c
    M src/lxc/sync.h

  Log Message:
  -----------
  sync: export sync_wait() and sync_wake()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 946a0c6d61c00a232aaadd7418ad82eead104a09
      https://github.com/lxc/lxc/commit/946a0c6d61c00a232aaadd7418ad82eead104a09
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/start.c
    M src/lxc/sync.c
    M src/lxc/sync.h

  Log Message:
  -----------
  sync: rename startup synchronization macros

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a9f0cecfc5f20079d6146deefd0ff380f61c6bd0
      https://github.com/lxc/lxc/commit/a9f0cecfc5f20079d6146deefd0ff380f61c6bd0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/sync.h

  Log Message:
  -----------
  attach: use sync_wait()/sync_wake() where applicable

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2b695e5fb2ea9c7fa1dfbf9b6bee581b252e07e5
      https://github.com/lxc/lxc/commit/2b695e5fb2ea9c7fa1dfbf9b6bee581b252e07e5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: introduce sync_wait_pid() and sync_wake_pid()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6e48e7c58ec338bd46327d7beb9d45436448ab43
      https://github.com/lxc/lxc/commit/6e48e7c58ec338bd46327d7beb9d45436448ab43
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/start.c
    M src/lxc/sync.c
    M src/lxc/sync.h

  Log Message:
  -----------
  sync: make all sync helpers return bool

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 6e36c29770ee460590279ab0bf66a3416ed0f6b7
      https://github.com/lxc/lxc/commit/6e36c29770ee460590279ab0bf66a3416ed0f6b7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: introduce sync_wait_fd() and sync_wake_fd()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: f8e88e94201861ed4c08adb4f59873898ebf4a95
      https://github.com/lxc/lxc/commit/f8e88e94201861ed4c08adb4f59873898ebf4a95
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/sync.h

  Log Message:
  -----------
  attach: use dummy macros to make it easier to follow sync logic

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 26abd7eacac6d203ae9721e2bf825a3a50b844c8
      https://github.com/lxc/lxc/commit/26abd7eacac6d203ae9721e2bf825a3a50b844c8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: move new_cwd into tighter scope

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 5d2b46fbb8f1bca6cbaa68f2e1b56f7e84b0f6fd
      https://github.com/lxc/lxc/commit/5d2b46fbb8f1bca6cbaa68f2e1b56f7e84b0f6fd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: use STDIN_FILENO instead of hard-coding 0

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3a24f14edfae62082caf72bd1e2b14701201e52d
      https://github.com/lxc/lxc/commit/3a24f14edfae62082caf72bd1e2b14701201e52d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: remove unneeded assignment

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 39b3b69b21510bf2f297e6ba7038cc3671ff7e78
      https://github.com/lxc/lxc/commit/39b3b69b21510bf2f297e6ba7038cc3671ff7e78
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: rework attaching to namespace fds

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c538837d045c32c82aa2736a2f934787dd7d1281
      https://github.com/lxc/lxc/commit/c538837d045c32c82aa2736a2f934787dd7d1281
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/macro.h

  Log Message:
  -----------
  attach: move to file descriptor-only interactions

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 25c659d5000190c1d96b36a8ed935181fc99e65d
      https://github.com/lxc/lxc/commit/25c659d5000190c1d96b36a8ed935181fc99e65d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c
    M src/lxc/namespace.c
    M src/lxc/namespace.h

  Log Message:
  -----------
  attach: move to file descriptor only namespace interactions

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 581b849a74c33598b24440220dc17e5ca0e946ff
      https://github.com/lxc/lxc/commit/581b849a74c33598b24440220dc17e5ca0e946ff
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: init file descriptors to -EBADF

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0e24c5600da38f84c3d3b8d66ffe05244f15251d
      https://github.com/lxc/lxc/commit/0e24c5600da38f84c3d3b8d66ffe05244f15251d
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M configure.ac
    M src/lxc/attach.c
    M src/lxc/attach.h
    M src/lxc/attach_options.h
    M src/lxc/confile.c
    M src/lxc/confile.h
    M src/lxc/lsm/lsm.c
    M src/lxc/lsm/lsm.h
    M src/lxc/macro.h
    M src/lxc/namespace.c
    M src/lxc/namespace.h
    M src/lxc/start.c
    M src/lxc/sync.c
    M src/lxc/sync.h
    M src/tests/attach.c

  Log Message:
  -----------
  Merge pull request #3638 from brauner/2021-01-28/fixes

attach: improve attach codepaths


Compare: https://github.com/lxc/lxc/compare/0fa84a8cd2fe...0e24c5600da3