[lxc-devel] [lxc/lxc] 4f25e7: attach: invert child/parent handling

[Stéphane Graber]

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 4f25e72fb01a60dbe2d3be195582bab1fbd9707c
      https://github.com/lxc/lxc/commit/4f25e72fb01a60dbe2d3be195582bab1fbd9707c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: invert child/parent handling

This makes it more consistent with th rest of the shared library.

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e11f5b8c91ef585e5764a32498a716b9813fcf47
      https://github.com/lxc/lxc/commit/e11f5b8c91ef585e5764a32498a716b9813fcf47
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: use __do_free cleanup macro for cwd

but still yield memory immediately once we're done with it to not have it lying
around while the parent process is around.

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 4f3b6a85ed04d223ac5590e20037e9a9ae26754e
      https://github.com/lxc/lxc/commit/4f3b6a85ed04d223ac5590e20037e9a9ae26754e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: tweak logging

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ad001fb6d76361625fda40a1ae80b402734ef394
      https://github.com/lxc/lxc/commit/ad001fb6d76361625fda40a1ae80b402734ef394
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: use __do_close for labelfd

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 76783714397b18971644dcc2294ea32a2a08a3eb
      https://github.com/lxc/lxc/commit/76783714397b18971644dcc2294ea32a2a08a3eb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: coding style fixes

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7444657c87fddb97b50318ae64f5963f8eca705b
      https://github.com/lxc/lxc/commit/7444657c87fddb97b50318ae64f5963f8eca705b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: use free_disarm()

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 16d19b34eaa5e5aed383269cce85d5e0733e8904
      https://github.com/lxc/lxc/commit/16d19b34eaa5e5aed383269cce85d5e0733e8904
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: s/attach_child_main/do_attach/g

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 737a8d85150be1ebc51356fd6e81dfc955a9b708
      https://github.com/lxc/lxc/commit/737a8d85150be1ebc51356fd6e81dfc955a9b708
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: mark do_attach() as __noreturn

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: dab02267f01e4201c1a38600516ae0bd6baf620d
      https://github.com/lxc/lxc/commit/dab02267f01e4201c1a38600516ae0bd6baf620d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: make do_attach() void

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 578d4b6202a667c6b88cb065eb721695176adb83
      https://github.com/lxc/lxc/commit/578d4b6202a667c6b88cb065eb721695176adb83
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: use close_prot_errno_disarm()

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: b495984869abb70c7a7223d143efbce9694047f2
      https://github.com/lxc/lxc/commit/b495984869abb70c7a7223d143efbce9694047f2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: add some DEBUG() logging to stdfd dpulication

Cc: stable-4.0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0fa84a8cd2fea8d1db416b36ee053a21a08cad1e
      https://github.com/lxc/lxc/commit/0fa84a8cd2fea8d1db416b36ee053a21a08cad1e
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  Merge pull request #3637 from brauner/2021-01-27/fixes

attach: fixes


Compare: https://github.com/lxc/lxc/compare/665fcdf9031e...0fa84a8cd2fe