[lxc-devel] [lxc/lxc] 7a12ba: attach: coding style fixes
Christian Brauner
noreply at github.com
Fri Feb 26 21:04:22 UTC 2021
Branch: refs/heads/stable-4.0
Home: https://github.com/lxc/lxc
Commit: 7a12ba33b58e38312e7197bab3520e2eaf2ae7f8
https://github.com/lxc/lxc/commit/7a12ba33b58e38312e7197bab3520e2eaf2ae7f8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: coding style fixes
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a8355eaa391b104c98eec46ef68f7f6c137ac886
https://github.com/lxc/lxc/commit/a8355eaa391b104c98eec46ef68f7f6c137ac886
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: order variables correctly
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e40da39f6d1b37ec5a87145e3774746acf89c107
https://github.com/lxc/lxc/commit/e40da39f6d1b37ec5a87145e3774746acf89c107
Author: Maximilian Blenk <Maximilian.Blenk at bmw.de>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/attach_options.h
M src/lxc/tools/lxc_attach.c
Log Message:
-----------
lxc-attach: Enable setting the SELinux context
Enable lxc-attach to set the SELinux context that the user will end up
in when attaching to a container (This can be used to overwrite the
context set in the config file). If the option is not used, behavior
will be as before
Signed-off-by: Maximilian Blenk <Maximilian.Blenk at bmw.de>
Commit: e13b5ef7020a670b25224194ecfc430c80858c9c
https://github.com/lxc/lxc/commit/e13b5ef7020a670b25224194ecfc430c80858c9c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/attach_options.h
Log Message:
-----------
attach: require that LXC_ATTACH_LSM_LABEL is specified
to avoid liblxc stumbling over an smaller struct passed in from an older
liblxc. In the future we should version by size but this requires a new
attach2().
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 854260a441ae00db419783dd1d267e93e72296f5
https://github.com/lxc/lxc/commit/854260a441ae00db419783dd1d267e93e72296f5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/attach.h
Log Message:
-----------
attach: move lxc_proc_context_info to file local scope
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 747a9bd9b4eb931c4ebfb9d2665fc6d3cde7a711
https://github.com/lxc/lxc/commit/747a9bd9b4eb931c4ebfb9d2665fc6d3cde7a711
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: s/lxc_proc_context_info/attach_context/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0651c6518ccda30a9cb944d4c99b567d292d4152
https://github.com/lxc/lxc/commit/0651c6518ccda30a9cb944d4c99b567d292d4152
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: rename attach_context helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4d41e475f3b06f95cc56d3369957edcd28543326
https://github.com/lxc/lxc/commit/4d41e475f3b06f95cc56d3369957edcd28543326
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: s/calloc/zalloc/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c5566e061a8bb8488460313de12afa233128c90b
https://github.com/lxc/lxc/commit/c5566e061a8bb8488460313de12afa233128c90b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: split attach_context into allocation and initialization
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1bc41cc4a8e2d27ba064d74badbaf9100e7d28e8
https://github.com/lxc/lxc/commit/1bc41cc4a8e2d27ba064d74badbaf9100e7d28e8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: move lxc_cmd_get_init_pid() int get_attach_context()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2bb514a46f1875a80442615e620d20c6981db4af
https://github.com/lxc/lxc/commit/2bb514a46f1875a80442615e620d20c6981db4af
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: move get_personality() into get_attach_context()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0edd0756e298dad25edbda71801c19951440fc77
https://github.com/lxc/lxc/commit/0edd0756e298dad25edbda71801c19951440fc77
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: move config init into get_attach_context()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f10aba1eff84a249fa8e02a1289c69fb6906fd31
https://github.com/lxc/lxc/commit/f10aba1eff84a249fa8e02a1289c69fb6906fd31
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: add get_attach_context_nsfds()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a1200f8d91be565307ba8d75adcc308c7e709aa4
https://github.com/lxc/lxc/commit/a1200f8d91be565307ba8d75adcc308c7e709aa4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: s/lxc_proc_close_ns_fd/close_nsfds/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 65880ef342c4368b11e367bcbaf68ad4bee7847d
https://github.com/lxc/lxc/commit/65880ef342c4368b11e367bcbaf68ad4bee7847d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: s/lxc_attach_drop_privs/drop_capabilities/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 19615bfcf71cfd0ccedb7dadefb5e83915d13fa0
https://github.com/lxc/lxc/commit/19615bfcf71cfd0ccedb7dadefb5e83915d13fa0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/lsm/lsm.c
M src/lxc/lsm/lsm.h
M src/lxc/start.c
M src/tests/attach.c
Log Message:
-----------
lsm: s/lsm_init/lsm_init_static/g
Make it clear that there is nothing to free here.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a98b21a035844bed64eff8c9a0174d21179c085f
https://github.com/lxc/lxc/commit/a98b21a035844bed64eff8c9a0174d21179c085f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/attach_options.h
M src/lxc/confile.c
M src/lxc/confile.h
Log Message:
-----------
attach: fix personality handling
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c4f23cad852c3888e97d1db1b2d946636ebef9c1
https://github.com/lxc/lxc/commit/c4f23cad852c3888e97d1db1b2d946636ebef9c1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: remove obsolete namespace check
We're not going to support kernel without namespaces anyway.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c86ef3c634c2a157c44a3350a62461e797ea2205
https://github.com/lxc/lxc/commit/c86ef3c634c2a157c44a3350a62461e797ea2205
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: move getcwd() into tighter scope
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b2f90f832061750a082a3dfd6e6081a25c67d2e9
https://github.com/lxc/lxc/commit/b2f90f832061750a082a3dfd6e6081a25c67d2e9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: s/close/close_prot_errno_disarm/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 12dfb104dbd4101074c8fb4554c2a56e82653271
https://github.com/lxc/lxc/commit/12dfb104dbd4101074c8fb4554c2a56e82653271
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: move attach_clone_payload into tighter scope
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8fc976743087b983519079e3b244496bfaaf184b
https://github.com/lxc/lxc/commit/8fc976743087b983519079e3b244496bfaaf184b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: rename attach_clone_payload to attach_payload
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3bc80eeb97b14fb0313331b78fa92286cefd2aa9
https://github.com/lxc/lxc/commit/3bc80eeb97b14fb0313331b78fa92286cefd2aa9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: coding style fixes
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b63bc645bbd226468639f756d3feb8a1708a3a2e
https://github.com/lxc/lxc/commit/b63bc645bbd226468639f756d3feb8a1708a3a2e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/sync.c
M src/lxc/sync.h
Log Message:
-----------
sync: export sync_wait() and sync_wake()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c384499cdb1c66dc57ee80a3db98b5679042cce8
https://github.com/lxc/lxc/commit/c384499cdb1c66dc57ee80a3db98b5679042cce8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/start.c
M src/lxc/sync.c
M src/lxc/sync.h
Log Message:
-----------
sync: rename startup synchronization macros
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 909241f95822b3345149be73d7f6ba5c16a67492
https://github.com/lxc/lxc/commit/909241f95822b3345149be73d7f6ba5c16a67492
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/sync.h
Log Message:
-----------
attach: use sync_wait()/sync_wake() where applicable
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 025d7f8702404dade7b6cba26fae8b34766b406e
https://github.com/lxc/lxc/commit/025d7f8702404dade7b6cba26fae8b34766b406e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: introduce sync_wait_pid() and sync_wake_pid()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b41057d31d13a7b14b7475af76afd1ae0e5edd2e
https://github.com/lxc/lxc/commit/b41057d31d13a7b14b7475af76afd1ae0e5edd2e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/start.c
M src/lxc/sync.c
M src/lxc/sync.h
Log Message:
-----------
sync: make all sync helpers return bool
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 83742e7c9688a8227cb6e980dbce72919b3cf109
https://github.com/lxc/lxc/commit/83742e7c9688a8227cb6e980dbce72919b3cf109
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: introduce sync_wait_fd() and sync_wake_fd()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 305a9b814974e5f066b847a505f600e9b4ed93c8
https://github.com/lxc/lxc/commit/305a9b814974e5f066b847a505f600e9b4ed93c8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/sync.h
Log Message:
-----------
attach: use dummy macros to make it easier to follow sync logic
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a8d632705cce883024b4575cb5465cc6f9256284
https://github.com/lxc/lxc/commit/a8d632705cce883024b4575cb5465cc6f9256284
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: move new_cwd into tighter scope
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 64f221a19b8459fbab953cfa83a227f505ced3a6
https://github.com/lxc/lxc/commit/64f221a19b8459fbab953cfa83a227f505ced3a6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: use STDIN_FILENO instead of hard-coding 0
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ee026aa0beafe87f7ecb9564a57740ccdaf303bd
https://github.com/lxc/lxc/commit/ee026aa0beafe87f7ecb9564a57740ccdaf303bd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: remove unneeded assignment
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 25b0a827b8c0c00a9ee319ac8a54d8716926af75
https://github.com/lxc/lxc/commit/25b0a827b8c0c00a9ee319ac8a54d8716926af75
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: rework attaching to namespace fds
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b23d7e3eada4564d5a8978f07b0c5412a786efca
https://github.com/lxc/lxc/commit/b23d7e3eada4564d5a8978f07b0c5412a786efca
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/macro.h
Log Message:
-----------
attach: move to file descriptor-only interactions
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ea1b57dfa5df834292c20963ca851a56b3abf5d4
https://github.com/lxc/lxc/commit/ea1b57dfa5df834292c20963ca851a56b3abf5d4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/namespace.c
M src/lxc/namespace.h
Log Message:
-----------
attach: move to file descriptor only namespace interactions
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6d1b54e772ec928f786c52f00bca213f75c21409
https://github.com/lxc/lxc/commit/6d1b54e772ec928f786c52f00bca213f75c21409
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: init file descriptors to -EBADF
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0d657d6f273b2af065d59b35ea76781ddb6ea713
https://github.com/lxc/lxc/commit/0d657d6f273b2af065d59b35ea76781ddb6ea713
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: vet parameters more strictly
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bdc9e48d1578b4b8d77b96ec91bc6a4860cea55d
https://github.com/lxc/lxc/commit/bdc9e48d1578b4b8d77b96ec91bc6a4860cea55d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: use cleanup macro for consistency
and to prevent future mishaps.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 33afc6444d79148ec85d3f2fdadc9d5fe62b71fb
https://github.com/lxc/lxc/commit/33afc6444d79148ec85d3f2fdadc9d5fe62b71fb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: don't needless check for NULL
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a3d5e5775ed7df937d894a5425dadb7d62c85d80
https://github.com/lxc/lxc/commit/a3d5e5775ed7df937d894a5425dadb7d62c85d80
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/attach_options.h
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/lsm.h
M src/lxc/lsm/nop.c
M src/lxc/lsm/selinux.c
Log Message:
-----------
attach: file descriptors based LSM handling
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3c6bc30718d2a9f36ef2d740bdee15cd52e0e127
https://github.com/lxc/lxc/commit/3c6bc30718d2a9f36ef2d740bdee15cd52e0e127
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: hardening through use of pidfds
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7d9e64d8fc302c7d3b22a8f1336555e2d0050a2d
https://github.com/lxc/lxc/commit/7d9e64d8fc302c7d3b22a8f1336555e2d0050a2d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lsm/apparmor.c
Log Message:
-----------
lsm/apparmor: cleanup apparmor_process_label_set()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f3df6cf0aaf1490c2efbee48378ef0d0479784dd
https://github.com/lxc/lxc/commit/f3df6cf0aaf1490c2efbee48378ef0d0479784dd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
file_utils: add fdopenat()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 18ed7fdc062d517ea8adca504f0ac3c86861245c
https://github.com/lxc/lxc/commit/18ed7fdc062d517ea8adca504f0ac3c86861245c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: unifiy /proc/<init-pid>/status parsing
and move it out of do_attach(). The less we do in the container's context the
better.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 48fd08f9424866893f8c1ba34f303aafc09c2151
https://github.com/lxc/lxc/commit/48fd08f9424866893f8c1ba34f303aafc09c2151
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: initialize init_pid field to -ESRCH
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c793e9f3bf760bee6443cb10579879e4df6a5fd9
https://github.com/lxc/lxc/commit/c793e9f3bf760bee6443cb10579879e4df6a5fd9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: move uid and gid handling to get_attach_context()
the less we do in do_attach(), the better.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 58d62c8698cc0295900e01d891a7a30c74b40a27
https://github.com/lxc/lxc/commit/58d62c8698cc0295900e01d891a7a30c74b40a27
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: simplify opening of /proc/self
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0c2b56fd30c7d2adf32bf7dd08c5308803ad9fa2
https://github.com/lxc/lxc/commit/0c2b56fd30c7d2adf32bf7dd08c5308803ad9fa2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: document attach_context
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 07897df2c849b2742776cbc752c2eb4cb3a3c54a
https://github.com/lxc/lxc/commit/07897df2c849b2742776cbc752c2eb4cb3a3c54a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: stash host uid and host gid in attach_context
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c60715623adc92576ad1a311576e571c1bb1b74c
https://github.com/lxc/lxc/commit/c60715623adc92576ad1a311576e571c1bb1b74c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: remove pointless NULL checks
We're already ensuring before that conf isn't NULL.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 73c476c523f13e960562eef3582b27eb78eba8ab
https://github.com/lxc/lxc/commit/73c476c523f13e960562eef3582b27eb78eba8ab
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
Log Message:
-----------
file_utils: add open_at()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2aeb8b81be660d9b50bde774a83e83e36fd2cba3
https://github.com/lxc/lxc/commit/2aeb8b81be660d9b50bde774a83e83e36fd2cba3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
Log Message:
-----------
syscall_wrappers: add PROTECT_LOOKUP, PROTECT_OPEN, PROTECT_LOOKUP_WITH_SYMLINKS, PROTECT_OPEN_WITH_TRAILING_SYMLINKS
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: af0660e42c34280dba2af6b0ca91071cfa7bf314
https://github.com/lxc/lxc/commit/af0660e42c34280dba2af6b0ca91071cfa7bf314
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h
Log Message:
-----------
attach: harden open calls
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 78a14d81dd48eb26830c720a175d75a7972333b4
https://github.com/lxc/lxc/commit/78a14d81dd48eb26830c720a175d75a7972333b4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/file_utils.c
M src/lxc/file_utils.h
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/selinux.c
Log Message:
-----------
tree-wide: extend read_file_at()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d81eb9187176cfb7a4b8f441ce9b3d79f0751559
https://github.com/lxc/lxc/commit/d81eb9187176cfb7a4b8f441ce9b3d79f0751559
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/selinux.c
Log Message:
-----------
lsm: harden read_file_at()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 60e1cd4efb3e3cb8ea288e3a53237823b8b48479
https://github.com/lxc/lxc/commit/60e1cd4efb3e3cb8ea288e3a53237823b8b48479
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
Log Message:
-----------
file_utils: remove O_NOFOLLOW from open_at() defaults
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 35c672e889eeb5ad1d43016d5256097e2dcbc5a4
https://github.com/lxc/lxc/commit/35c672e889eeb5ad1d43016d5256097e2dcbc5a4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: file descriptor based fdinfo handling
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5e6b9c8a0ba8794270e3b2eb8cea3705f49daa91
https://github.com/lxc/lxc/commit/5e6b9c8a0ba8794270e3b2eb8cea3705f49daa91
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: prevent UAF
Fixes: Coverity 1472761
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5d9569cafc45cc75fdfd490a2849a2c04205ed06
https://github.com/lxc/lxc/commit/5d9569cafc45cc75fdfd490a2849a2c04205ed06
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: use correct put method
Fixes: Coverity 1472763
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 639acb7966be5cac57c15b92fc93517c2220b7d7
https://github.com/lxc/lxc/commit/639acb7966be5cac57c15b92fc93517c2220b7d7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: stricter lookup semantics for fdopen_at() calls
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ec5ce3bb285d73f4c3338211c28be3a204866b5b
https://github.com/lxc/lxc/commit/ec5ce3bb285d73f4c3338211c28be3a204866b5b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: move file descriptor closing into attach_context_container()
This reduces the possibility of forgetting to close the namespace file
descriptors when we change this codepath.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f3b1c0462a45637d9d3550442877b410c253a1df
https://github.com/lxc/lxc/commit/f3b1c0462a45637d9d3550442877b410c253a1df
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: move loading seccomp as late as possible
We want to minimize the change that the profile blocks syscalls we need during
attach setup and has the notifier enabled.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 826de44f226b29b853ad6f2267c7e1b4b0a15c63
https://github.com/lxc/lxc/commit/826de44f226b29b853ad6f2267c7e1b4b0a15c63
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/memory_utils.h
Log Message:
-----------
memory_utils: add close_prot_errno_mov()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 11a2f972d2ce5dff76b09eec2425f41c59ef2bf6
https://github.com/lxc/lxc/commit/11a2f972d2ce5dff76b09eec2425f41c59ef2bf6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
Log Message:
-----------
file_utils: harden lxc_open_dirfd()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 579a0d465a43ef68e006068c59883b6fafb9494a
https://github.com/lxc/lxc/commit/579a0d465a43ef68e006068c59883b6fafb9494a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
Log Message:
-----------
file_utils: harden lxc_writeat()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6870cd28f5a1b54391cc6b6b1f4f2eb8070326f8
https://github.com/lxc/lxc/commit/6870cd28f5a1b54391cc6b6b1f4f2eb8070326f8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
Log Message:
-----------
cgroups: add unified_cgroup_fd() helper
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c0d717c3ab7e5dacb81e4fd64a57fa478782234c
https://github.com/lxc/lxc/commit/c0d717c3ab7e5dacb81e4fd64a57fa478782234c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: switch controller delegation to fd-only operations
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 500b6698f07826a819d2ec3654f4b0b9ab733fd0
https://github.com/lxc/lxc/commit/500b6698f07826a819d2ec3654f4b0b9ab733fd0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: abuse ENOMEDIUM as ENOCGROUP2
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d2605aa8916c9b7ffb52371e73b6e6c3ed569275
https://github.com/lxc/lxc/commit/d2605aa8916c9b7ffb52371e73b6e6c3ed569275
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
Log Message:
-----------
file_utils: add lxc_read_try_buf_at()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6d9ba015879dee94d79fd9501efe526e9e493e5f
https://github.com/lxc/lxc/commit/6d9ba015879dee94d79fd9501efe526e9e493e5f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: add cgroup_get()
This is a unified hierarchy only method which doesn't need to initialize a full
cgroup driver. Instead, it relies on the command socket to retrieve a cgroup2
file descriptor to the container's cgroup.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cc9644d2ef98dd381e3aba2a70eec1db653c7a0d
https://github.com/lxc/lxc/commit/cc9644d2ef98dd381e3aba2a70eec1db653c7a0d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: use cgroup_get()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5793c6c6a4483660284a736d56db4008d2e0c18b
https://github.com/lxc/lxc/commit/5793c6c6a4483660284a736d56db4008d2e0c18b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/lxccontainer.c
Log Message:
-----------
cgroups: reorder cgroup_get() arguments
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e0f5c4e8c886ceb8bc4d0715f84a3189d79b3340
https://github.com/lxc/lxc/commit/e0f5c4e8c886ceb8bc4d0715f84a3189d79b3340
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: add croup_set()
This is a unified hierarchy only method which doesn't need to initialize a full
cgroup driver. Instead, it relies on the command socket to retrieve a cgroup2
file descriptor to the container's cgroup.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 562c20d8a4344439c4ca0c917099a4ea741bd42e
https://github.com/lxc/lxc/commit/562c20d8a4344439c4ca0c917099a4ea741bd42e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: use correct variable ordering
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8cf74c657c856330bdc12f233513541f9a539926
https://github.com/lxc/lxc/commit/8cf74c657c856330bdc12f233513541f9a539926
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: use cgroup_set()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: db4482effe8b4868b494ff8e6eb73e79195b6ee7
https://github.com/lxc/lxc/commit/db4482effe8b4868b494ff8e6eb73e79195b6ee7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: move functions after methods
This makes it more obvious that they are separate.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7f01b880cc3ae5f7dfc32c26c78d056e76e7bb07
https://github.com/lxc/lxc/commit/7f01b880cc3ae5f7dfc32c26c78d056e76e7bb07
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: annotate cgroup_get()/cgroup_set()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3bad551feb863fbd1b0f0b116e7d946a15cbb48b
https://github.com/lxc/lxc/commit/3bad551feb863fbd1b0f0b116e7d946a15cbb48b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands_utils.c
M src/lxc/commands_utils.h
Log Message:
-----------
commands_utils: add lcx_cmd_notify_state_listeners()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 071ed26f6f612617fd650dd0f9a962f868f00f37
https://github.com/lxc/lxc/commit/071ed26f6f612617fd650dd0f9a962f868f00f37
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/freezer.c
Log Message:
-----------
freezer: use lxc_cmd_notify_state_listeners()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e2298782058c9a7e7405b4a1c9d104ed1c250ccb
https://github.com/lxc/lxc/commit/e2298782058c9a7e7405b4a1c9d104ed1c250ccb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: add cgroup_freeze() and cgroup_unfreeze()
These are unified hierarchy only methods which don't need to initialize a full
cgroup driver. Instead, they rely on the command socket to retrieve a cgroup2
file descriptor to the container's cgroup.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c275ab2df0ab3b93a554a574edc0281499cb04ce
https://github.com/lxc/lxc/commit/c275ab2df0ab3b93a554a574edc0281499cb04ce
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/freezer.c
M src/lxc/lxc.h
Log Message:
-----------
freezer: make methods return bool
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cb1c25449ac5f9fbd7eea478d41e7d1674846a18
https://github.com/lxc/lxc/commit/cb1c25449ac5f9fbd7eea478d41e7d1674846a18
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: use cgroup_freeze() and cgroup_unfreeze()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cfb4d8d5b22d28f5410d5a2a5e685e3e323000b7
https://github.com/lxc/lxc/commit/cfb4d8d5b22d28f5410d5a2a5e685e3e323000b7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: rewind() file before polling again
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8ab39cf2778e049ec4ce8c34aeeba879bd04d07b
https://github.com/lxc/lxc/commit/8ab39cf2778e049ec4ce8c34aeeba879bd04d07b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/lxccontainer.c
Log Message:
-----------
cgroups: remove unused conf argument
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cae165931cf9386038cb1b8924a2792cc8ea3511
https://github.com/lxc/lxc/commit/cae165931cf9386038cb1b8924a2792cc8ea3511
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: vet parameters
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: eaafcd25fdffd7fedb10066d30fc1735d55c2548
https://github.com/lxc/lxc/commit/eaafcd25fdffd7fedb10066d30fc1735d55c2548
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: use correct error checks
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5dbe84aba549e323bb97806d6c5eb8fa2776fcfe
https://github.com/lxc/lxc/commit/5dbe84aba549e323bb97806d6c5eb8fa2776fcfe
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: move down cgroup_attach()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bac01cc4d64f1d875b65a4ddcb039965d724e807
https://github.com/lxc/lxc/commit/bac01cc4d64f1d875b65a4ddcb039965d724e807
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: stricter argument vetting for cgroup_attach()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9986eed0b49c1f8f0fabe6249c51742fe63413f2
https://github.com/lxc/lxc/commit/9986eed0b49c1f8f0fabe6249c51742fe63413f2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: return ENOCGROUP2 from cgroup_attach()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ecb2b4d235da4c51c68b5aa03ff6ea3ec223f3ee
https://github.com/lxc/lxc/commit/ecb2b4d235da4c51c68b5aa03ff6ea3ec223f3ee
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: check for ENOCGROUP2 explicitly
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fd910d780b2f37d804065397e18ba0997d873172
https://github.com/lxc/lxc/commit/fd910d780b2f37d804065397e18ba0997d873172
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/freezer.c
M src/lxc/lxc.h
M src/lxc/lxccontainer.c
Log Message:
-----------
cgroups: switch back to returning ints
Whick makes for easier error checking and fallback code.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 523157580c1c1ed8a20e7073a932811f27b5445b
https://github.com/lxc/lxc/commit/523157580c1c1ed8a20e7073a932811f27b5445b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/lxcseccomp.h
M src/lxc/seccomp.c
Log Message:
-----------
attach: explicitly close seccomp notifier fd
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 869eed51f464cca319ed543d6f626d29e7be37d1
https://github.com/lxc/lxc/commit/869eed51f464cca319ed543d6f626d29e7be37d1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/tests/cgpath.c
Log Message:
-----------
cgpath: add logging
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 28c4e35a106b030836c29702543c80d8ea5ff1c9
https://github.com/lxc/lxc/commit/28c4e35a106b030836c29702543c80d8ea5ff1c9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: add missing lxc_cmd_get_limiting_cgroup2_fd() implementation
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fce696f26b627548fd28dfcebf830ed6be03aba1
https://github.com/lxc/lxc/commit/fce696f26b627548fd28dfcebf830ed6be03aba1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: use lxc_cmd_get_limiting_cgroup2_fd()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d78b7f47d57c746597bf459cd300149b1dbe17a7
https://github.com/lxc/lxc/commit/d78b7f47d57c746597bf459cd300149b1dbe17a7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: export __cgroup_unfreeze() for use in commands
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 389185d660ed92235f232998fb94ce9dd43e1ffa
https://github.com/lxc/lxc/commit/389185d660ed92235f232998fb94ce9dd43e1ffa
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: use __cgroup_unfreeze() directly
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a2e9169a9bbe4ffbd22bd4287dd7db090b9c17b8
https://github.com/lxc/lxc/commit/a2e9169a9bbe4ffbd22bd4287dd7db090b9c17b8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/freezer.c
Log Message:
-----------
freezer: remove lxc_cmd_freeze() and lxc_cmd_unfreeze() calls
We're now handling them better.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 39638419062a5df3369e343d74033fd9b538ad7b
https://github.com/lxc/lxc/commit/39638419062a5df3369e343d74033fd9b538ad7b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/tests/Makefile.am
M src/tests/device_add_remove.c
Log Message:
-----------
test: add logging to device_add_remove
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e59d39897bb70ca6d0ddf14818563e548cfb1932
https://github.com/lxc/lxc/commit/e59d39897bb70ca6d0ddf14818563e548cfb1932
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/tests/cgpath.c
Log Message:
-----------
tests: support pure unified cgroup layouts in cgpath test
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a3ec4153c7d3952c23356ed3bde0b782e3cb6108
https://github.com/lxc/lxc/commit/a3ec4153c7d3952c23356ed3bde0b782e3cb6108
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/lxccontainer.c
Log Message:
-----------
cgroups: improve parameter vetting
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 24cd45519500c9976d3cba4623f8540d404a2def
https://github.com/lxc/lxc/commit/24cd45519500c9976d3cba4623f8540d404a2def
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/tests/device_add_remove.c
Log Message:
-----------
tests: check for NULL in device_add_remove
Fixes: Coverity 1472768
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 83cd77dbd9625f5396fbd6d877fed6eef39db604
https://github.com/lxc/lxc/commit/83cd77dbd9625f5396fbd6d877fed6eef39db604
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M configure.ac
M src/lxc/syscall_numbers.h
M src/lxc/syscall_wrappers.h
Log Message:
-----------
syscalls: add close_range()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e85a4792007ff3e5c3b1dcbc68a9a0175aa91d45
https://github.com/lxc/lxc/commit/e85a4792007ff3e5c3b1dcbc68a9a0175aa91d45
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/macro.h
M src/lxc/rexec.c
Log Message:
-----------
rexec: mark all fds as close-on-exec if possible
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d3491dfcd8f4ba94f4bdef6d6df0974f135895e0
https://github.com/lxc/lxc/commit/d3491dfcd8f4ba94f4bdef6d6df0974f135895e0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: remove unnecessary syscall
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ebb4d1a2b01429476b6e9fa1bc328e0c35e18f00
https://github.com/lxc/lxc/commit/ebb4d1a2b01429476b6e9fa1bc328e0c35e18f00
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: restrict open of dev/
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c18a6ad1507b4d2b4e1550e21a5875b39102542f
https://github.com/lxc/lxc/commit/c18a6ad1507b4d2b4e1550e21a5875b39102542f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: harden open in lxc_fill_autodev()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ec09da6fe1953a18df935aa0833fd1da5a51c2e5
https://github.com/lxc/lxc/commit/ec09da6fe1953a18df935aa0833fd1da5a51c2e5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: fd-only operations in lxc_setup_dev_symlinks()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8a1a6dd6d75f6f8b454e6e6f84417d8d4133c57e
https://github.com/lxc/lxc/commit/8a1a6dd6d75f6f8b454e6e6f84417d8d4133c57e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: restrict open for lxc_mount_rootfs()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 65d42af074a7d5dc48ece0df98e6a3afe6d1540d
https://github.com/lxc/lxc/commit/65d42af074a7d5dc48ece0df98e6a3afe6d1540d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: fd-only pivot root
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8fc6f4178b678728c918b27984935f2961c1de7a
https://github.com/lxc/lxc/commit/8fc6f4178b678728c918b27984935f2961c1de7a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: fd-only devtps setup
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 908a01746973a5a62c3c1e01b9a52986ce6581e6
https://github.com/lxc/lxc/commit/908a01746973a5a62c3c1e01b9a52986ce6581e6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: attach to namespaces via pidfds
This is a feature we've enabled in kernel v5.8 and v5.9.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f146497f224afd5af04405cea7500949a5d1182a
https://github.com/lxc/lxc/commit/f146497f224afd5af04405cea7500949a5d1182a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: coding style
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8c979bf2745eb507a52261fda7b3c69b2205adad
https://github.com/lxc/lxc/commit/8c979bf2745eb507a52261fda7b3c69b2205adad
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/utils.h
Log Message:
-----------
conf: make lxc_create_tmp_proc_mount() static
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7413dcc033e0b453e908a1c784153b471a397cc2
https://github.com/lxc/lxc/commit/7413dcc033e0b453e908a1c784153b471a397cc2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: restrict open call in lxc_mount_rootfs()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8e262f5e03b1885ef2f57506aa6d1def5c92abae
https://github.com/lxc/lxc/commit/8e262f5e03b1885ef2f57506aa6d1def5c92abae
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
Log Message:
-----------
conf: refactor transient procfs mounting
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c8c6a0a725afa52e0c642e0a2ec25ed1db855c0a
https://github.com/lxc/lxc/commit/c8c6a0a725afa52e0c642e0a2ec25ed1db855c0a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: harden __safe_mount_beneath_at()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0c58dd31a9488074b153a566987c6dbc208b1803
https://github.com/lxc/lxc/commit/0c58dd31a9488074b153a566987c6dbc208b1803
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: restricted fd-only controller mountpoint creation
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f10d69e3c1261627444153379bc54dffe7f9b962
https://github.com/lxc/lxc/commit/f10d69e3c1261627444153379bc54dffe7f9b962
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.h
M src/lxc/string_utils.h
M src/lxc/utils.c
Log Message:
-----------
cgroups: switch to fd-based cgroup mounting
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9f880a8a5feb357d6427858a41ffa3e906885b18
https://github.com/lxc/lxc/commit/9f880a8a5feb357d6427858a41ffa3e906885b18
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: fix fallback logic when attaching to cgroups
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 85aaa781e2ec155171aff048538d8b55733030e3
https://github.com/lxc/lxc/commit/85aaa781e2ec155171aff048538d8b55733030e3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: fix argument vetting in cgroup_attach()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1041c03b8113b8a89f62e617d3024c4ec5b2daf9
https://github.com/lxc/lxc/commit/1041c03b8113b8a89f62e617d3024c4ec5b2daf9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: improve error handling and logging in cgroup_attach_leaf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 37b56e9750073d9ce23e8a18177f71345fae43c6
https://github.com/lxc/lxc/commit/37b56e9750073d9ce23e8a18177f71345fae43c6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: restrict open calls in cgroup_attach_create_leaf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7ce4f69a037380dae9f30d83acaaa0aafa4577b1
https://github.com/lxc/lxc/commit/7ce4f69a037380dae9f30d83acaaa0aafa4577b1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
utils: add mount_from_at()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f4c43287485017a3386f70b3e8bfb687cbf06e88
https://github.com/lxc/lxc/commit/f4c43287485017a3386f70b3e8bfb687cbf06e88
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: fix lxc_setup_dev_console()
We were printing garbage on accident.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d6c618aad35e248b793baacc24aa19a4fcba95d9
https://github.com/lxc/lxc/commit/d6c618aad35e248b793baacc24aa19a4fcba95d9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
Log Message:
-----------
conf: start stashing dfd to host's / during container setup
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4eaba6a473da2d3a984202b7c034133c10abff04
https://github.com/lxc/lxc/commit/4eaba6a473da2d3a984202b7c034133c10abff04
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: restricted fd-only lxc_fill_autodev()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3bc37321ddc3897cbef24a1d9dac50848724f34e
https://github.com/lxc/lxc/commit/3bc37321ddc3897cbef24a1d9dac50848724f34e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/syscall_wrappers.h
Log Message:
-----------
syscall_wrappers: fix PROTECT_OPEN_W macro
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: acf2aed8698c7b4e0e385994352ca3e5bfa9a6cc
https://github.com/lxc/lxc/commit/acf2aed8698c7b4e0e385994352ca3e5bfa9a6cc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
Log Message:
-----------
tree-wide: s/dev_mntpt_fd/dfd_dev/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 856fb7195960632364c9c7e513ab2bbe155a7b74
https://github.com/lxc/lxc/commit/856fb7195960632364c9c7e513ab2bbe155a7b74
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/conf.h
Log Message:
-----------
tree-wide: s/mntpt_fd/dfd_mnt/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cb17f83f0b557982596b739e62af5b76499302a6
https://github.com/lxc/lxc/commit/cb17f83f0b557982596b739e62af5b76499302a6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
Log Message:
-----------
tree-wide: s/dfd_root_host/dfd_host/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f6666d3b04d2d96b07f5df1db34d81487c618c1a
https://github.com/lxc/lxc/commit/f6666d3b04d2d96b07f5df1db34d81487c618c1a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: check for correct error in __cg_unified_attach() from cgroup_attach()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 883a6f8f7646405251fa71b4adbc49b2a3ad3e28
https://github.com/lxc/lxc/commit/883a6f8f7646405251fa71b4adbc49b2a3ad3e28
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: improve logging and terminology
The term "intermediate process" is not very nice imho, "transient process" fits
better.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fde1420c9066166353c6eba4f3c7a1326e3650e2
https://github.com/lxc/lxc/commit/fde1420c9066166353c6eba4f3c7a1326e3650e2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: check for snprintf() error
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 35c45e17894e7bea7d69860213749694c082753a
https://github.com/lxc/lxc/commit/35c45e17894e7bea7d69860213749694c082753a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
utils: add lxc_drop_groups()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1529fd39b7df8ce99042f9ee62ec2033ce4fe230
https://github.com/lxc/lxc/commit/1529fd39b7df8ce99042f9ee62ec2033ce4fe230
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cmd/lxc_usernsexec.c
M src/lxc/conf.c
M src/lxc/lxccontainer.c
M src/lxc/start.c
M src/lxc/storage/btrfs.c
M src/lxc/storage/rsync.c
M src/lxc/storage/storage_utils.c
Log Message:
-----------
tree-wide: use lxc_drop_groups() instead of lxc_setgroups(0, NULL)
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7e9d3f208c0f0428b5e8568b39f09dd8d55f0d21
https://github.com/lxc/lxc/commit/7e9d3f208c0f0428b5e8568b39f09dd8d55f0d21
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
utils: rework lxc_setgroups()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e778f9739a01dc25935dc8cdb7499ed026fbfbf1
https://github.com/lxc/lxc/commit/e778f9739a01dc25935dc8cdb7499ed026fbfbf1
Author: Ruben Jenster <r.jenster at drachenfels.de>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/confile.c
M src/lxc/start.c
Log Message:
-----------
confile: add lxc.init.groups to keep additional groups
Signed-off-by: Ruben Jenster <r.jenster at drachenfels.de>
Commit: 8066b01fe2c17abec3c05580e7605703a346cc22
https://github.com/lxc/lxc/commit/8066b01fe2c17abec3c05580e7605703a346cc22
Author: Ruben Jenster <r.jenster at drachenfels.de>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/attach_options.h
Log Message:
-----------
attach: Add groups option to keep additional group IDs.
Signed-off-by: Ruben Jenster <r.jenster at drachenfels.de>
Commit: 2ab3ea3eeda1ef3e48f95b3f6d71558f435418ed
https://github.com/lxc/lxc/commit/2ab3ea3eeda1ef3e48f95b3f6d71558f435418ed
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach_options.h
Log Message:
-----------
attach_options: initialize .groups
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7cec31a9afb2fcfa4dde1edcec8b341c5d5254dd
https://github.com/lxc/lxc/commit/7cec31a9afb2fcfa4dde1edcec8b341c5d5254dd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach_options.h
Log Message:
-----------
attach_options: use standard C pointer syntax
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8e5fb3de47613d3f83fbc5e1623b53ee24e64447
https://github.com/lxc/lxc/commit/8e5fb3de47613d3f83fbc5e1623b53ee24e64447
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: use brackets around flag check
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6c289559e2d04f5095c1688f3e83775475707025
https://github.com/lxc/lxc/commit/6c289559e2d04f5095c1688f3e83775475707025
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach_options.h
Log Message:
-----------
attach_options: use size_t for lxc_groups_t
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 506ec8384633fdaa12189700fdffc8958fdaeda9
https://github.com/lxc/lxc/commit/506ec8384633fdaa12189700fdffc8958fdaeda9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.h
Log Message:
-----------
conf: use lxc_groups_t directly
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 36fbe8514655313af0636d91d4501d2294d66679
https://github.com/lxc/lxc/commit/36fbe8514655313af0636d91d4501d2294d66679
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/confile.c
Log Message:
-----------
confile: handle appending init groups
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c59b7ab9c3158bcf8360cc09985cfdc0bf1f3661
https://github.com/lxc/lxc/commit/c59b7ab9c3158bcf8360cc09985cfdc0bf1f3661
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/Makefile.am
M src/lxc/cgroups/cgfsng.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/utils.c
M src/lxc/utils.h
M src/tests/Makefile.am
Log Message:
-----------
mount_utils: move mount_at() and mount_from_at() over from utils.{c,h}
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b6546e30ba37e6beac59e65203ab796102188c3e
https://github.com/lxc/lxc/commit/b6546e30ba37e6beac59e65203ab796102188c3e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
Log Message:
-----------
mount_utils: add extended helpers for new mount api
fs_prepare()
fs_set_property()
fs_attach()
fs_mount()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ee28c8ce4b026affd72ebd26cd3a3a6539b71f33
https://github.com/lxc/lxc/commit/ee28c8ce4b026affd72ebd26cd3a3a6539b71f33
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: switch mount_autodev() to new mount api
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9b0712c024f6c04cdbf9942c8ea92577bd81cd12
https://github.com/lxc/lxc/commit/9b0712c024f6c04cdbf9942c8ea92577bd81cd12
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: switch tmpfs mounting to new mount api
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7bd7619b83a8b19d9b8c4fac6c5f59735d37c18e
https://github.com/lxc/lxc/commit/7bd7619b83a8b19d9b8c4fac6c5f59735d37c18e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: switch __cg_mount_direct() to use the new mount api
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a4df98203b36d1154f7509057ffbefce21d30458
https://github.com/lxc/lxc/commit/a4df98203b36d1154f7509057ffbefce21d30458
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
Log Message:
-----------
mount_utils: kill mount_at()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8e7c46e80dfd9bf986a75be86c8b4f9c8861c9d7
https://github.com/lxc/lxc/commit/8e7c46e80dfd9bf986a75be86c8b4f9c8861c9d7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
Log Message:
-----------
mount_utils: add support for bind-mounts through the new mount api
fd_bind_mount()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d469fee9b40ce3b489327a5fad49ab596351dcab
https://github.com/lxc/lxc/commit/d469fee9b40ce3b489327a5fad49ab596351dcab
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: use fd_bind_mount() in lxc_fill_autodev()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 296e0b11207227e36a74bc2432d09b5faa2d18d4
https://github.com/lxc/lxc/commit/296e0b11207227e36a74bc2432d09b5faa2d18d4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
Log Message:
-----------
mount_utils: kill mount_from_at()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c4199d115f083af71eb5d020550e4153f37fd760
https://github.com/lxc/lxc/commit/c4199d115f083af71eb5d020550e4153f37fd760
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/mount_utils.h
Log Message:
-----------
mount_utils: detect new mount api support
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 362ad2f2e8c08f6cf1c223d58a927ce3fae30a21
https://github.com/lxc/lxc/commit/362ad2f2e8c08f6cf1c223d58a927ce3fae30a21
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
Log Message:
-----------
tree-wide: make use of new_mount_api() where it makes sense
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 20af37f789a0725191af8644d3b41c002101ecc5
https://github.com/lxc/lxc/commit/20af37f789a0725191af8644d3b41c002101ecc5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/mount_utils.h
Log Message:
-----------
mount_utils: initialize fd
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 177458b6fa2b974c8cdd8b042a6d69941bbeb045
https://github.com/lxc/lxc/commit/177458b6fa2b974c8cdd8b042a6d69941bbeb045
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: switch to simple mount()
At the point where we're remounging proc and sys we're in the container's
namespaces so there's no chance of escape so a simple mount() syscall will
suffice.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a7141930fe9004b7b3dab208698196c5a9affb49
https://github.com/lxc/lxc/commit/a7141930fe9004b7b3dab208698196c5a9affb49
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
Log Message:
-----------
mount_utils: kill mount_filesystem()
We have way better helpers now.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3c0117ccfbb5820b72fec1d82537f82c1d313f1e
https://github.com/lxc/lxc/commit/3c0117ccfbb5820b72fec1d82537f82c1d313f1e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M configure.ac
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
M src/lxc/storage/dir.c
Log Message:
-----------
mount_utils: add locked flag helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a7f145beff658e887ff6cfeee5be460597e0a2cb
https://github.com/lxc/lxc/commit/a7f145beff658e887ff6cfeee5be460597e0a2cb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: s/setup_mount()/setup_mount_fstab()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: dfaa5d997e5dec53f7b4ebb34feb7f19b0008813
https://github.com/lxc/lxc/commit/dfaa5d997e5dec53f7b4ebb34feb7f19b0008813
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: kill PATH_MAX bytes
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: db37aefca3cf414b41129696e2f9814387e53a25
https://github.com/lxc/lxc/commit/db37aefca3cf414b41129696e2f9814387e53a25
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: don't pass struct lxc_conf
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6185368cf1586d7ad0b37fb0e4addb8157e5ec46
https://github.com/lxc/lxc/commit/6185368cf1586d7ad0b37fb0e4addb8157e5ec46
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: kill PATH_MAX bytes
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 41e9f73c2779bc03c2b12da5227382c5f6800b4c
https://github.com/lxc/lxc/commit/41e9f73c2779bc03c2b12da5227382c5f6800b4c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: kill PAT_MAX bytes
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 06151d4a373d3eb2551cdb74c806a01588ca35bb
https://github.com/lxc/lxc/commit/06151d4a373d3eb2551cdb74c806a01588ca35bb
Author: Max <blenkmax at gmail.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: Add error message if iw couldn't be found
When iw is not installed on the host, lxc fails to move wireless devices
into a container. Unfortunately there is no real error message yet
(other than that it didn't work), so its quite unobvious what causes
this. This commit adds a error message that clearly states the
application iw is missing.
Signed-off-by: Maximilian Blenk <blenkmax at gmail.com>
Commit: b01c4bfc55def9309f44226368db6296b0a3ca03
https://github.com/lxc/lxc/commit/b01c4bfc55def9309f44226368db6296b0a3ca03
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/start.c
M src/lxc/start.h
Log Message:
-----------
conf: rework rootfs pinning
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: dcd11783acc17e178a6e23c6d5c28645fd9f9668
https://github.com/lxc/lxc/commit/dcd11783acc17e178a6e23c6d5c28645fd9f9668
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/mount_utils.c
Log Message:
-----------
mount_utils: s/OPEN_TREE_CLONE | OPEN_TREE_CLONE/OPEN_TREE_CLONE | OPEN_TREE_CLOEXEC/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f411dfea1377fb45fc241e8c6fdb6b79d022f92d
https://github.com/lxc/lxc/commit/f411dfea1377fb45fc241e8c6fdb6b79d022f92d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: fd-only tty setup
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8935d6e60c79a2a3de9270e459b1d9dbfea8ffbc
https://github.com/lxc/lxc/commit/8935d6e60c79a2a3de9270e459b1d9dbfea8ffbc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/tests/lxc-test-unpriv
Log Message:
-----------
tests: add logging to lxc-test-unpriv
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: eefaa69c4b04e5e0c585818f6ce6834252351af7
https://github.com/lxc/lxc/commit/eefaa69c4b04e5e0c585818f6ce6834252351af7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: kill PATH_MAX bytes
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b4e90f9f1f47b9cdceb6d4cec72031a27032344e
https://github.com/lxc/lxc/commit/b4e90f9f1f47b9cdceb6d4cec72031a27032344e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: kill PATH_MAX bytes
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e78117f9581d7cfc4ffd1a26a0b1d7ffd85c9b2a
https://github.com/lxc/lxc/commit/e78117f9581d7cfc4ffd1a26a0b1d7ffd85c9b2a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: fix memory leak
Fixes: Coverity 1472848
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c8338a6c8d5d239140746e566106d26fa4911b9e
https://github.com/lxc/lxc/commit/c8338a6c8d5d239140746e566106d26fa4911b9e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/criu.c
Log Message:
-----------
criu: mark cgroups methods specific to criu
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2b6fc88b7b4ba3608f286ead9e88ba57af7c38cc
https://github.com/lxc/lxc/commit/2b6fc88b7b4ba3608f286ead9e88ba57af7c38cc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
M src/lxc/macro.h
M src/lxc/memory_utils.h
Log Message:
-----------
criu: massage exec_criu()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: dc05afb2f1139d252b250381f7f72489c77078cd
https://github.com/lxc/lxc/commit/dc05afb2f1139d252b250381f7f72489c77078cd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: move logging under lxc_log_trace()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 934d0d8b16923fc9115f364413503db46eeeb8dc
https://github.com/lxc/lxc/commit/934d0d8b16923fc9115f364413503db46eeeb8dc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: use cleanup macro
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 29f36c718e37a5d6766092658027ec91b3dd0372
https://github.com/lxc/lxc/commit/29f36c718e37a5d6766092658027ec91b3dd0372
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: use cleanup macro when parsing mount data
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 38aaaeb7101f2d6f4282e8108156d1532d2d504b
https://github.com/lxc/lxc/commit/38aaaeb7101f2d6f4282e8108156d1532d2d504b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: rework init pid retrieval
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1aaba0a0c6f4082131924bc8ce5b88ee8976ecfb
https://github.com/lxc/lxc/commit/1aaba0a0c6f4082131924bc8ce5b88ee8976ecfb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: warn about cgroup hierarchies without controllers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2682ad160418af3f529655d9c04239f65b36c3b0
https://github.com/lxc/lxc/commit/2682ad160418af3f529655d9c04239f65b36c3b0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: lxc_init() already initializes cgroups
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b82bb22c0c206f1c3fa93ffcfe1bc04e13e62f4d
https://github.com/lxc/lxc/commit/b82bb22c0c206f1c3fa93ffcfe1bc04e13e62f4d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: handle new cgroup layout
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 045ed5d93f24c4d676f82b13fc0910212bd966d7
https://github.com/lxc/lxc/commit/045ed5d93f24c4d676f82b13fc0910212bd966d7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: use brackets to have clear semantics for flags checking
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bbbd4a460e0a9df3dea1a4002ea69dff2c475c55
https://github.com/lxc/lxc/commit/bbbd4a460e0a9df3dea1a4002ea69dff2c475c55
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: do not return early when entering monitor cgroups
This will happen when restoring a container via criu.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4691665b8c1e847307a20c4c5771d2559738a63a
https://github.com/lxc/lxc/commit/4691665b8c1e847307a20c4c5771d2559738a63a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: log monitor and transient process entering
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: accd62914836e45216b188ff7cb7fa1ab483b5c5
https://github.com/lxc/lxc/commit/accd62914836e45216b188ff7cb7fa1ab483b5c5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: log container process entering
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f13e60dbc42c470ffb66a3a20de2b64cbcc9103a
https://github.com/lxc/lxc/commit/f13e60dbc42c470ffb66a3a20de2b64cbcc9103a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/string_utils.h
Log Message:
-----------
string_utils: add wrapper for snprintf()
This let's us avoid the tedious
if (ret < 0 || (size_t)ret >= sizeof(buf))
style of error checking.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 76ae4ba250d36bd89b0525162cc1aadd82cc4580
https://github.com/lxc/lxc/commit/76ae4ba250d36bd89b0525162cc1aadd82cc4580
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a80bd4769d66fa16111bae9085262d658482b234
https://github.com/lxc/lxc/commit/a80bd4769d66fa16111bae9085262d658482b234
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 30a8157944325e8203cfe5e23860de24dbbc0e78
https://github.com/lxc/lxc/commit/30a8157944325e8203cfe5e23860de24dbbc0e78
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands_utils.c
Log Message:
-----------
commands_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b4d3e2f4519855ca5691a50dee33ea8586470c5e
https://github.com/lxc/lxc/commit/b4d3e2f4519855ca5691a50dee33ea8586470c5e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 18105e58be8891043aea30ea2c90eaff972d26ff
https://github.com/lxc/lxc/commit/18105e58be8891043aea30ea2c90eaff972d26ff
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e6aeee836d779a36d584b2d226ddc5d9a87c4158
https://github.com/lxc/lxc/commit/e6aeee836d779a36d584b2d226ddc5d9a87c4158
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile_utils.c
Log Message:
-----------
confile_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9b9758c64b0fb701991e87406c448dc0592bc36a
https://github.com/lxc/lxc/commit/9b9758c64b0fb701991e87406c448dc0592bc36a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: efcfb3609c8ba91d1d4a5e3cc8e36f4e3a3a0273
https://github.com/lxc/lxc/commit/efcfb3609c8ba91d1d4a5e3cc8e36f4e3a3a0273
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
Log Message:
-----------
file_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ed6988d90ccb305e3a64c7789237d9cf4a3654c2
https://github.com/lxc/lxc/commit/ed6988d90ccb305e3a64c7789237d9cf4a3654c2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/log.c
Log Message:
-----------
log: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6ba3f517470aedd8b614ebd86527f357a15e3c95
https://github.com/lxc/lxc/commit/6ba3f517470aedd8b614ebd86527f357a15e3c95
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 272707bf9bb79b8b1d0cf854d4cd83c312ac7697
https://github.com/lxc/lxc/commit/272707bf9bb79b8b1d0cf854d4cd83c312ac7697
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxclock.c
Log Message:
-----------
lxclock: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6137f654a51fdb28726f16b89617a1294fb8c0dc
https://github.com/lxc/lxc/commit/6137f654a51fdb28726f16b89617a1294fb8c0dc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/monitor.c
Log Message:
-----------
monitor: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2b38c3a1a25b96b6440badaad9c79874b3504387
https://github.com/lxc/lxc/commit/2b38c3a1a25b96b6440badaad9c79874b3504387
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/mount_utils.c
Log Message:
-----------
mount_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c937bea736ab624aa3775af380c3857036c6460c
https://github.com/lxc/lxc/commit/c937bea736ab624aa3775af380c3857036c6460c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c829cc09a491b21a41d0c60cbd9e0ddf2e9eec0c
https://github.com/lxc/lxc/commit/c829cc09a491b21a41d0c60cbd9e0ddf2e9eec0c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/rexec.c
Log Message:
-----------
rexec: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2b416048bd7cc967bf8b8e05283c7bc58ef0dad6
https://github.com/lxc/lxc/commit/2b416048bd7cc967bf8b8e05283c7bc58ef0dad6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/seccomp.c
Log Message:
-----------
seccomp: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 62eda135f45c3127c7e963624f4268116ac7521d
https://github.com/lxc/lxc/commit/62eda135f45c3127c7e963624f4268116ac7521d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c66f3f43c200da5a9b566c2737d1b5a671ae1721
https://github.com/lxc/lxc/commit/c66f3f43c200da5a9b566c2737d1b5a671ae1721
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/terminal.c
Log Message:
-----------
terminal: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3fcae2e4a25dd0481591b94222e228b5953b56af
https://github.com/lxc/lxc/commit/3fcae2e4a25dd0481591b94222e228b5953b56af
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/string_utils.c
Log Message:
-----------
string_utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 83758a5570c5d539b08c8e5baf245b54faf01f7c
https://github.com/lxc/lxc/commit/83758a5570c5d539b08c8e5baf245b54faf01f7c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: convert to strnprintf()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b02b2c8164f0b1554e3af1623de5e27bc171c9ec
https://github.com/lxc/lxc/commit/b02b2c8164f0b1554e3af1623de5e27bc171c9ec
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/memory_utils.h
Log Message:
-----------
memory_utils: add close_move_fd()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: aabafa6848f54d2d6fa5cb0686d564a69baa06e0
https://github.com/lxc/lxc/commit/aabafa6848f54d2d6fa5cb0686d564a69baa06e0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/string_utils.h
Log Message:
-----------
string_utils: add proc_self_fd()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 00c5cdf0844900e9d06417c655b0c151405e87c1
https://github.com/lxc/lxc/commit/00c5cdf0844900e9d06417c655b0c151405e87c1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/string_utils.h
Log Message:
-----------
string_utils: add fdstr()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 60c613df73fb6b8de35f1390843e60803049dec8
https://github.com/lxc/lxc/commit/60c613df73fb6b8de35f1390843e60803049dec8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
Log Message:
-----------
file_utils: add same_file_lax()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1e08aa8fcb22840da7eb339986fdbe70c6b7f0e3
https://github.com/lxc/lxc/commit/1e08aa8fcb22840da7eb339986fdbe70c6b7f0e3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: add LXC_PROC_SELF_FD_LEN
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c0886b82498d409883ecfda47bc826809a826f0b
https://github.com/lxc/lxc/commit/c0886b82498d409883ecfda47bc826809a826f0b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: introduce lxc_bind_mount_console()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: aeb0b9bfea98bd560af557489e9e4bafd27540b6
https://github.com/lxc/lxc/commit/aeb0b9bfea98bd560af557489e9e4bafd27540b6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/mount_utils.c
M src/lxc/mount_utils.h
Log Message:
-----------
tree-wide: rework mount api support checks
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ff2006eedeeb863450b0ca7face11ff77dbcb6e1
https://github.com/lxc/lxc/commit/ff2006eedeeb863450b0ca7face11ff77dbcb6e1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 12359bb6828cd3a6a3e5fb2a264daff41a48042d
https://github.com/lxc/lxc/commit/12359bb6828cd3a6a3e5fb2a264daff41a48042d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup2_devices.c
Log Message:
-----------
cgroups: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ebb7d1d4a7f183e32af758d71892da60f2bb6c80
https://github.com/lxc/lxc/commit/ebb7d1d4a7f183e32af758d71892da60f2bb6c80
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 90b1a8eb5dd6cb1913e3b4203b32f340a541740e
https://github.com/lxc/lxc/commit/90b1a8eb5dd6cb1913e3b4203b32f340a541740e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d514ffef92687761221207bcf0776250b3c5fd03
https://github.com/lxc/lxc/commit/d514ffef92687761221207bcf0776250b3c5fd03
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile_utils.c
Log Message:
-----------
confile_utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 621bded4048e904a3b65bc531dcb744a30675661
https://github.com/lxc/lxc/commit/621bded4048e904a3b65bc531dcb744a30675661
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/criu.c
Log Message:
-----------
criu: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 88285cb1798adb8a24b9bdce2419f95cf4fdf41e
https://github.com/lxc/lxc/commit/88285cb1798adb8a24b9bdce2419f95cf4fdf41e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/initutils.c
Log Message:
-----------
initutils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4134561c187c57fdd018b9b4128dcac09057a86a
https://github.com/lxc/lxc/commit/4134561c187c57fdd018b9b4128dcac09057a86a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/log.c
Log Message:
-----------
log: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 925f47732497bdfac3a3ac3598e3c25a6ba74d99
https://github.com/lxc/lxc/commit/925f47732497bdfac3a3ac3598e3c25a6ba74d99
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lsm/apparmor.c
M src/lxc/lsm/selinux.c
Log Message:
-----------
lsm: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d47f691cd648133f7cae029c140810227779f800
https://github.com/lxc/lxc/commit/d47f691cd648133f7cae029c140810227779f800
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c61334a7fbc3212f0675fa6fbec4276ca5d6443e
https://github.com/lxc/lxc/commit/c61334a7fbc3212f0675fa6fbec4276ca5d6443e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d56c2ee95ff873707c753ced5485cd0acc56185e
https://github.com/lxc/lxc/commit/d56c2ee95ff873707c753ced5485cd0acc56185e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/seccomp.c
Log Message:
-----------
seccomp: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d1b30cbb97667eb6e15f20641b642ccc9b5eb45c
https://github.com/lxc/lxc/commit/d1b30cbb97667eb6e15f20641b642ccc9b5eb45c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/namespace.c
Log Message:
-----------
namespace: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 337d65622281fe8ea6fde4de4819ba5a41858b34
https://github.com/lxc/lxc/commit/337d65622281fe8ea6fde4de4819ba5a41858b34
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d2cfd2bab5d0ce7c689ca242da15b99ca1bb6a79
https://github.com/lxc/lxc/commit/d2cfd2bab5d0ce7c689ca242da15b99ca1bb6a79
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/state.c
Log Message:
-----------
state: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 928ada185a96b70bb3c3fce67b2b89e764e2f2ec
https://github.com/lxc/lxc/commit/928ada185a96b70bb3c3fce67b2b89e764e2f2ec
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/string_utils.c
Log Message:
-----------
string_utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 302d6b11ec9bccba3866d95bf0667a351ae48292
https://github.com/lxc/lxc/commit/302d6b11ec9bccba3866d95bf0667a351ae48292
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/terminal.c
Log Message:
-----------
terminal: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 51c1b152914e9600806420c73d1a7347e9b56844
https://github.com/lxc/lxc/commit/51c1b152914e9600806420c73d1a7347e9b56844
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8eaaad6223db38098eb2ecd98045b8d97e38f7c8
https://github.com/lxc/lxc/commit/8eaaad6223db38098eb2ecd98045b8d97e38f7c8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 94c0fbad008f97f9619cc0b320fd38281bad9889
https://github.com/lxc/lxc/commit/94c0fbad008f97f9619cc0b320fd38281bad9889
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup_utils.c
Log Message:
-----------
cgroups: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b52483990493acde21e00b2dd8d12bd422b18b53
https://github.com/lxc/lxc/commit/b52483990493acde21e00b2dd8d12bd422b18b53
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 265fcd2095d2752dad65eebe48ccabf4b663ba6d
https://github.com/lxc/lxc/commit/265fcd2095d2752dad65eebe48ccabf4b663ba6d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4e223d7d738f6a86e4a036477cb0118c1344de48
https://github.com/lxc/lxc/commit/4e223d7d738f6a86e4a036477cb0118c1344de48
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile_utils.c
Log Message:
-----------
confile_utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 03c1ae424ee578b9cb3bb38ddc1d911d1128484b
https://github.com/lxc/lxc/commit/03c1ae424ee578b9cb3bb38ddc1d911d1128484b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
Log Message:
-----------
file_utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ca473478b133331a67844e8609ed4c6f55ad293b
https://github.com/lxc/lxc/commit/ca473478b133331a67844e8609ed4c6f55ad293b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/freezer.c
Log Message:
-----------
freezer: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: de6f4f27f010e5128f814d1b560405d8c8aefc32
https://github.com/lxc/lxc/commit/de6f4f27f010e5128f814d1b560405d8c8aefc32
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lsm/apparmor.c
Log Message:
-----------
lsm: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1b1e50dbc93b23e76689a847e477fd0d1fb0f2a1
https://github.com/lxc/lxc/commit/1b1e50dbc93b23e76689a847e477fd0d1fb0f2a1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3721e645faa43586e1232211c1467740761d356e
https://github.com/lxc/lxc/commit/3721e645faa43586e1232211c1467740761d356e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/seccomp.c
Log Message:
-----------
seccomp: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 55056c255fdbd992baab0409bd0b8ed4d3da9e0e
https://github.com/lxc/lxc/commit/55056c255fdbd992baab0409bd0b8ed4d3da9e0e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: convert to strequal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8ae3e7d73316aa02f054891724bc80580d6d8359
https://github.com/lxc/lxc/commit/8ae3e7d73316aa02f054891724bc80580d6d8359
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/macro.h
M src/lxc/namespace.h
M src/lxc/start.c
M src/lxc/start.h
Log Message:
-----------
start: rework namespace preservation and path creation for hooks
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5eaa0cdecda6a129d4492136b94ba20db80d9e57
https://github.com/lxc/lxc/commit/5eaa0cdecda6a129d4492136b94ba20db80d9e57
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: expose namespace fd paths to network hooks
Closes: #3667
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f4c4affd0f268d5bcc5d0ec4ee079e1bf14abb5f
https://github.com/lxc/lxc/commit/f4c4affd0f268d5bcc5d0ec4ee079e1bf14abb5f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: fix error handling and improve comment
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 15ce8e6745883291def90a5fda91a3c0640dce0b
https://github.com/lxc/lxc/commit/15ce8e6745883291def90a5fda91a3c0640dce0b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: improve namespace preservation
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 965ee7a63548ed32062a203243a52611cc9a37d7
https://github.com/lxc/lxc/commit/965ee7a63548ed32062a203243a52611cc9a37d7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: improve comments
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3eb07143fde840e5e85e5a401589ae3c9d39d0ef
https://github.com/lxc/lxc/commit/3eb07143fde840e5e85e5a401589ae3c9d39d0ef
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: improve comment in lxc_spawn()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 645063e626d317fd8b028c0998c3dffbf4493096
https://github.com/lxc/lxc/commit/645063e626d317fd8b028c0998c3dffbf4493096
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/lsm/apparmor.c
M src/lxc/start.c
M src/lxc/utils.c
M src/lxc/utils.h
M src/tests/lxc_raw_clone.c
Log Message:
-----------
cgroups: move cgns_supported() to cgroup utilities
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 97988222283644d887c093dfa29caad62382b0e4
https://github.com/lxc/lxc/commit/97988222283644d887c093dfa29caad62382b0e4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: don't pass conf separately to lxc_mount_auto_mounts()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c915eca0e94768938676489ef6c199c7dcc29da7
https://github.com/lxc/lxc/commit/c915eca0e94768938676489ef6c199c7dcc29da7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/conf.c
Log Message:
-----------
cgroups: pass handler to cgroup mount() method
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 253990c25fd87d7ee867b11afada1ddaa6b45aff
https://github.com/lxc/lxc/commit/253990c25fd87d7ee867b11afada1ddaa6b45aff
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/start.h
Log Message:
-----------
cgroups: verify that we are actually running in cgroup namespace
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 29efc32d84a027749af5c4c8fec0dccff0ffe4bb
https://github.com/lxc/lxc/commit/29efc32d84a027749af5c4c8fec0dccff0ffe4bb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/log.h
Log Message:
-----------
cgroups: improve cgroup mounting
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0e587a5f75bf8690c42f1576b3de62336dc84f56
https://github.com/lxc/lxc/commit/0e587a5f75bf8690c42f1576b3de62336dc84f56
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
utils: add development helper to quickly dump a directories contents
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 33715994902c55ed8de047b1fde2899533a3410f
https://github.com/lxc/lxc/commit/33715994902c55ed8de047b1fde2899533a3410f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: make clear that a flag argument is passed to cgroup mount functions
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9167435367f3c5a86e612f9a36bbadcea3ed4200
https://github.com/lxc/lxc/commit/9167435367f3c5a86e612f9a36bbadcea3ed4200
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: don't strip LXC_AUTO_CGROUP_FORCE
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 950e7e151d1215c819ac9e9a949ede5890e2abf7
https://github.com/lxc/lxc/commit/950e7e151d1215c819ac9e9a949ede5890e2abf7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: switch to flag-based checking
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: db68e7e1e65352936e4db6449cae968bffd821c8
https://github.com/lxc/lxc/commit/db68e7e1e65352936e4db6449cae968bffd821c8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.h
Log Message:
-----------
conf: remove wrong comment
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b9716216a84359de0ee8090c6c23d287d8a88a17
https://github.com/lxc/lxc/commit/b9716216a84359de0ee8090c6c23d287d8a88a17
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: s/cg_mount_in_cgroup_namespace()/cgroupfs_mount()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7deb28345fe62cce20296b308e7e07a81cc085b8
https://github.com/lxc/lxc/commit/7deb28345fe62cce20296b308e7e07a81cc085b8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: s/cg_mount_cgroup_full()/cgroupfs_bind_mount()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d149d7ecf9be2ca11626379d94ec9d4fea749f89
https://github.com/lxc/lxc/commit/d149d7ecf9be2ca11626379d94ec9d4fea749f89
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: fix flag checking in legacy mount paths
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8c527d876a455647d98f1147241ea960b9a6c253
https://github.com/lxc/lxc/commit/8c527d876a455647d98f1147241ea960b9a6c253
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: strip LXC_AUTO_CGROUP_MIXED and LXC_AUTO_CGROUP_FULL_MIXED when cgroup namespaces are supported and used
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a12df67aa5a547735f249f34d6e499a3101158d7
https://github.com/lxc/lxc/commit/a12df67aa5a547735f249f34d6e499a3101158d7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: s/__cg_mount_direct()/__cgroupfs_mount()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e99ae0137abf1bc1a071a28490436f5b389a0b12
https://github.com/lxc/lxc/commit/e99ae0137abf1bc1a071a28490436f5b389a0b12
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: log early return
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 17e2e68535fdc588ecdf29aecca4981a10a57d11
https://github.com/lxc/lxc/commit/17e2e68535fdc588ecdf29aecca4981a10a57d11
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroupfs: rework cgroup2 mounting
We now explicitly refuse to mount cgroups on pure unified layouts when the
container is not running in a separate cgroup namespace. This is not a
regression since we simply always failed before anyway. I will likely fix this
very soon though. But there are bigger fish to fry currently.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c8f571922fca0198b08150ba86d279af12fa9ade
https://github.com/lxc/lxc/commit/c8f571922fca0198b08150ba86d279af12fa9ade
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: use set_config_path_item() for most cgroup layout modifiers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1cc1e2688de309c91a002b0994247e713e109492
https://github.com/lxc/lxc/commit/1cc1e2688de309c91a002b0994247e713e109492
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile_utils.c
Log Message:
-----------
confile_utils: normalize paths in config items
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9cfbddfa8bebae13eeb93adfc573f45fae12b8fb
https://github.com/lxc/lxc/commit/9cfbddfa8bebae13eeb93adfc573f45fae12b8fb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile.c
M src/lxc/log.h
M src/lxc/string_utils.h
Log Message:
-----------
confile: forbid walking upwards for confile items that modify cgroup layout
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a25037c06014ebf22065ae411e553212249b406d
https://github.com/lxc/lxc/commit/a25037c06014ebf22065ae411e553212249b406d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: s/cg_init()/__cgroup_init()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a0386cd21cd1306c5ed92b92170b956283ac2acb
https://github.com/lxc/lxc/commit/a0386cd21cd1306c5ed92b92170b956283ac2acb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
Log Message:
-----------
cgroups: stash host's cgroupfs file descriptor
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2de3b923c7cdb0744e8416208dbd8b9b9cb1e55b
https://github.com/lxc/lxc/commit/2de3b923c7cdb0744e8416208dbd8b9b9cb1e55b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: better document stashed file descriptors
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9314f8077f9c307b0d8e445fcb6629125f3ffd78
https://github.com/lxc/lxc/commit/9314f8077f9c307b0d8e445fcb6629125f3ffd78
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: rework add_hierarchy()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 98d92d9a99af7d7f6e76b48e7dfd632f7362226a
https://github.com/lxc/lxc/commit/98d92d9a99af7d7f6e76b48e7dfd632f7362226a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/string_utils.h
Log Message:
-----------
cgroups: rework base cgroup parsing
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8e29bab70f156f567993cbce2afc1ea8d7584199
https://github.com/lxc/lxc/commit/8e29bab70f156f567993cbce2afc1ea8d7584199
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile.c
Log Message:
-----------
confile: forbid absolute paths in config items that modify the cgroup layout
This is not a safety measure but merely is supposed to raise awareness that
these paths are always relative to the cgroup root as determined by
lxc.cgroup.relative.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 106ed15cd59085d0700bfeea627b9db0915d5149
https://github.com/lxc/lxc/commit/106ed15cd59085d0700bfeea627b9db0915d5149
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
Log Message:
-----------
cgroups: fail when no cgroup hierarchies are found
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8acaf48820ab23a4a9651ff835bc38880a01a4c7
https://github.com/lxc/lxc/commit/8acaf48820ab23a4a9651ff835bc38880a01a4c7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: stash fds for the controller mountpoint and base cgroup path
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b7b1e3a34ce28b01206c48227930ff83d399e7b6
https://github.com/lxc/lxc/commit/b7b1e3a34ce28b01206c48227930ff83d399e7b6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/file_utils.c
M src/lxc/log.h
Log Message:
-----------
cgroups: fd-based only cgroup creation
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5582532d3ef124aca5c7431fa41dbae038c996f7
https://github.com/lxc/lxc/commit/5582532d3ef124aca5c7431fa41dbae038c996f7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/file_utils.c
Log Message:
-----------
cgroups: rework legacy cpuset handling
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6d0834be9648daeb0edfbe33752d10f39a2a6ee4
https://github.com/lxc/lxc/commit/6d0834be9648daeb0edfbe33752d10f39a2a6ee4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: improve logging
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 102e9196c4b0352c8b06fb630f0bff23eedca656
https://github.com/lxc/lxc/commit/102e9196c4b0352c8b06fb630f0bff23eedca656
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/string_utils.c
Log Message:
-----------
string_utils: handle empty strings in must_make_path()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 47f56e941097093413510d68e9e89595ce6a5935
https://github.com/lxc/lxc/commit/47f56e941097093413510d68e9e89595ce6a5935
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: allow "" base cgroup paths
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 63a7a2aceea0ab1f36f7a660da01d48c1aae40c9
https://github.com/lxc/lxc/commit/63a7a2aceea0ab1f36f7a660da01d48c1aae40c9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup.c
Log Message:
-----------
cgroups: fix fd leaks
They didn't really matter because we want to keep them around for as long as
the container lives anyway.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1f7db633fd2dbf980a7b13b03e50cbb6d63ac347
https://github.com/lxc/lxc/commit/1f7db633fd2dbf980a7b13b03e50cbb6d63ac347
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: rework how hierarchies are added
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 99193529fe8d4e832e1ff183ed204d3b1503cf2c
https://github.com/lxc/lxc/commit/99193529fe8d4e832e1ff183ed204d3b1503cf2c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/namespace.h
Log Message:
-----------
namespace: add missing \0 terminator
Link: https://launchpadlibrarian.net/523195972/buildlog_ubuntu-groovy-ppc64el.lxc_1%3A4.0.6+master~20210215-1740-0ubuntu1~groovy_BUILDING.txt.gz
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 971c1e7c7a14a1eced6c31a780347e9bc98709d8
https://github.com/lxc/lxc/commit/971c1e7c7a14a1eced6c31a780347e9bc98709d8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: prevent double-close
Fixes: Coverity 1473183
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8f5357050ec37885ac4e434b7e1940491c3b49e1
https://github.com/lxc/lxc/commit/8f5357050ec37885ac4e434b7e1940491c3b49e1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
M src/lxc/file_utils.h
Log Message:
-----------
file_utils: move dup_cloexec() to header
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e2e4e44c85e3105b4c89d569775a47f9c461fc93
https://github.com/lxc/lxc/commit/e2e4e44c85e3105b4c89d569775a47f9c461fc93
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
M src/lxc/file_utils.h
Log Message:
-----------
cgroups: fd-only cgroup tree pruning
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f7cea123501a0dcbfd8f8e6bedd6989a01cf3411
https://github.com/lxc/lxc/commit/f7cea123501a0dcbfd8f8e6bedd6989a01cf3411
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: remove obsolote cgroup_tree handling
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e7fa53de51152d620182821d51c6ba362a28155c
https://github.com/lxc/lxc/commit/e7fa53de51152d620182821d51c6ba362a28155c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: s/openat()/open_at()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9c0e2c57d79fb9319e7bb3877e4b7eaec5fa6a0b
https://github.com/lxc/lxc/commit/9c0e2c57d79fb9319e7bb3877e4b7eaec5fa6a0b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: check correct variable
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 380facc9eac6f01bd6bf9d0bd67e9eb80725c8c6
https://github.com/lxc/lxc/commit/380facc9eac6f01bd6bf9d0bd67e9eb80725c8c6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: rework unified controller delegation
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4f2846409013816f1fe28e7cdadfa0571fef81fe
https://github.com/lxc/lxc/commit/4f2846409013816f1fe28e7cdadfa0571fef81fe
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/start.c
Log Message:
-----------
start: delegate than move into the target cgroup
This is a way more sensible model.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a5c543e7e1327f6b176f690d82a02acf5f93a614
https://github.com/lxc/lxc/commit/a5c543e7e1327f6b176f690d82a02acf5f93a614
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: reorder function arguments
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9d14f691c35fd655f5b532b7420f65781f6005f9
https://github.com/lxc/lxc/commit/9d14f691c35fd655f5b532b7420f65781f6005f9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: remove obsolote check
In the new layout we don't need to do this.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a291dc9ce249f760a70d4f15defdcab3b3f239bd
https://github.com/lxc/lxc/commit/a291dc9ce249f760a70d4f15defdcab3b3f239bd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: rework cgroup tree removal on creation failure
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5fb9efeba3afce25ea0ad0ef2e55ba777301eaa0
https://github.com/lxc/lxc/commit/5fb9efeba3afce25ea0ad0ef2e55ba777301eaa0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: ensure leaf cgroup is correctly pruned on creation failure
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5ff6d751f0cf65a0919560b260afa97f080ead26
https://github.com/lxc/lxc/commit/5ff6d751f0cf65a0919560b260afa97f080ead26
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: rework cgroup tree creation
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f5eccee122173773bc7a5fa424730acd4f8e345a
https://github.com/lxc/lxc/commit/f5eccee122173773bc7a5fa424730acd4f8e345a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: be stricter when creating payloads
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 14637407172be34339b960ca47c3a8ab3a7e1fac
https://github.com/lxc/lxc/commit/14637407172be34339b960ca47c3a8ab3a7e1fac
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: don't rely on absolute path
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 699919e6e64c5ea241fe9b710725f43bebb2e62d
https://github.com/lxc/lxc/commit/699919e6e64c5ea241fe9b710725f43bebb2e62d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: don't move pivot cgroup under the monitor's cgroup
Otherwise we will never be able to destroy the monitor's cgroup.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1a9fab99c5d956aaf9c4d57f6908ff1049f17e96
https://github.com/lxc/lxc/commit/1a9fab99c5d956aaf9c4d57f6908ff1049f17e96
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: ensure we don't remove cgroups we didn't create
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 192711f0ebe5b9d80490ce347864bcc9842b5db7
https://github.com/lxc/lxc/commit/192711f0ebe5b9d80490ce347864bcc9842b5db7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: ensure we prune the limit dir
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c46e18f53f9a9c50d25070eea9713765f50d9009
https://github.com/lxc/lxc/commit/c46e18f53f9a9c50d25070eea9713765f50d9009
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: simplify mount opening
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2e5d1172ad11674ff2550db742c2043325b2c3f9
https://github.com/lxc/lxc/commit/2e5d1172ad11674ff2550db742c2043325b2c3f9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: prevent NULL pointer deref
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0bdd81d92fbcc882051fdaf28983d144c11440c2
https://github.com/lxc/lxc/commit/0bdd81d92fbcc882051fdaf28983d144c11440c2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: log intermediate cleanup
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b7967f52bb24434cc0b4b86f433ac5ccd51c8a14
https://github.com/lxc/lxc/commit/b7967f52bb24434cc0b4b86f433ac5ccd51c8a14
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: distinguish between tmpfs and unified based cgroup layouts file descriptors
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3a72de501185eb4f959d738d8a72974166874784
https://github.com/lxc/lxc/commit/3a72de501185eb4f959d738d8a72974166874784
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: ensure that cgroup_root is initialized in legacy codepaths
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d6614b806a6b2abad80e1561e07ab96bfceb30d8
https://github.com/lxc/lxc/commit/d6614b806a6b2abad80e1561e07ab96bfceb30d8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: prevent cgroup mount type overwrite
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 16ed808675e2fb48e8a9ed5cf6941060b3d7a1e5
https://github.com/lxc/lxc/commit/16ed808675e2fb48e8a9ed5cf6941060b3d7a1e5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: validate that only a single cgroup mount type is set
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0679efa0896274a39619cadc3b1b9b2e93485587
https://github.com/lxc/lxc/commit/0679efa0896274a39619cadc3b1b9b2e93485587
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: use brackets to clarify check semantics
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4ab1d9a6c1d88f1ef2d71458400bbf50cc70b8dc
https://github.com/lxc/lxc/commit/4ab1d9a6c1d88f1ef2d71458400bbf50cc70b8dc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: use non-flag based checking now that we switched all codepaths over
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6194bad77c9c2f302ba0f6c9d533ff95b706370b
https://github.com/lxc/lxc/commit/6194bad77c9c2f302ba0f6c9d533ff95b706370b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: create controller directories if missing
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b9a9768c451279e2afa080d6d17a651981d1ba23
https://github.com/lxc/lxc/commit/b9a9768c451279e2afa080d6d17a651981d1ba23
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: make it extremely obvious that we're transitioning from a flag to a type
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3bb6756de1bcb21b39863886ddee350570520f29
https://github.com/lxc/lxc/commit/3bb6756de1bcb21b39863886ddee350570520f29
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: don't overwrite type
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5bd52b014db7726e4394c58d9a02275642d8e8bc
https://github.com/lxc/lxc/commit/5bd52b014db7726e4394c58d9a02275642d8e8bc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: fix error values
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4e771848a67ab00279538457deda8e8e6d4be2bd
https://github.com/lxc/lxc/commit/4e771848a67ab00279538457deda8e8e6d4be2bd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.c
Log Message:
-----------
utils: fix print_r() debugging helper
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c0fb6f36b315866915724e1f41f2edb24126f55f
https://github.com/lxc/lxc/commit/c0fb6f36b315866915724e1f41f2edb24126f55f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup.c
Log Message:
-----------
cgroups: free correct path
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e4f23a0f88f7657cf496ec819758bdb7520d5c21
https://github.com/lxc/lxc/commit/e4f23a0f88f7657cf496ec819758bdb7520d5c21
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: kill monitor_full_path
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e0542702d731db37e60fb2e90cbc5c6013fa2981
https://github.com/lxc/lxc/commit/e0542702d731db37e60fb2e90cbc5c6013fa2981
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
Log Message:
-----------
bpf: use cgroup fd directly instead of paths
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 789bf479cbb81ec966ecd25ca055c92d41529184
https://github.com/lxc/lxc/commit/789bf479cbb81ec966ecd25ca055c92d41529184
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.h
Log Message:
-----------
conf: introduce lxc_bpf_devices_rule_t type
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e490acc44f6acc570a122f94e8a758ff785e408d
https://github.com/lxc/lxc/commit/e490acc44f6acc570a122f94e8a758ff785e408d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
bpf: use return macros
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 54c17d39fad584887b5634e27ef9074aad7bf743
https://github.com/lxc/lxc/commit/54c17d39fad584887b5634e27ef9074aad7bf743
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
Log Message:
-----------
bpf: align struct initialization
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9b7d34a22c04b95589010e3a8f88e9121daa830f
https://github.com/lxc/lxc/commit/9b7d34a22c04b95589010e3a8f88e9121daa830f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
Log Message:
-----------
bpf: enable helpers to let caller replace existing bpf programs
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7708e2d272df8b74f5b1d508b9c22660cdadea13
https://github.com/lxc/lxc/commit/7708e2d272df8b74f5b1d508b9c22660cdadea13
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: make device cgroups semantics clearer
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 795313a6fb5a15e0dd38ecaddaf81b814fb14ce8
https://github.com/lxc/lxc/commit/795313a6fb5a15e0dd38ecaddaf81b814fb14ce8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: improve bpf device program handling
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 35cca0f8c1accd37b939eb49e26bf70d33260ce7
https://github.com/lxc/lxc/commit/35cca0f8c1accd37b939eb49e26bf70d33260ce7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
bpf: add helpers for better bpf device program management
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 72a27f0654a2fbd043756c106d63804880a6088c
https://github.com/lxc/lxc/commit/72a27f0654a2fbd043756c106d63804880a6088c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: improve bpf device program management
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b76873a51ec58294438be9e52de2efc3a1c50feb
https://github.com/lxc/lxc/commit/b76873a51ec58294438be9e52de2efc3a1c50feb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: improve bpf device program management
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a4ade8461b6bd9bc7198f18afb607b1b9348f7e0
https://github.com/lxc/lxc/commit/a4ade8461b6bd9bc7198f18afb607b1b9348f7e0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: replace bpf program on update
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 61a492b3e36cfed69028ad0837673bf9a90e52e4
https://github.com/lxc/lxc/commit/61a492b3e36cfed69028ad0837673bf9a90e52e4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: add swap helper
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2fa19f298fd08ae81f950504d77d035288f99852
https://github.com/lxc/lxc/commit/2fa19f298fd08ae81f950504d77d035288f99852
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
bpf: use __u32 not uint32_t
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6e43674706139dffb3cd56f50d220c616c998beb
https://github.com/lxc/lxc/commit/6e43674706139dffb3cd56f50d220c616c998beb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
Log Message:
-----------
bpf: don't close invalid fd, simply swap
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0b9ce041e7dfc9700b0583dda9dc33257a179cb9
https://github.com/lxc/lxc/commit/0b9ce041e7dfc9700b0583dda9dc33257a179cb9
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: rework bpf devices BPF_F_REPLACE codepath
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e1c8bab320e7cafc50abe3b837740b9e7aadc26c
https://github.com/lxc/lxc/commit/e1c8bab320e7cafc50abe3b837740b9e7aadc26c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
Log Message:
-----------
bpf: rework bpf_program_cgroup_detach()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 98a1d49f81b4fb9073c8747ec9097bf44148237e
https://github.com/lxc/lxc/commit/98a1d49f81b4fb9073c8747ec9097bf44148237e
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
bpf: handling missing defines
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 64aa4275adbc82cbfb1aa75ab996bfff5aea6ab8
https://github.com/lxc/lxc/commit/64aa4275adbc82cbfb1aa75ab996bfff5aea6ab8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
A src/include/bpf.h
A src/include/bpf_common.h
M src/lxc/Makefile.am
Log Message:
-----------
bpf: vendor bpf headers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6f5af027dad1cd03706aca462f2847de203aa744
https://github.com/lxc/lxc/commit/6f5af027dad1cd03706aca462f2847de203aa744
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M configure.ac
M src/lxc/api_extensions.h
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
Log Message:
-----------
cgroups: remove compile-time bpf support detection
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 277d80c5c55eb994ad1710f9d65cbdf7fd62d717
https://github.com/lxc/lxc/commit/277d80c5c55eb994ad1710f9d65cbdf7fd62d717
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
bpf: add and use bpf_cgroup_devices_attach() helper
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ca5c34f4564e2363ef803aabc5fec0ab3641a453
https://github.com/lxc/lxc/commit/ca5c34f4564e2363ef803aabc5fec0ab3641a453
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
Log Message:
-----------
bpf: let bpf_list_add_device() take the device list directly
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 741c4835d549bb2df418cda61d594591cab00b0a
https://github.com/lxc/lxc/commit/741c4835d549bb2df418cda61d594591cab00b0a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
Log Message:
-----------
bpf: fix return values in bpf_program_cgroup_attach()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: baadb3cd36a7d505c97aea0ac20a05f49e0cedb8
https://github.com/lxc/lxc/commit/baadb3cd36a7d505c97aea0ac20a05f49e0cedb8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/compiler.h
Log Message:
-----------
compiler: fix fallthrough attribute
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 021770b81f8b8d6f2a7b0b0daf72dccb3f20873a
https://github.com/lxc/lxc/commit/021770b81f8b8d6f2a7b0b0daf72dccb3f20873a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
Log Message:
-----------
bpf: rework live device cgroup update
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bf9d59e01918917af39a3b2f4b2dec4fa87bbfc4
https://github.com/lxc/lxc/commit/bf9d59e01918917af39a3b2f4b2dec4fa87bbfc4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lxccontainer.c
Log Message:
-----------
lxccontainer: fix reboot logging
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: de6dc23c39860e0f5aa1c60af4ac88f1927d3e6c
https://github.com/lxc/lxc/commit/de6dc23c39860e0f5aa1c60af4ac88f1927d3e6c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/memory_utils.h
Log Message:
-----------
memory_utils: add close_equal() and free_equal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2763000998728f1514f194d81f0da553d9b8a64b
https://github.com/lxc/lxc/commit/2763000998728f1514f194d81f0da553d9b8a64b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
Log Message:
-----------
cgroups: use close_equal() and free_equal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 021833dd100e7e3e5505b7805a155b6c26da96fb
https://github.com/lxc/lxc/commit/021833dd100e7e3e5505b7805a155b6c26da96fb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
Log Message:
-----------
bpf: prevent double-close
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e35d7545efb983cb2206a805299cc5826302a7fc
https://github.com/lxc/lxc/commit/e35d7545efb983cb2206a805299cc5826302a7fc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
bpf: make bpf_program_cgroup_attach() static
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 34c6d6d463c31f0bc5479230e6fe1cdeb9096d22
https://github.com/lxc/lxc/commit/34c6d6d463c31f0bc5479230e6fe1cdeb9096d22
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
bpf: simplify bpf (device) program freeing
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e0538d90ecc13d827039c1a5d9a4234eec861e62
https://github.com/lxc/lxc/commit/e0538d90ecc13d827039c1a5d9a4234eec861e62
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: use saner mode for console
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5842f3413f63f1cee69d5a6795dee3fb230cc450
https://github.com/lxc/lxc/commit/5842f3413f63f1cee69d5a6795dee3fb230cc450
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/start.c
Log Message:
-----------
start: fix non-daemonized and application containers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2ec2c3d24d1b4ac97593d93549e03868b82b263a
https://github.com/lxc/lxc/commit/2ec2c3d24d1b4ac97593d93549e03868b82b263a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: don't log garbage
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 38c072c1e28fbb3e61e4bba699f12358ccf3b752
https://github.com/lxc/lxc/commit/38c072c1e28fbb3e61e4bba699f12358ccf3b752
Author: Aleksa Sarai <cyphar at cyphar.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lsm/apparmor.c
Log Message:
-----------
apparmor: clean up apparmor_process_label_get
Rather than open-coding file reading and retry semantics and
implementing the path generation logic separately to
apparmor_process_label_fd_get, refactor the logic so that it looks
closer to the pidfd version.
This will make it easier to implement the two-step handling for
/proc/self/attr/apparmor/current and makes this code slightly less
confusing.
Signed-off-by: Aleksa Sarai <cyphar at cyphar.com>
Commit: 843e8d49d6f88af2cbc6807a0f76354678749782
https://github.com/lxc/lxc/commit/843e8d49d6f88af2cbc6807a0f76354678749782
Author: Aleksa Sarai <cyphar at cyphar.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lsm/apparmor.c
M src/lxc/macro.h
Log Message:
-----------
apparmor: prefer /proc/.../attr/apparmor/current over legacy interface
It turns out that since Linux 5.1 there are now per-LSM subdirectories
for major LSMs, which users are recommended to use over the "legacy"
top-level /proc/$pid/attr/... files[1]:
> Process attributes associated with “major” security modules should be
> accessed and maintained using the special files in /proc/.../attr. A
> security module may maintain a module specific subdirectory there,
> named after the module. /proc/.../attr/smack is provided by the Smack
> security module and contains all its special files. The files directly
> in /proc/.../attr remain as legacy interfaces for modules that provide
> subdirectories.
AppArmor has had such a directory since Linux 5.8[2], and it turns out
that with certain CONFIG_LSM configurations you can end up with AppArmor
files not being accessible from the legacy interface. Arch Linux
recently added BPF as one of the enabled LSM in their configuration, and
this broke runc[3] and LXC.
The solution is to first try to use /proc/$pid/attr/apparmor/current and
fall back to /proc/$pid/attr/current if the former is not available.
[1]: https://www.kernel.org/doc/html/latest/admin-guide/LSM/index.html
[2]: Linux 5.8 ; commit 6413f852ce08 ("apparmor: add proc subdir to attrs")
[3]: https://github.com/opencontainers/runc/issues/2801
Signed-off-by: Aleksa Sarai <cyphar at cyphar.com>
Commit: 580253dc8349093670b9780735963c05ec6cb7f6
https://github.com/lxc/lxc/commit/580253dc8349093670b9780735963c05ec6cb7f6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
Log Message:
-----------
file_utils: allow fd_to_buf() to fail for real
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 66beb49fa63dea3a202e604ae9769eb71f69b02d
https://github.com/lxc/lxc/commit/66beb49fa63dea3a202e604ae9769eb71f69b02d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/lsm/apparmor.c
Log Message:
-----------
lsm: twek apparmor_process_label_get()
Fixes: Coverity 1473189
Fixes: Coverity 1473190
Fixes: 47f4914d88df ("apparmor: prefer /proc/.../attr/apparmor/current over legacy interface")
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ef7abbad3af706f5089b111997174cb2d9b645b3
https://github.com/lxc/lxc/commit/ef7abbad3af706f5089b111997174cb2d9b645b3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: ensure no garbage is returned
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8b83db4601eed4eb817788f0fc488fcec28428a4
https://github.com/lxc/lxc/commit/8b83db4601eed4eb817788f0fc488fcec28428a4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/conf.h
Log Message:
-----------
cgroups: make device cgroup handling smarter and simpler
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b7444dfc22e5180a1a46bd324310f48b25f447fa
https://github.com/lxc/lxc/commit/b7444dfc22e5180a1a46bd324310f48b25f447fa
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
commands: only update bpf device program if really needed
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: aa86f2f3a04b4c170c0f544ed741b344cd63fec5
https://github.com/lxc/lxc/commit/aa86f2f3a04b4c170c0f544ed741b344cd63fec5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
Log Message:
-----------
bpf: comment bpf_cgroup_devices_update()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f3be4ec6edb1b99cbbc5d2d4d7660af151f0c5f6
https://github.com/lxc/lxc/commit/f3be4ec6edb1b99cbbc5d2d4d7660af151f0c5f6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
bpf: fix typos
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 64625bfff847cb7a116f65739977dc00dd632f97
https://github.com/lxc/lxc/commit/64625bfff847cb7a116f65739977dc00dd632f97
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
Log Message:
-----------
conf: improve lxc_clear_cgroups()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 43f34c0e6a369d19906d63cc1e27a7910e6394bd
https://github.com/lxc/lxc/commit/43f34c0e6a369d19906d63cc1e27a7910e6394bd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/conf.c
M src/lxc/conf.h
Log Message:
-----------
conf: expose lxc_clear_cgroup2_devices()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 25d20b90cf165123c76f4f968c198bf8fa0f8bd6
https://github.com/lxc/lxc/commit/25d20b90cf165123c76f4f968c198bf8fa0f8bd6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: tweak bpf_device_cgroup_prepare()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a0e788ab132e5c51506fe549c9f9dafcc511d6d8
https://github.com/lxc/lxc/commit/a0e788ab132e5c51506fe549c9f9dafcc511d6d8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/cgroups/cgroup2_devices.h
Log Message:
-----------
bpf: update device cgroup semantics
LXC has supported the bpf device controlller for a while now. A bpf device
program can be attached to the container's cgroup if this is a pure cgroup2
host.
The format for specifying device rules for the cgroup2 bpf device controller is
the same as for the legacy cgroup device controller; only the configuration key
prefix has to change. Specifically, device rules for the legacy cgroup device
controller are specified by via lxc.cgroup.devices.{allow,deny} whereas for the
cgroup2 bpf device controller lxc.cgroup2.devices.{allow,deny} must be used.
The following semantics apply:
1. The device rule "lxc.cgroup2.devices.deny = a" will cause LXC to instruct
the kernel to block access to all devices by default. To grant access to
devices "allow device rules" must be added via the
"lxc.cgroup2.devices.allow" key. This is referred to as a "allowlist" device
program.
2. The device rule "lxc.cgroup2.devices.allow = a" will cause LXC to instruct
the kernel to allow access to all devices by default. To deny access to
devices "deny device rules" must be added via "lxc.cgroup2.devices.deny"
key. This is referred to as a "denylist" device program.
3. Specifying a rule as explained in 1. or 2. will cause all previous rules to
be cleared, i.e. the device list will be reset.
For example the set of rules:
lxc.cgroup2.devices.deny = a
lxc.cgroup2.devices.allow = c *:* m
lxc.cgroup2.devices.allow = b *:* m
lxc.cgroup2.devices.allow = c 1:3 rwm
implements a "allowlist" device program, i.e. the kernel will block access to
all devices not specifically allowed in this list. This particular program
states that all character and block devices might be created but only /dev/null
might be read or written.
If we to switch to the set of rules to:
lxc.cgroup2.devices.allow = a
lxc.cgroup2.devices.deny = c *:* m
lxc.cgroup2.devices.deny = b *:* m
lxc.cgroup2.devices.deny = c 1:3 rwm
then LXC would instruct the kernel to implement a "denylist", i.e. the kernel
will allow access to all devices not specifically denied in this list. This
particular program states that no character devices or block devices might be
created and that /dev/null is not allow allowed to be read, written, or
created.
Consider the same program but followed by a rule as explained in 1. or 2.:
lxc.cgroup2.devices.allow = a
lxc.cgroup2.devices.deny = c *:* m
lxc.cgroup2.devices.deny = b *:* m
lxc.cgroup2.devices.deny = c 1:3 rwm
lxc.cgroup2.devices.allow = a
The last line will cause LXC to reset the device list without changing the type
of device program.
lxc.cgroup2.devices.allow = a
lxc.cgroup2.devices.deny = c *:* m
lxc.cgroup2.devices.deny = b *:* m
lxc.cgroup2.devices.deny = c 1:3 rwm
lxc.cgroup2.devices.deny = a
The last line will cause LXC to reset the device list and switch from a
"allowlist" program to a "denylist" program.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: fa72f54a5224ee8953109ff767b63136b1ed3c56
https://github.com/lxc/lxc/commit/fa72f54a5224ee8953109ff767b63136b1ed3c56
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M doc/lxc.container.conf.sgml.in
Log Message:
-----------
doc: add missing ".[controller file] suffix to lxc.cgroup{2}. key explanations
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 79b02f3895a89e5ed542141487b53abe47771627
https://github.com/lxc/lxc/commit/79b02f3895a89e5ed542141487b53abe47771627
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M doc/lxc.container.conf.sgml.in
Log Message:
-----------
doc: epxlain eBPF-based device controller semantics
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c65e4643d8b7eaccf614725f9048c23fbdb5bdbc
https://github.com/lxc/lxc/commit/c65e4643d8b7eaccf614725f9048c23fbdb5bdbc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M doc/lxc.container.conf.sgml.in
Log Message:
-----------
doc: tweak cgroup headline
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 71e50d54b4944c2075a68a7dc87d103e479efb23
https://github.com/lxc/lxc/commit/71e50d54b4944c2075a68a7dc87d103e479efb23
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/macro.h
M src/lxc/string_utils.h
Log Message:
-----------
string_utils: move lxc_iterate_parts()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5ad5ab8221051f0347231bfbb92386f2266f3fa8
https://github.com/lxc/lxc/commit/5ad5ab8221051f0347231bfbb92386f2266f3fa8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
Log Message:
-----------
cgroups: fix prune_init_scope()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: db34950a22954b51e689b646369f127dad8f61c4
https://github.com/lxc/lxc/commit/db34950a22954b51e689b646369f127dad8f61c4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: avoid additional variable for single access
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 42d193416933173d52f27eb50616a979dd00578b
https://github.com/lxc/lxc/commit/42d193416933173d52f27eb50616a979dd00578b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: s/must_copy_string()/strdup()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e3a953a6d4f08c26e2b9fe8565de98976ce33c05
https://github.com/lxc/lxc/commit/e3a953a6d4f08c26e2b9fe8565de98976ce33c05
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: tweak lxc.cgroup.use handling in __cgroup_init()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c41ab8e4498d26e8d8bcc049d90eb8c7087ac9e0
https://github.com/lxc/lxc/commit/c41ab8e4498d26e8d8bcc049d90eb8c7087ac9e0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: tweak return values
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 522bbc79c0d534b1c8083d4c0d3c862376ab5ea1
https://github.com/lxc/lxc/commit/522bbc79c0d534b1c8083d4c0d3c862376ab5ea1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: simplify current cgroup retrieval on pure unified cgroup layouts
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d7c8c13861172ee215228c27c1cdab9f9ca6f0ae
https://github.com/lxc/lxc/commit/d7c8c13861172ee215228c27c1cdab9f9ca6f0ae
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: s/basecginfo/cgroup_info/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bde8540b5160e15e7219f64c0cd70dd6076a3ea8
https://github.com/lxc/lxc/commit/bde8540b5160e15e7219f64c0cd70dd6076a3ea8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/compiler.h
Log Message:
-----------
compiler: add likely() and unlikely() support
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 75f08c85823ed8534b486bc6dd5c7e864c29f655
https://github.com/lxc/lxc/commit/75f08c85823ed8534b486bc6dd5c7e864c29f655
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: add pointer error encoding support
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 91fae3ab8ad6f3889895849777c68e6defc4364d
https://github.com/lxc/lxc/commit/91fae3ab8ad6f3889895849777c68e6defc4364d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/memory_utils.h
Log Message:
-----------
memory_utils: adapt to new pointer error macros
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bdc0a15a0f21e08cb851e7aacc644ae82bd04a7c
https://github.com/lxc/lxc/commit/bdc0a15a0f21e08cb851e7aacc644ae82bd04a7c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: split out unified cgroup helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0625dc061d435aab419ea7f71e0c9568f6ac3f2a
https://github.com/lxc/lxc/commit/0625dc061d435aab419ea7f71e0c9568f6ac3f2a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
Log Message:
-----------
cgroups: rework cgroup initialization
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 84cbd3308d47e7e85dd31eeaf0da081e35b99eaf
https://github.com/lxc/lxc/commit/84cbd3308d47e7e85dd31eeaf0da081e35b99eaf
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: simplify string list handling
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4af19a01b0fe771866438a7b007d25209af2a792
https://github.com/lxc/lxc/commit/4af19a01b0fe771866438a7b007d25209af2a792
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/log.h
Log Message:
-----------
cgroups: split delegation checks into separate helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 588b1d3bd7a9cfad95dbe79bc845c2644b1a069b
https://github.com/lxc/lxc/commit/588b1d3bd7a9cfad95dbe79bc845c2644b1a069b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: s/add_hierarchy()/cgroup_hierarchy_add()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cd5d966fb1bc1fd6e9ce67da443b8d02ed4fd270
https://github.com/lxc/lxc/commit/cd5d966fb1bc1fd6e9ce67da443b8d02ed4fd270
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup_utils.c
M src/lxc/cgroups/cgroup_utils.h
Log Message:
-----------
cgroups: remove unused helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a7f83fb05a3e46bcb22c47eebac88e20bf756878
https://github.com/lxc/lxc/commit/a7f83fb05a3e46bcb22c47eebac88e20bf756878
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: introduce cgroup hierarchy type
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 540b8aefdaabf9af4bbda4e1a2182c26b20593f7
https://github.com/lxc/lxc/commit/540b8aefdaabf9af4bbda4e1a2182c26b20593f7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: simplify and fix mounting on non-cgroup namespace aware kernels
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 02ca9e8816813b7041bc1a8915be7e6467c9a1fd
https://github.com/lxc/lxc/commit/02ca9e8816813b7041bc1a8915be7e6467c9a1fd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: rename cgroupfs mount fd
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1dda4cbfb5c94ac4e2d3a9b649037a6651747e43
https://github.com/lxc/lxc/commit/1dda4cbfb5c94ac4e2d3a9b649037a6651747e43
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: s/container_base_path/at_base/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9e1d2b770d9e4d0304fd8d8ccf15f96754c0570c
https://github.com/lxc/lxc/commit/9e1d2b770d9e4d0304fd8d8ccf15f96754c0570c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: s/mountpoint/at_mnt/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 946d7eee0a066e5e10ccf2891c64245bd22c2e6f
https://github.com/lxc/lxc/commit/946d7eee0a066e5e10ccf2891c64245bd22c2e6f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
Log Message:
-----------
cgroups: s/cgfd_con/dfd_con/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1116fcb321f41ebe4665ffcb8ed703d2adb19162
https://github.com/lxc/lxc/commit/1116fcb321f41ebe4665ffcb8ed703d2adb19162
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: s/cgfd_mon/dfd_mon/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f0c8014db41be0c27794758c707ece33fe0cb5ce
https://github.com/lxc/lxc/commit/f0c8014db41be0c27794758c707ece33fe0cb5ce
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
Log Message:
-----------
cgroups: s/cgfd_limit/dfd_lim/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 799220021ae94d11994d751b3e965044c4c183cf
https://github.com/lxc/lxc/commit/799220021ae94d11994d751b3e965044c4c183cf
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: s/container_full_path/path_con/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: eb5c37e7312e6a33e14f35fc827432010da42989
https://github.com/lxc/lxc/commit/eb5c37e7312e6a33e14f35fc827432010da42989
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: s/container_limit_path/path_lim/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1e84a70d4e9e59c85eb49f9725a2e620c8c7fa25
https://github.com/lxc/lxc/commit/1e84a70d4e9e59c85eb49f9725a2e620c8c7fa25
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: move cgroup2 parameters into substruct
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1845710fabbbdc095c578fd6ab383c07a9472e8f
https://github.com/lxc/lxc/commit/1845710fabbbdc095c578fd6ab383c07a9472e8f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: s/cgroup2_chown/delegate/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 780684e4f3774e9a8a5068916eb74c85e41294e2
https://github.com/lxc/lxc/commit/780684e4f3774e9a8a5068916eb74c85e41294e2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: improve utility controller handling
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f8109de7646ba40581aac6ff3d793265d52d1490
https://github.com/lxc/lxc/commit/f8109de7646ba40581aac6ff3d793265d52d1490
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
Log Message:
-----------
file_utils: tweak lxc_write_openat()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 028afdc3231c4bdf68f84d18867ad0fc2865d187
https://github.com/lxc/lxc/commit/028afdc3231c4bdf68f84d18867ad0fc2865d187
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: fix cg_legacy_freeze() return type
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bf90d192a53b1d940a42ef0343174933b4264534
https://github.com/lxc/lxc/commit/bf90d192a53b1d940a42ef0343174933b4264534
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: handle lxc.cgroup.use global parameter
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bc70d14ef149e75572c8731a7d7b944a3266cc18
https://github.com/lxc/lxc/commit/bc70d14ef149e75572c8731a7d7b944a3266cc18
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/memory_utils.h
Log Message:
-----------
memory_utils: fix close_equal()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2589ad72faf557cf88b8545209ba39ad149be908
https://github.com/lxc/lxc/commit/2589ad72faf557cf88b8545209ba39ad149be908
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: skip and warn about invalid file descriptors
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d70122bc7abf20d8d8faead8e671b7bd5e2b4005
https://github.com/lxc/lxc/commit/d70122bc7abf20d8d8faead8e671b7bd5e2b4005
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: start stashing all fds
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a7931a4dc4ea6bb42e62a709d4c860341dfaea84
https://github.com/lxc/lxc/commit/a7931a4dc4ea6bb42e62a709d4c860341dfaea84
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/start.c
Log Message:
-----------
cgroups: close dfd_mon but keep dfd_con and dfd_lim open for all cgroup hierarchies
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7921a8235a1908a90e0b6ad8110151b476bf8c48
https://github.com/lxc/lxc/commit/7921a8235a1908a90e0b6ad8110151b476bf8c48
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.h
Log Message:
-----------
commands: explicitly number enums
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ba9f37a52a9bec3d44f8f2eec3f6a096545db63c
https://github.com/lxc/lxc/commit/ba9f37a52a9bec3d44f8f2eec3f6a096545db63c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: tweak validate_string_request()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9ee81bc4543cf3448ea11ce348fea86df5849515
https://github.com/lxc/lxc/commit/9ee81bc4543cf3448ea11ce348fea86df5849515
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/af_unix.c
M src/lxc/af_unix.h
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/seccomp.c
M src/lxc/start.c
Log Message:
-----------
af_unix: improve SCM_RIGHTS file descriptor retrieval
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 51f11dfb590b84847318242e28c68a09b8ec9c80
https://github.com/lxc/lxc/commit/51f11dfb590b84847318242e28c68a09b8ec9c80
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: add cgroup_fds() helper
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c4133ca171c726ca6b4d8c462436c7eb02e8bbe2
https://github.com/lxc/lxc/commit/c4133ca171c726ca6b4d8c462436c7eb02e8bbe2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/state.c
Log Message:
-----------
state: _never_ return NULL from lxc_state2str()
Cc: Thomas Parrott <thomas.parrott at canonical.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c1069ae56d7b0d6d6725ff5260a668ab56eed54c
https://github.com/lxc/lxc/commit/c1069ae56d7b0d6d6725ff5260a668ab56eed54c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: be more explicit during command processing
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 35718bd4d58853a739263eb69b22aa93d2637822
https://github.com/lxc/lxc/commit/35718bd4d58853a739263eb69b22aa93d2637822
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: introduce lxc_cmd_rsp_send_reap()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 49fbd9fac6f569239670ad820f01b4148f02b1f7
https://github.com/lxc/lxc/commit/49fbd9fac6f569239670ad820f01b4148f02b1f7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: introduce rsp_one_fd()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 089f3f30b1731be9807872d712a11992b89c73df
https://github.com/lxc/lxc/commit/089f3f30b1731be9807872d712a11992b89c73df
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: introduce rsp_many_fds()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b1b140aa1c24bc290831ab3141c20159c8b9b745
https://github.com/lxc/lxc/commit/b1b140aa1c24bc290831ab3141c20159c8b9b745
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
Log Message:
-----------
commands: add LXC_CMD_GET_CGROUP_FD
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 79d9c3af6ced72e2d2fbe18e1d136668c96217e1
https://github.com/lxc/lxc/commit/79d9c3af6ced72e2d2fbe18e1d136668c96217e1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c
Log Message:
-----------
cgroups: allow cgroup fd batch retrieval
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8302a79b1518e6a1664bde59ff1ba2bad1cd71ac
https://github.com/lxc/lxc/commit/8302a79b1518e6a1664bde59ff1ba2bad1cd71ac
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: add min() macro
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 40f99fdc6cc96dfde24436fb5d82e0f50ad4fcac
https://github.com/lxc/lxc/commit/40f99fdc6cc96dfde24436fb5d82e0f50ad4fcac
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.h
Log Message:
-----------
utils: add copy_struct_from_client()
Which is our variant of copy_struct_from_user() that Aleksa and I added to the
kernel.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: aa659ba5478d6982088701cf08cc65b6fb56f6cc
https://github.com/lxc/lxc/commit/aa659ba5478d6982088701cf08cc65b6fb56f6cc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/log.h
Log Message:
-----------
log: add syswarn_set()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 89b2bfaa0fb88f6102bf60a561e071138ef9fc29
https://github.com/lxc/lxc/commit/89b2bfaa0fb88f6102bf60a561e071138ef9fc29
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/utils.h
Log Message:
-----------
utils: add copy_struct_to_client()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b106d22f85656daf4d8e1d7423f8a91f902851a5
https://github.com/lxc/lxc/commit/b106d22f85656daf4d8e1d7423f8a91f902851a5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
M src/lxc/commands.h
Log Message:
-----------
commands: introduce LXC_CMD_GET_CGROUP_CTX
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e040efb6dc8739d4340e0528641771be52d2cd0b
https://github.com/lxc/lxc/commit/e040efb6dc8739d4340e0528641771be52d2cd0b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: introduce fd-only cgroup attach
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d11103540236ac8d71b1f7bfb388c2253bf33655
https://github.com/lxc/lxc/commit/d11103540236ac8d71b1f7bfb388c2253bf33655
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: send ENOSYS response
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d8c81a7c383311021c614ed8379c8dddd38bf2c5
https://github.com/lxc/lxc/commit/d8c81a7c383311021c614ed8379c8dddd38bf2c5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: handle older clients elegantly
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 87834acf2b25e98bfc014801c28f09d49ba4d869
https://github.com/lxc/lxc/commit/87834acf2b25e98bfc014801c28f09d49ba4d869
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: lxc_cmd_add_state_client_callback()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: c6062fcd44cb2b65e05e2784fcde3f12e182fac2
https://github.com/lxc/lxc/commit/c6062fcd44cb2b65e05e2784fcde3f12e182fac2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: fix unsupported namespaces
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e5acb39db421ffacf213e9644e8c396bb8addbb6
https://github.com/lxc/lxc/commit/e5acb39db421ffacf213e9644e8c396bb8addbb6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/af_unix.c
Log Message:
-----------
af_unix: add comment about cast
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: abe00764caa448da2688ba4b242ec067bc0f7f47
https://github.com/lxc/lxc/commit/abe00764caa448da2688ba4b242ec067bc0f7f47
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: remove additional newline
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cdc2c87112246e530b1f9b346e4e6cecfdea3a96
https://github.com/lxc/lxc/commit/cdc2c87112246e530b1f9b346e4e6cecfdea3a96
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: handle older clients gracefully
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: aeadb8f50183d7d9fa96e026ad0922ee1cf77461
https://github.com/lxc/lxc/commit/aeadb8f50183d7d9fa96e026ad0922ee1cf77461
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: verify expected file descriptors were sent
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2c8089b49acb1699d05ee22717f6376c6fe7b89f
https://github.com/lxc/lxc/commit/2c8089b49acb1699d05ee22717f6376c6fe7b89f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: fix namespace preservation
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 80f07b8b0a2bf94b4e76649e8f338c65596ed1db
https://github.com/lxc/lxc/commit/80f07b8b0a2bf94b4e76649e8f338c65596ed1db
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/terminal.c
Log Message:
-----------
terminal: dumb logging down
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ce35e2440e662350704bd8f1d09268a4a9310ee4
https://github.com/lxc/lxc/commit/ce35e2440e662350704bd8f1d09268a4a9310ee4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/sync.h
Log Message:
-----------
attach: make fd sending more uniform
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 490265b1a799cc20f4928d5bb0431e98377c602b
https://github.com/lxc/lxc/commit/490265b1a799cc20f4928d5bb0431e98377c602b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: handle new and old clients
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8a1731626dd2642fd2f12b0e090f67457e888187
https://github.com/lxc/lxc/commit/8a1731626dd2642fd2f12b0e090f67457e888187
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: handle old clients for LXC_CMD_GET_CGROUP_CTX
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 90b9b14c842624fe02f66de456cf13a4440fcf04
https://github.com/lxc/lxc/commit/90b9b14c842624fe02f66de456cf13a4440fcf04
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: only deref once
Fixes: Coverity 1473308
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 82ba06f6a254c2e797c4f8423ff7c287ee961a14
https://github.com/lxc/lxc/commit/82ba06f6a254c2e797c4f8423ff7c287ee961a14
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/af_unix.c
Log Message:
-----------
af_unix: prevent oob writes
Fixes: Coverity 1473309
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a23ad648bfb804284fd31dcef6f8fbb29b9984f5
https://github.com/lxc/lxc/commit/a23ad648bfb804284fd31dcef6f8fbb29b9984f5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: fix error checking
Fixes: Coverity 1473310
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 56cf060ce501536cf31172003687760c31d7906b
https://github.com/lxc/lxc/commit/56cf060ce501536cf31172003687760c31d7906b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.h
Log Message:
-----------
commands: remove faulty use of access attribute
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2fe672bb484144258fb043410efb7c75e36e35ff
https://github.com/lxc/lxc/commit/2fe672bb484144258fb043410efb7c75e36e35ff
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: fix braino during controller list creation
Co-mounted controllers are conventionally separated by ",".
Fixes: https://jenkins.linuxcontainers.org/job/lxd-github-commit/1905/arch=amd64,backend=dir,compiler=golang-1.15/consoleFull
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f7103f3b12ede287c9d911dc32dfb355c8ded31c
https://github.com/lxc/lxc/commit/f7103f3b12ede287c9d911dc32dfb355c8ded31c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
Log Message:
-----------
attach: be paranoid about file descriptors
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 976faade315d0a85e2e8284f8d3676e9aea1edce
https://github.com/lxc/lxc/commit/976faade315d0a85e2e8284f8d3676e9aea1edce
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: simple variable reordering
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f3aca94f78e2f655fcb6620f39073f366764d3fb
https://github.com/lxc/lxc/commit/f3aca94f78e2f655fcb6620f39073f366764d3fb
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/Makefile.am
M src/lxc/cgroups/cgfsng.c
A src/lxc/error_utils.h
M src/lxc/macro.h
M src/lxc/memory_utils.h
Log Message:
-----------
error_utils: move error helper to separate header
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 870a288c1f398f97ee9ec66677ad043151a988e5
https://github.com/lxc/lxc/commit/870a288c1f398f97ee9ec66677ad043151a988e5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: tweak return values
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0e48c43b41157177f1b64d70d291e33642c71116
https://github.com/lxc/lxc/commit/0e48c43b41157177f1b64d70d291e33642c71116
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/error_utils.h
Log Message:
-----------
error_utils: copy over Lennart's IN_SET()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 1274eb5c2239a16b48bd8c6dbab64f1b6aec71d8
https://github.com/lxc/lxc/commit/1274eb5c2239a16b48bd8c6dbab64f1b6aec71d8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
Log Message:
-----------
cgroups: make use of ERRNO_IS_NOT_SUPPORTED()
This will hopefully prevent backwards compatibility fallback errors.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 292f998534d3bebdfbc91c6d84c848d493af48ba
https://github.com/lxc/lxc/commit/292f998534d3bebdfbc91c6d84c848d493af48ba
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/lxccontainer.c
Log Message:
-----------
cgroups: handle fallback gracefully
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a4e04834a7a3227990d79e74b7494e8f74336600
https://github.com/lxc/lxc/commit/a4e04834a7a3227990d79e74b7494e8f74336600
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: fix alignment for lxc_cmd_get_cgroup_ctx()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: dd65d42a7080d8901aff1c3716f279ca50f3de68
https://github.com/lxc/lxc/commit/dd65d42a7080d8901aff1c3716f279ca50f3de68
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c
M src/lxc/commands.h
Log Message:
-----------
commands: simplify lxc_cmd_get_cgroup_ctx()
Instead of allowing individual hierarchy fd retrieval through
lxc_cmd_get_cgroup_ctx() let's add a dedicated method instead.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cfd0e3b5211dc52a29dd437b7ff1f90846c870be
https://github.com/lxc/lxc/commit/cfd0e3b5211dc52a29dd437b7ff1f90846c870be
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/criu.c
Log Message:
-----------
commands: s/_LIMITING_/_LIMIT_/g and s/_limiting_/_limit_/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d5d3ed2705142f6920b1bebb468824cd99e74e94
https://github.com/lxc/lxc/commit/d5d3ed2705142f6920b1bebb468824cd99e74e94
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
Log Message:
-----------
commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7c16820e913c110791cc49a332baed385d733e82
https://github.com/lxc/lxc/commit/7c16820e913c110791cc49a332baed385d733e82
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
Log Message:
-----------
cgroups: s/cgroup_layout/layout/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9bfcfda59a5e9f07fce027b50b4880549ec5317b
https://github.com/lxc/lxc/commit/9bfcfda59a5e9f07fce027b50b4880549ec5317b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: set rsp.ret to 0 for lxc_cmd_get_cgroup_ctx_callback()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 236f417565f8a4d3c691b560558ee16e05b83da1
https://github.com/lxc/lxc/commit/236f417565f8a4d3c691b560558ee16e05b83da1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/file_utils.c
Log Message:
-----------
file_utils: actually open the file for reading
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5d8caeb9946e4c5a97d92d62296982bcf694cf7f
https://github.com/lxc/lxc/commit/5d8caeb9946e4c5a97d92d62296982bcf694cf7f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: extend rsp_one_fd() to also handle additional data
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3975ef41d2ef2d8236b7f36ac670b5d2dcf60d0f
https://github.com/lxc/lxc/commit/3975ef41d2ef2d8236b7f36ac670b5d2dcf60d0f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup.h
M src/lxc/commands.c
M src/lxc/commands.h
Log Message:
-----------
commands: add LXC_CMD_GET_CGROUP_FD and LXC_CMD_GET_LIMIT_CGROUP_FD
and port cgroup_get() and cgroup_set(). This means no more useless cgroup
driver initialization on ever get or set.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9e6c8fefa4f569dfe560a3f68bae3d685096aabf
https://github.com/lxc/lxc/commit/9e6c8fefa4f569dfe560a3f68bae3d685096aabf
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/terminal.c
Log Message:
-----------
commands: s/LXC_CMD_CONSOLE/LXC_CMD_GET_TTY_FD/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 8b1e889b5c375645ee60faee420d2c5c7829873a
https://github.com/lxc/lxc/commit/8b1e889b5c375645ee60faee420d2c5c7829873a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: annotate array argument
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: a8da63884395f96eb95f2509d016940134d4c755
https://github.com/lxc/lxc/commit/a8da63884395f96eb95f2509d016940134d4c755
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/compiler.h
Log Message:
-----------
commands: ensure that non-NULL and MAX_STATE is always passed
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f5e5857c30d5d6793bccc09eb5e551e57c0d400c
https://github.com/lxc/lxc/commit/f5e5857c30d5d6793bccc09eb5e551e57c0d400c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: use IN_SET() in lxc_cmd()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 466cff4088d21f9fea7071881227e399e5de6ac3
https://github.com/lxc/lxc/commit/466cff4088d21f9fea7071881227e399e5de6ac3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: switch to bool
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f5e3cb95b52d2d290d38b903b6c00c274a486de1
https://github.com/lxc/lxc/commit/f5e3cb95b52d2d290d38b903b6c00c274a486de1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
M src/lxc/start.c
Log Message:
-----------
commands: s/lxc_cmd_init()/lxc_server_init()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0db9791162f1817a6a4624a506407c02937eb2e7
https://github.com/lxc/lxc/commit/0db9791162f1817a6a4624a506407c02937eb2e7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.h
Log Message:
-----------
commands: add lxc_cmd_init() and lxc_cmd_data()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: caa0d614cd14a0832fc40b86d71904090311625f
https://github.com/lxc/lxc/commit/caa0d614cd14a0832fc40b86d71904090311625f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_try_cmd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 16c5c428a37ee5b8ea46b071239d416b4765693f
https://github.com/lxc/lxc/commit/16c5c428a37ee5b8ea46b071239d416b4765693f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_init_pid() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6d13e0fcdf9847e22d77792f12184da4055aa386
https://github.com/lxc/lxc/commit/6d13e0fcdf9847e22d77792f12184da4055aa386
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_init_pidfd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d2c73154975e17139559cfa73f7de571a9d9bbd2
https://github.com/lxc/lxc/commit/d2c73154975e17139559cfa73f7de571a9d9bbd2
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_devpts_fd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 06176031507a000b62696ca211efb9317108959f
https://github.com/lxc/lxc/commit/06176031507a000b62696ca211efb9317108959f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_seccomp_notify_fd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3f3ba90ce19c5bfebff98d79cf0f6e18fc6c99e8
https://github.com/lxc/lxc/commit/3f3ba90ce19c5bfebff98d79cf0f6e18fc6c99e8
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_cgroup_ctx() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 19ed9e7427661000ae144a2023636dafbc87bff7
https://github.com/lxc/lxc/commit/19ed9e7427661000ae144a2023636dafbc87bff7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_clone_flags() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 9e6dda991ff3aa9ce28268b8b0ae698cb3ce48d6
https://github.com/lxc/lxc/commit/9e6dda991ff3aa9ce28268b8b0ae698cb3ce48d6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
Log Message:
-----------
commands: portlxc_cmd_get_cgroup_path_do() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e003f52c6098a1f6192c06833cd17425b94b1328
https://github.com/lxc/lxc/commit/e003f52c6098a1f6192c06833cd17425b94b1328
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_config_item() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0079b0a0082b967cc1d4fc0ded5a7b1f979fb19a
https://github.com/lxc/lxc/commit/0079b0a0082b967cc1d4fc0ded5a7b1f979fb19a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_state() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ccb999b44610d1caacfdf2e0916ff7b83e8109d3
https://github.com/lxc/lxc/commit/ccb999b44610d1caacfdf2e0916ff7b83e8109d3
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_stop() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7cab48065d0025affe5d4d9b8b54e724e9c0df7b
https://github.com/lxc/lxc/commit/7cab48065d0025affe5d4d9b8b54e724e9c0df7b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_get_tty_fd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 061a13d5e0210ad84b54975bc58d716c8b3548d1
https://github.com/lxc/lxc/commit/061a13d5e0210ad84b54975bc58d716c8b3548d1
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_name() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0c305a36d722bd48ec5ca739afc9311bf6a44f1a
https://github.com/lxc/lxc/commit/0c305a36d722bd48ec5ca739afc9311bf6a44f1a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_lxcpath() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7c9845b0a47ab65b59d88043e797e765d9ef9d88
https://github.com/lxc/lxc/commit/7c9845b0a47ab65b59d88043e797e765d9ef9d88
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_add_state_client() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7d1fe1ffb35bd96c15440ad540f50c294dab4642
https://github.com/lxc/lxc/commit/7d1fe1ffb35bd96c15440ad540f50c294dab4642
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_add_bpf_device_cgropu() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 398daa67932bfde0c7fe8465c617d64734f44f1a
https://github.com/lxc/lxc/commit/398daa67932bfde0c7fe8465c617d64734f44f1a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_console_log() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: cca8af9541483fb29ff74c2191b07b24707fe4f5
https://github.com/lxc/lxc/commit/cca8af9541483fb29ff74c2191b07b24707fe4f5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_serve_state_clients() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 14f3459dbb2b62dc7c829b72f22dfb766f064eff
https://github.com/lxc/lxc/commit/14f3459dbb2b62dc7c829b72f22dfb766f064eff
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_seccomp_notify_add_listener() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7d50148f37792a4f82504f6a4129952d173cc1c7
https://github.com/lxc/lxc/commit/7d50148f37792a4f82504f6a4129952d173cc1c7
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_freeze() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: da9f66730d7441e1efb9d729472ac1d6f32a7308
https://github.com/lxc/lxc/commit/da9f66730d7441e1efb9d729472ac1d6f32a7308
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_unfreeze() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 5778f5eda91a08497733baafe44506814a0696b0
https://github.com/lxc/lxc/commit/5778f5eda91a08497733baafe44506814a0696b0
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_cgroup_fd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 62e43787e3e75eb9ef621127372a95c93cd90500
https://github.com/lxc/lxc/commit/62e43787e3e75eb9ef621127372a95c93cd90500
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_limit_cgroup_fd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: b4705356d6f7217b27ab198742725d17613244c6
https://github.com/lxc/lxc/commit/b4705356d6f7217b27ab198742725d17613244c6
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_cgroup2_fd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d3ca938caa2e785b4d7638b77d6520ba96b649bc
https://github.com/lxc/lxc/commit/d3ca938caa2e785b4d7638b77d6520ba96b649bc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port lxc_cmd_get_limit_cgroup2_fd() to new helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 3f9e72d441b8fcf362bed453fef486cb99f714c4
https://github.com/lxc/lxc/commit/3f9e72d441b8fcf362bed453fef486cb99f714c4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: let lxc_cmd() return ssize_t to indicate that it returns not just 0 on success
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bfc5e1ebbf2b9cebedddc653f502d1dfc31fda89
https://github.com/lxc/lxc/commit/bfc5e1ebbf2b9cebedddc653f502d1dfc31fda89
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/macro.h
Log Message:
-----------
macro: add hweight*() helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e81cdd76b7d732af7bea9a7149f03f0b2b4dcf54
https://github.com/lxc/lxc/commit/e81cdd76b7d732af7bea9a7149f03f0b2b4dcf54
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/af_unix.c
M src/lxc/af_unix.h
Log Message:
-----------
af_unix: allow caller and callee to negotiate expectations and reality
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 333ad9a8636bae693af4b4cb93888a378adb4680
https://github.com/lxc/lxc/commit/333ad9a8636bae693af4b4cb93888a378adb4680
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
M src/lxc/log.h
Log Message:
-----------
commands: rework lxc_cmd_rsp_recv() to make it more obvious
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d226dba36040d36129b6816140aae700035a0390
https://github.com/lxc/lxc/commit/d226dba36040d36129b6816140aae700035a0390
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
M src/lxc/commands.h
Log Message:
-----------
commands: improve lxc_cmd_get_tty_fd()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7f74eb8dc6a8b334d55d57c0fbc965e2e8b4c93d
https://github.com/lxc/lxc/commit/7f74eb8dc6a8b334d55d57c0fbc965e2e8b4c93d
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/tests/lxc-test-lxc-attach
M src/tests/lxc-test-unpriv
Log Message:
-----------
tests: add logging to lxc-test-lxc-attach
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: ed8db38b0d70b3972bcabbd2d6a1305046b6b110
https://github.com/lxc/lxc/commit/ed8db38b0d70b3972bcabbd2d6a1305046b6b110
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/log.h
Log Message:
-----------
log: add some more log and return helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0514b77d593fba07cf5bb5df0f4b48954316da8b
https://github.com/lxc/lxc/commit/0514b77d593fba07cf5bb5df0f4b48954316da8b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: use debug logging
It is fine to fail these commands when a new client talks to an old server or
the kernel doesn't support the necessary features.
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 6b6d770cf72c372c5d5b6442b0d5399c24cdaa5c
https://github.com/lxc/lxc/commit/6b6d770cf72c372c5d5b6442b0d5399c24cdaa5c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: port misnamed functions to general style
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 103607f877185756a2708cd10d3be12f937e27f5
https://github.com/lxc/lxc/commit/103607f877185756a2708cd10d3be12f937e27f5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: send ENOSYS response
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 63b621ff094f6924f4795a08e21623e3a61d0edc
https://github.com/lxc/lxc/commit/63b621ff094f6924f4795a08e21623e3a61d0edc
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: s/_LIMITING_/_LIMIT_/g and s/_limiting_/_limit_/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 580772d3b9284ad14b72490632521c7d7e3bea48
https://github.com/lxc/lxc/commit/580772d3b9284ad14b72490632521c7d7e3bea48
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: cleanup error handling and variable naming
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 58fa1db03b2b968a4d2cdd80e349bf87b7e12e2c
https://github.com/lxc/lxc/commit/58fa1db03b2b968a4d2cdd80e349bf87b7e12e2c
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: rsp_one_fd_{reap,keep}() and rsp_many_fds_reap()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: e11802606e3c87ffd8e0230b13bec3ea60384c7f
https://github.com/lxc/lxc/commit/e11802606e3c87ffd8e0230b13bec3ea60384c7f
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: fix indentation
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 37fe510adc0283ece33a0f7f11c9d804454f63bd
https://github.com/lxc/lxc/commit/37fe510adc0283ece33a0f7f11c9d804454f63bd
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
Log Message:
-----------
commands: unify fd retrieval commands
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 85df9412d89fe38713af8394e3d7736d53561794
https://github.com/lxc/lxc/commit/85df9412d89fe38713af8394e3d7736d53561794
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/af_unix.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/confile.c
M src/lxc/log.h
Log Message:
-----------
tree-wide: s/syerrno_set()/syserror_set()/g
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 44cc163816b431fb61acccee5f74fa847239b868
https://github.com/lxc/lxc/commit/44cc163816b431fb61acccee5f74fa847239b868
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/af_unix.c
M src/lxc/attach.c
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/conf.c
M src/lxc/confile_utils.c
Log Message:
-----------
tree-wide: start replacing instances of syserrno() with syserror()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 90bf7add0d32d5765492fa0c401b2077a2cf8d81
https://github.com/lxc/lxc/commit/90bf7add0d32d5765492fa0c401b2077a2cf8d81
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/cgroups/cgroup2_devices.c
M src/lxc/commands.c
M src/lxc/log.h
Log Message:
-----------
tree-wide: replace remaining instances of syserrno() with syserror_ret()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 7244eabf78a067517c780f2f0f83b9f2dbd1082b
https://github.com/lxc/lxc/commit/7244eabf78a067517c780f2f0f83b9f2dbd1082b
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/log.h
Log Message:
-----------
log: mark logging helpers to use
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 766df09fde0dfbac61f74ed01bb238c524f9b073
https://github.com/lxc/lxc/commit/766df09fde0dfbac61f74ed01bb238c524f9b073
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/commands.c
M src/lxc/log.h
Log Message:
-----------
tree-wide: use new logging helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: bbed2cc0936b6caacb73997cf989da2f045e12ee
https://github.com/lxc/lxc/commit/bbed2cc0936b6caacb73997cf989da2f045e12ee
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/commands.c
M src/lxc/log.h
Log Message:
-----------
tree-wide: replace old systrace logging helpers
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 80f2edac8b8c349a3a58515edf09977bdf8061a4
https://github.com/lxc/lxc/commit/80f2edac8b8c349a3a58515edf09977bdf8061a4
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/log.h
Log Message:
-----------
tree-wide: replace old-style sysinfo logging return helper
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 0b1fe966e5c8ad8ce7f4f158837ad5616c34e408
https://github.com/lxc/lxc/commit/0b1fe966e5c8ad8ce7f4f158837ad5616c34e408
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: make callback naming consistent and understandable
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 07d608d5b112979c90ea14b65ffbedab8232703a
https://github.com/lxc/lxc/commit/07d608d5b112979c90ea14b65ffbedab8232703a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: fix coding style in lxc_create_network_unpriv_exec()
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 56ea6817e0355166bccb6e1d60c86065e8cebc05
https://github.com/lxc/lxc/commit/56ea6817e0355166bccb6e1d60c86065e8cebc05
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile_utils.c
Log Message:
-----------
confile_utils: ensure memory is zeroed
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 4b908a581a00d0e18ece64a9e1caceb73efecec5
https://github.com/lxc/lxc/commit/4b908a581a00d0e18ece64a9e1caceb73efecec5
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: fix grammar
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 101beec53dea299ccfd644b993f7fb5898f4b827
https://github.com/lxc/lxc/commit/101beec53dea299ccfd644b993f7fb5898f4b827
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: add lxc_network_info struct
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: f6a3d6ece9b8b6c447a0556415d9e32a9222e327
https://github.com/lxc/lxc/commit/f6a3d6ece9b8b6c447a0556415d9e32a9222e327
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
M src/lxc/network.h
Log Message:
-----------
network: handle name collisions when renaming network devices
LXC moves network devices into the target namespace based on their created
name. The created name can either be randomly generated for e.g. veth
devices or it can be the name of the existing device in the server's
namespaces. This is e.g. the case when moving physical devices. However this
can lead to weird clashes. Consider we have a network namespace that has the
following devices:
4: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
link/ether 00:16:3e:91:d3:ae brd ff:ff:ff:ff:ff:ff permaddr 00:16:3e:e7:5d:10
altname enp7s0
5: eth2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
link/ether 00:16:3e:e7:5d:10 brd ff:ff:ff:ff:ff:ff permaddr 00:16:3e:91:d3:ae
altname enp8s0
and the user generates the following network config for their container:
lxc.net.0.type = phys
lxc.net.0.name = eth1
lxc.net.0.link = eth2
lxc.net.1.type = phys
lxc.net.1.name = eth2
lxc.net.1.link = eth1
This would cause LXC to move the devices eth1 and eth2 from the server's
network namespace into the container's network namespace:
24: eth1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
link/ether 00:16:3e:91:d3:ae brd ff:ff:ff:ff:ff:ff permaddr 00:16:3e:e7:5d:10
altname enp7s0
25: eth2: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
link/ether 00:16:3e:e7:5d:10 brd ff:ff:ff:ff:ff:ff permaddr 00:16:3e:91:d3:ae
altname enp8s0
According to the network config above we now need to rename the network
devices in the container's network namespace. Let's say we start with
renaming eth2 to eth1. This would immediately lead to a clash since the
container's network namespace already contains a network device with that
name. Renaming the other device would have the same problem.
There are multiple ways to fix this but I'm concerned with keeping the logic
somewhat reasonable which is why we simply start creating transient device
names that are unique which we'll use to move and rename the network device
in the container's network namespace at the same time. And then we rename
based on those random devices names to the target name.
Fixes: #3696
Reported-by: Sam Boyles <sam.boyles at alliedtelesis.co.nz>
Reported-by: Blair Steven <blair.steven at alliedtelesis.co.nz>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: d87de00db2b7848164910c4bec7605946a3bc017
https://github.com/lxc/lxc/commit/d87de00db2b7848164910c4bec7605946a3bc017
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/network.c
Log Message:
-----------
network: use two passes through networks
Consider the following network layout:
lxc.net.0.type = phys
lxc.net.0.link = eth2
lxc.net.0.name = eth%d
lxc.net.1.type = phys
lxc.net.1.link = eth1
lxc.net.1.name = eth0
If we simply follow this order and create the first network first the kernel
will allocate eth0 for the first network but the second network requests
that eth1 be renamed to eth0 in the container's network namespace which
would lead to a clash.
Note, we don't handle cases like:
lxc.net.0.type = phys
lxc.net.0.link = eth2
lxc.net.0.name = eth0
lxc.net.1.type = phys
lxc.net.1.link = eth1
lxc.net.1.name = eth0
That'll brutally fail of course but there's nothing we can do about it. But
this can happen when e.g. a has the following LXD configuration:
devices:
eth2:
name: eth0
nictype: physical
parent: eth2
type: nic
eth3:
name: eth0
nictype: physical
parent: eth3
type: nic
in the container's config and the default profile has:
devices:
eth0:
name: eth0
network: lxdbr0
type: nic
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 609c501931cd5e3a89cda9ec1877cee8f83cc06a
https://github.com/lxc/lxc/commit/609c501931cd5e3a89cda9ec1877cee8f83cc06a
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/cgroups/cgfsng.c
M src/lxc/conf.c
M src/lxc/conf.h
M src/lxc/file_utils.h
M src/lxc/namespace.c
M src/lxc/namespace.h
M src/lxc/start.c
M src/lxc/string_utils.c
M src/lxc/string_utils.h
M src/lxc/utils.c
M src/lxc/utils.h
Log Message:
-----------
conf: ease backports by carrying unused structs
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Commit: 2a25eb27927f35bc6d387dfc10fc3f9a5c6fb677
https://github.com/lxc/lxc/commit/2a25eb27927f35bc6d387dfc10fc3f9a5c6fb677
Author: Christian Brauner <christian.brauner at ubuntu.com>
Date: 2021-02-26 (Fri, 26 Feb 2021)
Changed paths:
M src/lxc/confile_utils.c
M src/lxc/macro.h
M src/lxc/network.c
M src/lxc/network.h
Log Message:
-----------
network: carry some structs to ease backports
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>
Compare: https://github.com/lxc/lxc/compare/aff7ab782e16...2a25eb27927f
More information about the lxc-devel
mailing list