[lxc-devel] [lxc/lxc] 0437ea: commands: use IN_SET() in lxc_cmd()

Thu Feb 25 23:24:21 UTC 2021

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 0437eac56910160adbf2f722711c0577c28ed5dc
      https://github.com/lxc/lxc/commit/0437eac56910160adbf2f722711c0577c28ed5dc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: use IN_SET() in lxc_cmd()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8a598112ddf03ab4709cfbaf53127eebbfa8b9a8
      https://github.com/lxc/lxc/commit/8a598112ddf03ab4709cfbaf53127eebbfa8b9a8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: switch to bool

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6834acfffbe8ed5f021533c9ccaafd07f62f3bed
      https://github.com/lxc/lxc/commit/6834acfffbe8ed5f021533c9ccaafd07f62f3bed
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/commands.h
    M src/lxc/start.c

  Log Message:
  -----------
  commands: s/lxc_cmd_init()/lxc_server_init()/g

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 58a8d1f07de30ddbd79ca6405a70c3f930e1c56e
      https://github.com/lxc/lxc/commit/58a8d1f07de30ddbd79ca6405a70c3f930e1c56e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.h

  Log Message:
  -----------
  commands: add lxc_cmd_init() and lxc_cmd_data()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 38d14ebda65bb1a8eaa2b0e6a50b811e38d355b6
      https://github.com/lxc/lxc/commit/38d14ebda65bb1a8eaa2b0e6a50b811e38d355b6
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_try_cmd() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 22642823aca74f32c87390f7b9c2c25ab78fd638
      https://github.com/lxc/lxc/commit/22642823aca74f32c87390f7b9c2c25ab78fd638
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_init_pid() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7208e700bb9f3376367146a31479900fda5570a7
      https://github.com/lxc/lxc/commit/7208e700bb9f3376367146a31479900fda5570a7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_init_pidfd() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f7a7b0955ad2936b2a5e7b12fe0d66c99e6d9fa5
      https://github.com/lxc/lxc/commit/f7a7b0955ad2936b2a5e7b12fe0d66c99e6d9fa5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_devpts_fd() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f0af9082578c146700f52f3e49364198b6d8a9b8
      https://github.com/lxc/lxc/commit/f0af9082578c146700f52f3e49364198b6d8a9b8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_seccomp_notify_fd() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 19d141f686456f5fdd698a1a5e5a9715e7b130d5
      https://github.com/lxc/lxc/commit/19d141f686456f5fdd698a1a5e5a9715e7b130d5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_cgroup_ctx() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b4e1a2e8e7ea8e846048b7367225d75b2b83c75e
      https://github.com/lxc/lxc/commit/b4e1a2e8e7ea8e846048b7367225d75b2b83c75e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_clone_flags() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f85d2385c03eaa1e1a930b1be39674726c48eaae
      https://github.com/lxc/lxc/commit/f85d2385c03eaa1e1a930b1be39674726c48eaae
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/commands.h

  Log Message:
  -----------
  commands: portlxc_cmd_get_cgroup_path_do() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 187e46ab3216e670239ed1e2549cd3ea0bfd8ffd
      https://github.com/lxc/lxc/commit/187e46ab3216e670239ed1e2549cd3ea0bfd8ffd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_config_item() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1b08494ee5470ae8e5d49824fb857bd83de20f69
      https://github.com/lxc/lxc/commit/1b08494ee5470ae8e5d49824fb857bd83de20f69
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_state() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: dbdd56c120a4e426038655e9ef4b73ebeb05befe
      https://github.com/lxc/lxc/commit/dbdd56c120a4e426038655e9ef4b73ebeb05befe
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_stop() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1a37ba9d55f144c4f4edac11545b2ee2a0ecac70
      https://github.com/lxc/lxc/commit/1a37ba9d55f144c4f4edac11545b2ee2a0ecac70
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_get_tty_fd() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 16fcb1fed01d01887584c7ac4dc3c282bf6690ce
      https://github.com/lxc/lxc/commit/16fcb1fed01d01887584c7ac4dc3c282bf6690ce
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_name() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9dca720777962a4b8dd6ce609e78f398d3e19882
      https://github.com/lxc/lxc/commit/9dca720777962a4b8dd6ce609e78f398d3e19882
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_lxcpath() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3de3c9e365dfeb5d829c696916d59841cddff74e
      https://github.com/lxc/lxc/commit/3de3c9e365dfeb5d829c696916d59841cddff74e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_add_state_client() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9338a6f341751309753effe1cae611b71fa65f41
      https://github.com/lxc/lxc/commit/9338a6f341751309753effe1cae611b71fa65f41
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_add_bpf_device_cgropu() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: dda7dc08f5c04e99b94788d0f76bdc84e7f239a7
      https://github.com/lxc/lxc/commit/dda7dc08f5c04e99b94788d0f76bdc84e7f239a7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_console_log() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c58b63fe1296abe622552753aa10ea1d7b13bd64
      https://github.com/lxc/lxc/commit/c58b63fe1296abe622552753aa10ea1d7b13bd64
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_serve_state_clients() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6e6621177197198877e24852b107847198af0d26
      https://github.com/lxc/lxc/commit/6e6621177197198877e24852b107847198af0d26
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_seccomp_notify_add_listener() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ac91e5151b3b3ce5dd6a0189430f690ce71549cb
      https://github.com/lxc/lxc/commit/ac91e5151b3b3ce5dd6a0189430f690ce71549cb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_freeze() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 558cb2b58d75785684e4db7b6ccc48d3a40e7e69
      https://github.com/lxc/lxc/commit/558cb2b58d75785684e4db7b6ccc48d3a40e7e69
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_unfreeze() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: e83494bb56ca0ec3b6b1320260f0d33c9079def2
      https://github.com/lxc/lxc/commit/e83494bb56ca0ec3b6b1320260f0d33c9079def2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_cgroup_fd() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3d7661aa6763dbc6b2883a00eb18a8b4a995a287
      https://github.com/lxc/lxc/commit/3d7661aa6763dbc6b2883a00eb18a8b4a995a287
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_limit_cgroup_fd() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: dab4f69fe083a8b91814bf15db249e04f81a28f5
      https://github.com/lxc/lxc/commit/dab4f69fe083a8b91814bf15db249e04f81a28f5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_cgroup2_fd() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 962c70c562621c0bafd91956f2fbb69907a8d27c
      https://github.com/lxc/lxc/commit/962c70c562621c0bafd91956f2fbb69907a8d27c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port lxc_cmd_get_limit_cgroup2_fd() to new helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 57fc2dd7e63628bb8ea6f777d7b47524adbd5ba0
      https://github.com/lxc/lxc/commit/57fc2dd7e63628bb8ea6f777d7b47524adbd5ba0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: let lxc_cmd() return ssize_t to indicate that it returns not just 0 on success

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 265dc73af65742b65ed4bcf025f1e7c5d5fd23b1
      https://github.com/lxc/lxc/commit/265dc73af65742b65ed4bcf025f1e7c5d5fd23b1
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/macro.h

  Log Message:
  -----------
  macro: add hweight*() helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 780215cf0d9d02c7d022f18c1bf7aaed509d5835
      https://github.com/lxc/lxc/commit/780215cf0d9d02c7d022f18c1bf7aaed509d5835
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/af_unix.c
    M src/lxc/af_unix.h

  Log Message:
  -----------
  af_unix: allow caller and callee to negotiate expectations and reality

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3a9daa046cf3bab85122844a97bf076f16cb9f5d
      https://github.com/lxc/lxc/commit/3a9daa046cf3bab85122844a97bf076f16cb9f5d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/log.h

  Log Message:
  -----------
  commands: rework lxc_cmd_rsp_recv() to make it more obvious

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d2560c4e21783606a42e8e0777a4531dec97dfab
      https://github.com/lxc/lxc/commit/d2560c4e21783606a42e8e0777a4531dec97dfab
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/commands.h

  Log Message:
  -----------
  commands: improve lxc_cmd_get_tty_fd()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 161e4bef903ed0e8b43a82d00eae96360ec782ce
      https://github.com/lxc/lxc/commit/161e4bef903ed0e8b43a82d00eae96360ec782ce
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/tests/lxc-test-lxc-attach
    M src/tests/lxc-test-unpriv

  Log Message:
  -----------
  tests: add logging to lxc-test-lxc-attach

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8aa82616b19734a3e80394da88e922c2d9ef646c
      https://github.com/lxc/lxc/commit/8aa82616b19734a3e80394da88e922c2d9ef646c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  log: add some more log and return helpers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: daad4f954c67d2a46309621071fb499828c61431
      https://github.com/lxc/lxc/commit/daad4f954c67d2a46309621071fb499828c61431
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: use debug logging

It is fine to fail these commands when a new client talks to an old server or
the kernel doesn't support the necessary features.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 885bb002a595be4337f641e0b532ff8743da29c3
      https://github.com/lxc/lxc/commit/885bb002a595be4337f641e0b532ff8743da29c3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: port misnamed functions to general style

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: cca31bf0ac6d673f0ff6c5bce1d1f4ca04a34396
      https://github.com/lxc/lxc/commit/cca31bf0ac6d673f0ff6c5bce1d1f4ca04a34396
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2021-02-25 (Thu, 25 Feb 2021)

  Changed paths:
    M src/lxc/af_unix.c
    M src/lxc/af_unix.h
    M src/lxc/commands.c
    M src/lxc/commands.h
    M src/lxc/log.h
    M src/lxc/macro.h
    M src/lxc/start.c
    M src/tests/lxc-test-lxc-attach
    M src/tests/lxc-test-unpriv

  Log Message:
  -----------
  Merge pull request #3697 from brauner/2021-02-25/fixes

commands: improvements and fixes

Compare: https://github.com/lxc/lxc/compare/2be31fed4082...cca31bf0ac6d