[lxc-devel] [lxc/lxc] 1d5446: memory_utils: fix close_equal()

Tue Feb 23 20:08:20 UTC 2021

  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: 1d5446120b4312647fd700bf984e955ab65aa21c
      https://github.com/lxc/lxc/commit/1d5446120b4312647fd700bf984e955ab65aa21c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
    M src/lxc/memory_utils.h

  Log Message:
  -----------
  memory_utils: fix close_equal()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7f02fd24f726d0f01b4946415fdb91ec906d17ea
      https://github.com/lxc/lxc/commit/7f02fd24f726d0f01b4946415fdb91ec906d17ea
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: skip and warn about invalid file descriptors

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d39f72b8b675fc4751b4fac4cd5279a20262106c
      https://github.com/lxc/lxc/commit/d39f72b8b675fc4751b4fac4cd5279a20262106c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: start stashing all fds

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 840eec19c3bd3d26b4bc38fab30339bfc43d0890
      https://github.com/lxc/lxc/commit/840eec19c3bd3d26b4bc38fab30339bfc43d0890
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/start.c

  Log Message:
  -----------
  cgroups: close dfd_mon but keep dfd_con and dfd_lim open for all cgroup hierarchies

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 61cebd7a1bed01fb989f7f0d9516847468355a81
      https://github.com/lxc/lxc/commit/61cebd7a1bed01fb989f7f0d9516847468355a81
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
    M src/lxc/commands.h

  Log Message:
  -----------
  commands: explicitly number enums

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: da63ea6b4dd886bb1b8c2f04dce2030d13d4b843
      https://github.com/lxc/lxc/commit/da63ea6b4dd886bb1b8c2f04dce2030d13d4b843
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-22 (Mon, 22 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: tweak validate_string_request()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d17c815dedffb98b5e7ffc7b1f8fb69577358f63
      https://github.com/lxc/lxc/commit/d17c815dedffb98b5e7ffc7b1f8fb69577358f63
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/af_unix.c
    M src/lxc/af_unix.h
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/commands.c
    M src/lxc/conf.c
    M src/lxc/seccomp.c
    M src/lxc/start.c

  Log Message:
  -----------
  af_unix: improve SCM_RIGHTS file descriptor retrieval

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c674e0f6e7895c101b240fe6a4babef029748c41
      https://github.com/lxc/lxc/commit/c674e0f6e7895c101b240fe6a4babef029748c41
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup.h

  Log Message:
  -----------
  cgroups: add cgroup_fds() helper

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 89420aff3681cd1d7b878b4ee61c2bb112a18b3d
      https://github.com/lxc/lxc/commit/89420aff3681cd1d7b878b4ee61c2bb112a18b3d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/state.c

  Log Message:
  -----------
  state: _never_ return NULL from lxc_state2str()

Cc: Thomas Parrott <thomas.parrott at canonical.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 32fd8d4f85534705eee90e828d58c27f870e215e
      https://github.com/lxc/lxc/commit/32fd8d4f85534705eee90e828d58c27f870e215e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: be more explicit during command processing

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4b5f4bdcdee78d8a0080db68b86b9f3090b8cdef
      https://github.com/lxc/lxc/commit/4b5f4bdcdee78d8a0080db68b86b9f3090b8cdef
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: introduce lxc_cmd_rsp_send_reap()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c2f40088896cff9c86c8f0dcb78f2611afa5fd03
      https://github.com/lxc/lxc/commit/c2f40088896cff9c86c8f0dcb78f2611afa5fd03
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: introduce rsp_one_fd()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9c3eb8d5258aa06ce057847c6fe03ff1db75736b
      https://github.com/lxc/lxc/commit/9c3eb8d5258aa06ce057847c6fe03ff1db75736b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: introduce rsp_many_fds()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f8cc4ae8be0665c8bef9604ece979b5ab30d9b3c
      https://github.com/lxc/lxc/commit/f8cc4ae8be0665c8bef9604ece979b5ab30d9b3c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c
    M src/lxc/commands.h

  Log Message:
  -----------
  commands: add LXC_CMD_GET_CGROUP_FD

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 2092492ca613349a88aeb6199126fc610bf43ecf
      https://github.com/lxc/lxc/commit/2092492ca613349a88aeb6199126fc610bf43ecf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/commands.c

  Log Message:
  -----------
  cgroups: allow cgroup fd batch retrieval

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: a1feaf29447c061b868d2c49644f0877b601f97e
      https://github.com/lxc/lxc/commit/a1feaf29447c061b868d2c49644f0877b601f97e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/macro.h

  Log Message:
  -----------
  macro: add min() macro

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d329cda71b8972fdac2a4fc70403fc81602c1e53
      https://github.com/lxc/lxc/commit/d329cda71b8972fdac2a4fc70403fc81602c1e53
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: add copy_struct_from_client()

Which is our variant of copy_struct_from_user() that Aleksa and I added to the
kernel.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c965e8015f7de9d2092df8a088c47cbc424af81d
      https://github.com/lxc/lxc/commit/c965e8015f7de9d2092df8a088c47cbc424af81d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/log.h

  Log Message:
  -----------
  log: add syswarn_set()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9ec1d9db36272454482b52f511868dc8e11f9c7f
      https://github.com/lxc/lxc/commit/9ec1d9db36272454482b52f511868dc8e11f9c7f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/utils.h

  Log Message:
  -----------
  utils: add copy_struct_to_client()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ef6e048a03268e4ee6ffeb0791f971aad4bcf6d5
      https://github.com/lxc/lxc/commit/ef6e048a03268e4ee6ffeb0791f971aad4bcf6d5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup.h
    M src/lxc/commands.c
    M src/lxc/commands.h

  Log Message:
  -----------
  commands: introduce LXC_CMD_GET_CGROUP_CTX

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c071c112d3e490391dc10602ffc4c3cef9ba009a
      https://github.com/lxc/lxc/commit/c071c112d3e490391dc10602ffc4c3cef9ba009a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h

  Log Message:
  -----------
  cgroups: introduce fd-only cgroup attach

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: ebc548a1efe93cdd21e2258f4c74e78b603a2723
      https://github.com/lxc/lxc/commit/ebc548a1efe93cdd21e2258f4c74e78b603a2723
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: send ENOSYS response

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: d3be623e3cacdf3af655e6d04fb54a7963309fde
      https://github.com/lxc/lxc/commit/d3be623e3cacdf3af655e6d04fb54a7963309fde
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: handle older clients elegantly

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 254a22e17f2ed4b64006beb9f8b17f33d16941a0
      https://github.com/lxc/lxc/commit/254a22e17f2ed4b64006beb9f8b17f33d16941a0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: lxc_cmd_add_state_client_callback()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: fb54db2c34e8ccde64eacc73ea55afa5e15d9e82
      https://github.com/lxc/lxc/commit/fb54db2c34e8ccde64eacc73ea55afa5e15d9e82
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: fix unsupported namespaces

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8af9b5dadb2ac2c897f976def905b1e88e5daf5f
      https://github.com/lxc/lxc/commit/8af9b5dadb2ac2c897f976def905b1e88e5daf5f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/af_unix.c

  Log Message:
  -----------
  af_unix: add comment about cast

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7184e9d280d83f4649efd128cf0d0272cd4d6de2
      https://github.com/lxc/lxc/commit/7184e9d280d83f4649efd128cf0d0272cd4d6de2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: remove additional newline

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8a95cd827108678493d14b7f85c2ffb8861cbd2d
      https://github.com/lxc/lxc/commit/8a95cd827108678493d14b7f85c2ffb8861cbd2d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: handle older clients gracefully

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 00df53300b9f845a8816b717dc37a2c62748ad4d
      https://github.com/lxc/lxc/commit/00df53300b9f845a8816b717dc37a2c62748ad4d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: verify expected file descriptors were sent

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 3a6678c7fb34324d1c71eadbbd92d0a3510a6108
      https://github.com/lxc/lxc/commit/3a6678c7fb34324d1c71eadbbd92d0a3510a6108
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: fix namespace preservation

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b6f48637394816bec7bd0cadfd059ac9fecf0560
      https://github.com/lxc/lxc/commit/b6f48637394816bec7bd0cadfd059ac9fecf0560
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2021-02-23 (Tue, 23 Feb 2021)

  Changed paths:
    M src/lxc/af_unix.c
    M src/lxc/af_unix.h
    M src/lxc/attach.c
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/commands.c
    M src/lxc/commands.h
    M src/lxc/conf.c
    M src/lxc/log.h
    M src/lxc/macro.h
    M src/lxc/memory_utils.h
    M src/lxc/seccomp.c
    M src/lxc/start.c
    M src/lxc/state.c
    M src/lxc/utils.h

  Log Message:
  -----------
  Merge pull request #3689 from brauner/2021-02-21/fixes

cgroups: introduce fd-only cgroup attach via LXC_CMD_GET_CGROUP_CTX

Compare: https://github.com/lxc/lxc/compare/793996583cfd...b6f486373948