[lxc-devel] [lxc/lxc] bd09ee: cgroups: make it extremely obvious that we're tran...

Stéphane Graber noreply at github.com
Thu Feb 18 16:53:10 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/lxc/lxc
  Commit: bd09ee987dce37f6204a35bb0c147438351b1cfd
      https://github.com/lxc/lxc/commit/bd09ee987dce37f6204a35bb0c147438351b1cfd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: make it extremely obvious that we're transitioning from a flag to a type

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 2c4348bd1c3b4ce2c44d255a41b2ad9da6b3c62c
      https://github.com/lxc/lxc/commit/2c4348bd1c3b4ce2c44d255a41b2ad9da6b3c62c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: don't overwrite type

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: bce04069bc1523e6ac7d99a8fc7f0747b57e9055
      https://github.com/lxc/lxc/commit/bce04069bc1523e6ac7d99a8fc7f0747b57e9055
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: fix error values

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 05fe99f3a97d12ddf546af4bb2b19cbe60e28216
      https://github.com/lxc/lxc/commit/05fe99f3a97d12ddf546af4bb2b19cbe60e28216
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: fix print_r() debugging helper

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 11e5c6783e0a1dc40f606e492c169b75c696ae1d
      https://github.com/lxc/lxc/commit/11e5c6783e0a1dc40f606e492c169b75c696ae1d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup.c

  Log Message:
  -----------
  cgroups: free correct path

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7064ee3a922174499dfc65f812cba4de8ea47b0a
      https://github.com/lxc/lxc/commit/7064ee3a922174499dfc65f812cba4de8ea47b0a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h

  Log Message:
  -----------
  cgroups: kill monitor_full_path

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7c37e93740f684b6ec3300ecc99905f0c6eb87e7
      https://github.com/lxc/lxc/commit/7c37e93740f684b6ec3300ecc99905f0c6eb87e7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h
    M src/lxc/commands.c

  Log Message:
  -----------
  bpf: use cgroup fd directly instead of paths

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 4b9dc703d2d0a62a475ed664b7d45ea8ab31a652
      https://github.com/lxc/lxc/commit/4b9dc703d2d0a62a475ed664b7d45ea8ab31a652
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/conf.h

  Log Message:
  -----------
  conf: introduce lxc_bpf_devices_rule_t type

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: bee6ee17b0c7bf48f277137944d4581e27783f12
      https://github.com/lxc/lxc/commit/bee6ee17b0c7bf48f277137944d4581e27783f12
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  -----------
  bpf: use return macros

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8828c61a8b201405e1c3a6ba5a9fc88881d14f8a
      https://github.com/lxc/lxc/commit/8828c61a8b201405e1c3a6ba5a9fc88881d14f8a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  bpf: align struct initialization

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0d450efcf25c2568075bad9651f5aabdf3df2b17
      https://github.com/lxc/lxc/commit/0d450efcf25c2568075bad9651f5aabdf3df2b17
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h
    M src/lxc/commands.c

  Log Message:
  -----------
  bpf: enable helpers to let caller replace existing bpf programs

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 69885a7656802c2698183d5b1017c6b93c1f8e6a
      https://github.com/lxc/lxc/commit/69885a7656802c2698183d5b1017c6b93c1f8e6a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: make device cgroups semantics clearer

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: e41afad55e20327b6fbad77fa531cd90175da3eb
      https://github.com/lxc/lxc/commit/e41afad55e20327b6fbad77fa531cd90175da3eb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: improve bpf device program handling

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: df1a5345cd849c8eeb20f645cf8ef07e59186c45
      https://github.com/lxc/lxc/commit/df1a5345cd849c8eeb20f645cf8ef07e59186c45
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  -----------
  bpf: add helpers for better bpf device program management

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 413e074bbe425037f1cd7ec4072cb6ac9831ddc0
      https://github.com/lxc/lxc/commit/413e074bbe425037f1cd7ec4072cb6ac9831ddc0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: improve bpf device program management

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 934bb475e2c9971ff8315595fb2080499529ed6e
      https://github.com/lxc/lxc/commit/934bb475e2c9971ff8315595fb2080499529ed6e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: improve bpf device program management

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 79bc22bd2445cf41f522a7f978a22c1fb630840d
      https://github.com/lxc/lxc/commit/79bc22bd2445cf41f522a7f978a22c1fb630840d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: replace bpf program on update

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: a38a34f88884c62b4077a34e468965f9b18e9b1b
      https://github.com/lxc/lxc/commit/a38a34f88884c62b4077a34e468965f9b18e9b1b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/macro.h

  Log Message:
  -----------
  macro: add swap helper

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 281f42afaa837beec4604b821109db6350b50fef
      https://github.com/lxc/lxc/commit/281f42afaa837beec4604b821109db6350b50fef
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  -----------
  bpf: use __u32 not uint32_t

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: c38e5c4fd223479dc85bf1eb20e8d224f9715a51
      https://github.com/lxc/lxc/commit/c38e5c4fd223479dc85bf1eb20e8d224f9715a51
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  bpf: don't close invalid fd, simply swap

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 9a2a38b3133c4b49b32e1b6a7aebcef3a2fd3f5d
      https://github.com/lxc/lxc/commit/9a2a38b3133c4b49b32e1b6a7aebcef3a2fd3f5d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: rework bpf devices BPF_F_REPLACE codepath

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7aec2bd3cda5acb7c63b543ae821bed8e158790c
      https://github.com/lxc/lxc/commit/7aec2bd3cda5acb7c63b543ae821bed8e158790c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  bpf: rework bpf_program_cgroup_detach()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 34683e39b950c9d14f0de3ac0f58927947ee9df0
      https://github.com/lxc/lxc/commit/34683e39b950c9d14f0de3ac0f58927947ee9df0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  -----------
  bpf: handling missing defines

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7fc77b1ae07009373e09238a560667b89f58b2f9
      https://github.com/lxc/lxc/commit/7fc77b1ae07009373e09238a560667b89f58b2f9
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    A src/include/bpf.h
    A src/include/bpf_common.h
    M src/lxc/Makefile.am

  Log Message:
  -----------
  bpf: vendor bpf headers

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 928937b114adcde2fd72863a57db3a83c3134f73
      https://github.com/lxc/lxc/commit/928937b114adcde2fd72863a57db3a83c3134f73
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M configure.ac
    M src/lxc/api_extensions.h
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h
    M src/lxc/commands.c

  Log Message:
  -----------
  cgroups: remove compile-time bpf support detection

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 7da502de6a26b8130cbdd36c2337cf3a7c2a996d
      https://github.com/lxc/lxc/commit/7da502de6a26b8130cbdd36c2337cf3a7c2a996d
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  -----------
  bpf: add and use bpf_cgroup_devices_attach() helper

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 354d21c49129a58b2eb985229f852358b25e54ff
      https://github.com/lxc/lxc/commit/354d21c49129a58b2eb985229f852358b25e54ff
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h
    M src/lxc/commands.c

  Log Message:
  -----------
  bpf: let bpf_list_add_device() take the device list directly

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: d202c500d69202cbf458e55dab674193daee72b0
      https://github.com/lxc/lxc/commit/d202c500d69202cbf458e55dab674193daee72b0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  bpf: fix return values in bpf_program_cgroup_attach()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: fd1cf1b1ab013d25f3f1e53ac53ed7b378efaf35
      https://github.com/lxc/lxc/commit/fd1cf1b1ab013d25f3f1e53ac53ed7b378efaf35
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/compiler.h

  Log Message:
  -----------
  compiler: fix fallthrough attribute

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 0a150695b49c95e3fa3c9a787e235cfc5bfdd0b3
      https://github.com/lxc/lxc/commit/0a150695b49c95e3fa3c9a787e235cfc5bfdd0b3
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h
    M src/lxc/commands.c

  Log Message:
  -----------
  bpf: rework live device cgroup update

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3d01776c501b4df7c5f201ca33eafe0f030b6609
      https://github.com/lxc/lxc/commit/3d01776c501b4df7c5f201ca33eafe0f030b6609
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/lxccontainer.c

  Log Message:
  -----------
  lxccontainer: fix reboot logging

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 284868b249cd0f39ef4ef3cf2eb476b0b20ad29a
      https://github.com/lxc/lxc/commit/284868b249cd0f39ef4ef3cf2eb476b0b20ad29a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/memory_utils.h

  Log Message:
  -----------
  memory_utils: add close_equal() and free_equal()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 8c49586f0dc8d09a54db6cbeb4a995d52524f691
      https://github.com/lxc/lxc/commit/8c49586f0dc8d09a54db6cbeb4a995d52524f691
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.c

  Log Message:
  -----------
  cgroups: use close_equal() and free_equal()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: da03dc28e1fed8571b4de6c262a5f127dfb1fe10
      https://github.com/lxc/lxc/commit/da03dc28e1fed8571b4de6c262a5f127dfb1fe10
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  bpf: prevent double-close

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 25903ba9c0b10728a9bf2c0e7d7a9e68c84d39a8
      https://github.com/lxc/lxc/commit/25903ba9c0b10728a9bf2c0e7d7a9e68c84d39a8
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  -----------
  bpf: make bpf_program_cgroup_attach() static

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: ad755295f15029e58e716412a88d6c8cb576c1a7
      https://github.com/lxc/lxc/commit/ad755295f15029e58e716412a88d6c8cb576c1a7
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  -----------
  bpf: simplify bpf (device) program freeing

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 35a68d6df2c240b6604625bd34979ba64db25de7
      https://github.com/lxc/lxc/commit/35a68d6df2c240b6604625bd34979ba64db25de7
  Author: Stéphane Graber <stgraber at ubuntu.com>
  Date:   2021-02-18 (Thu, 18 Feb 2021)

  Changed paths:
    M configure.ac
    A src/include/bpf.h
    A src/include/bpf_common.h
    M src/lxc/Makefile.am
    M src/lxc/api_extensions.h
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/cgroups/cgroup2_devices.h
    M src/lxc/commands.c
    M src/lxc/compiler.h
    M src/lxc/conf.h
    M src/lxc/lxccontainer.c
    M src/lxc/macro.h
    M src/lxc/memory_utils.h
    M src/lxc/utils.c

  Log Message:
  -----------
  Merge pull request #3681 from brauner/2021-02-18/cgroups

cgroups: fixes & bpf rework


Compare: https://github.com/lxc/lxc/compare/599a0c6c9ccb...35a68d6df2c2


More information about the lxc-devel mailing list