[lxc-devel] [lxc/lxc] f9f187: cgroups: bpf fixes

Mon Feb 8 17:24:39 UTC 2021

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: f9f1879966261923e7b106717e804cbdb597f8bf
      https://github.com/lxc/lxc/commit/f9f1879966261923e7b106717e804cbdb597f8bf
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups: bpf fixes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8d22ec0166ee8bbf6b51596e0f93ea99026b37c4
      https://github.com/lxc/lxc/commit/8d22ec0166ee8bbf6b51596e0f93ea99026b37c4
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.h

  Log Message:
  -----------
  croups: improve __do_bpf_program_free

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5e84adf6ffb649e56c445ae4bba138654263f65b
      https://github.com/lxc/lxc/commit/5e84adf6ffb649e56c445ae4bba138654263f65b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups: coding style fixes

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 9dee31e50145ccd06061f8e3277e7874696f9d36
      https://github.com/lxc/lxc/commit/9dee31e50145ccd06061f8e3277e7874696f9d36
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups: don't initiliaze NULL log

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 8f9cd8d0d27399c9a7301125a30942227ee694c2
      https://github.com/lxc/lxc/commit/8f9cd8d0d27399c9a7301125a30942227ee694c2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups: ensure all memory is zeroed

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 61eb36f89cf8079c59b7a4784448c4b3da8c7142
      https://github.com/lxc/lxc/commit/61eb36f89cf8079c59b7a4784448c4b3da8c7142
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: use zalloc

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1aac9f39a0587e52a83197668eee651b0e46b14c
      https://github.com/lxc/lxc/commit/1aac9f39a0587e52a83197668eee651b0e46b14c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: tweak cgroup initialization

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 17b2106bf01d7c58642458c5c622787d3760b91b
      https://github.com/lxc/lxc/commit/17b2106bf01d7c58642458c5c622787d3760b91b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  log: remove pointless inline

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 7491f5a162c26796d8baaac4e51a8e819d676073
      https://github.com/lxc/lxc/commit/7491f5a162c26796d8baaac4e51a8e819d676073
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/log.c
    M src/lxc/log.h

  Log Message:
  -----------
  log: add lxc_log_get_fd()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: cc486b115749a467506dee9d58bf3f03c65736a5
      https://github.com/lxc/lxc/commit/cc486b115749a467506dee9d58bf3f03c65736a5
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/seccomp.c

  Log Message:
  -----------
  seccomp: use lxc_log_get_fd()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 599086c8487dce6c68ce8807e3e6bcd3c3ef5edc
      https://github.com/lxc/lxc/commit/599086c8487dce6c68ce8807e3e6bcd3c3ef5edc
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/log.c

  Log Message:
  -----------
  log: rework lxc_log_get_level()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 5e651c8e7fc99e71bab74cd679da4e8365f5100f
      https://github.com/lxc/lxc/commit/5e651c8e7fc99e71bab74cd679da4e8365f5100f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/seccomp.c

  Log Message:
  -----------
  seccomp: use lxc_log_get_level()

This will now enable LXD users to dump the seccomp filter in the log when
logging at TRACE level.

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 4e977ae8d026247e9126769a8161b5b0eeb4ae42
      https://github.com/lxc/lxc/commit/4e977ae8d026247e9126769a8161b5b0eeb4ae42
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c

  Log Message:
  -----------
  cgroups: use bpf log when logging at trace level

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: b4a42b37d5381da4cc7a8ba8289ed4edab41998b
      https://github.com/lxc/lxc/commit/b4a42b37d5381da4cc7a8ba8289ed4edab41998b
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/log.h
    M src/lxc/seccomp.c

  Log Message:
  -----------
  log: add lxc_log_trace() helper

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 76651de6decac24de6c17a1cdb763e4a46e4812a
      https://github.com/lxc/lxc/commit/76651de6decac24de6c17a1cdb763e4a46e4812a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgroup2_devices.c
    M src/lxc/macro.h

  Log Message:
  -----------
  cgroups: use PTR_TO_U64()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 76746bc5fdb444824cd2d4d89a63cc2b9950fa8c
      https://github.com/lxc/lxc/commit/76746bc5fdb444824cd2d4d89a63cc2b9950fa8c
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: align methods

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 55fd921789b0909da6098c8474111ffae7b8594f
      https://github.com/lxc/lxc/commit/55fd921789b0909da6098c8474111ffae7b8594f
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/utils.c

  Log Message:
  -----------
  utils: use SYSTRACE() when logging stdio permission fixup failures

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 971dcc4313b9eb8892fc46b23c7a18474fb6407e
      https://github.com/lxc/lxc/commit/971dcc4313b9eb8892fc46b23c7a18474fb6407e
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: log failues to dup2() with SYSDEBUG()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: f235460c3cbceaa3cc411bc321ba2434ca585e99
      https://github.com/lxc/lxc/commit/f235460c3cbceaa3cc411bc321ba2434ca585e99
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: fix logging for stdfd replacement

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 1cc616fe8c84a9681af451c4e8791d152a07edc2
      https://github.com/lxc/lxc/commit/1cc616fe8c84a9681af451c4e8791d152a07edc2
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/attach.c

  Log Message:
  -----------
  attach: fix error checking for dup2()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: c9186cc9271579bf4456fcd32c979a9912afa7bb
      https://github.com/lxc/lxc/commit/c9186cc9271579bf4456fcd32c979a9912afa7bb
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: initialize variable

Fixes: Coverity 1472651
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 639428eb59880a70e1e179a0c1aae53210df3148
      https://github.com/lxc/lxc/commit/639428eb59880a70e1e179a0c1aae53210df3148
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/commands_utils.c

  Log Message:
  -----------
  commands_utils: don't leak memory

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: eb30db661b946219c8f67b2ce1e9b1bc8063bd3a
      https://github.com/lxc/lxc/commit/eb30db661b946219c8f67b2ce1e9b1bc8063bd3a
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/conf.c

  Log Message:
  -----------
  conf: use lxc_log_trace()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: 6f86b90ddaeb67e80ca587db7dec7de5f5f36654
      https://github.com/lxc/lxc/commit/6f86b90ddaeb67e80ca587db7dec7de5f5f36654
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/confile_utils.c

  Log Message:
  -----------
  confile_utils: use lxc_log_trace()

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

  Commit: aff7ab782e168bda7a7a422fbe6a04be2cd40a64
      https://github.com/lxc/lxc/commit/aff7ab782e168bda7a7a422fbe6a04be2cd40a64
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2021-02-08 (Mon, 08 Feb 2021)

  Changed paths:
    M src/lxc/rexec.c

  Log Message:
  -----------
  rexec: check lseek() return value

Not really needed buy ok.

Fixes: Coverity: 1472769
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>

Compare: https://github.com/lxc/lxc/compare/5b8e411ec79a...aff7ab782e16