[lxc-devel] [lxd/master] revert/revert.go: remove a for-loop from Clone() method

[TimRots on Github]

A non-text attachment was scrubbed...
Name: not available
Type: text/x-mailbox
Size: 398 bytes
Desc: not available
URL: <http://lists.linuxcontainers.org/pipermail/lxc-devel/attachments/20201016/c08284dc/attachment.bin>
-------------- next part --------------
From 22b08974776a5d2135215bdd66286e7ccb42ba56 Mon Sep 17 00:00:00 2001
From: Tim Rots <tim.rots at protonmail.ch>
Date: Fri, 16 Oct 2020 19:08:35 +0200
Subject: [PATCH] revert/revert.go: remove a for-loop from Clone()

Use a single append to concatenate two slices

Signed-off-by: Tim Rots <tim.rots at protonmail.ch>
---
 lxd/revert/revert.go | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lxd/revert/revert.go b/lxd/revert/revert.go
index dbe65b7edf..4b8642a55d 100644
--- a/lxd/revert/revert.go
+++ b/lxd/revert/revert.go
@@ -38,10 +38,7 @@ func (r *Reverter) Success() {
 func (r *Reverter) Clone() *Reverter {
 	rNew := New()
 	rNew.revertFuncs = make([]func(), 0, len(r.revertFuncs))
-
-	for _, f := range r.revertFuncs {
-		rNew.revertFuncs = append(rNew.revertFuncs, f)
-	}
+	rNew.revertFuncs = append(rNew.revertFuncs, r.revertFuncs...)
 
 	return rNew
 }