[lxc-devel] [lxc/lxc] dc89b0: introduce lxc.cgroup.dir.{monitor, container, contai...

[Christian Brauner]

  Branch: refs/heads/stable-4.0
  Home:   https://github.com/lxc/lxc
  Commit: dc89b0d7954c85981056407b0305621b598007c9
      https://github.com/lxc/lxc/commit/dc89b0d7954c85981056407b0305621b598007c9
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2020-05-25 (Mon, 25 May 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/cgroups/cgroup.h
    M src/lxc/commands.c
    M src/lxc/commands.h
    M src/lxc/conf.h
    M src/lxc/criu.c

  Log Message:
  -----------
  introduce lxc.cgroup.dir.{monitor,container,container.inner}

This is a new approach to #1302 with a container-side
configuration instead of a global boolean flag.

Contrary to the previous PR using an optional additional
parameter for the get-cgroup command, this introduces two
new additional commands to get the limiting cgroup path and
cgroup2 file descriptor. If the limiting option is not in
use, these behave identical to their full-path counterparts.

If these variables are used the payload will end up in the
concatenation of lxc.cgroup.dir.container and
lxc.cgroup.dir.container.inner (which may be empty), and the
monitor will end up in lxc.cgruop.dir.monitor. The
directories are fixed, no retry count logic is applied,
failing to create these directories will simply be a hard
error.

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: bba910b2ff2cca6fbca41c53e39581169e0278de
      https://github.com/lxc/lxc/commit/bba910b2ff2cca6fbca41c53e39581169e0278de
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-05-25 (Mon, 25 May 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: remove unused variable

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 3537c31640caf42185608cf93524e2f04a4727d9
      https://github.com/lxc/lxc/commit/3537c31640caf42185608cf93524e2f04a4727d9
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2020-05-25 (Mon, 25 May 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c
    M src/lxc/start.c

  Log Message:
  -----------
  cgroup isolation: handle devices cgroup early

Otherwise we cannot use an 'a' entry in devices.deny/allow
as these are not permitted once a subdirectory was created.

Without isolation we initialize the devices cgroup
particularly late, so there are probably cases which cannot
work with isolation.

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>


  Commit: 8bbfacd2b488d6d681dbf59a2df7256b137e0f6e
      https://github.com/lxc/lxc/commit/8bbfacd2b488d6d681dbf59a2df7256b137e0f6e
  Author: Wolfgang Bumiller <w.bumiller at proxmox.com>
  Date:   2020-05-25 (Mon, 25 May 2020)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  improve LXC_CMD_GET_CGROUP compatibility

When a newer lxc library communicates with an older one
(such as running an lxc 4.0 lxc-freeze on a longer running
container which was started while lxc was still at version
3), the LXC_CMD_GET_LIMITING_CGROUP command is not
available, causing the remote to just close the socket.
Catch this and try the previous command instead.

Signed-off-by: Wolfgang Bumiller <w.bumiller at proxmox.com>


  Commit: 202e017e59cf395d88da37544ee2ef5e3d84c3a0
      https://github.com/lxc/lxc/commit/202e017e59cf395d88da37544ee2ef5e3d84c3a0
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-05-25 (Mon, 25 May 2020)

  Changed paths:
    M src/lxc/cgroups/cgfsng.c

  Log Message:
  -----------
  cgroups: be less alarming when creating cgroups

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


  Commit: 53fbc128f3b4758173d1aa63ead91e3e85bd68cd
      https://github.com/lxc/lxc/commit/53fbc128f3b4758173d1aa63ead91e3e85bd68cd
  Author: Christian Brauner <christian.brauner at ubuntu.com>
  Date:   2020-05-25 (Mon, 25 May 2020)

  Changed paths:
    M src/lxc/commands.c

  Log Message:
  -----------
  commands: make limiting cgroup callbacks unreachable

Signed-off-by: Christian Brauner <christian.brauner at ubuntu.com>


Compare: https://github.com/lxc/lxc/compare/0c9e185c9625...53fbc128f3b4